Uh oh!
There was an error while loading. Please reload this page.
[Runtime] Compatibility with dmlc::Stream API changes - #16998
Merged
tqchen merged 4 commits intoMay 30, 2024
Conversation
This commit updates TVM implementations of `dmlc::Stream`. With dmlc/dmlc-core#686, this API now requires the `Write` method to return the number of bytes written. This change allows partial writes to be correctly handled.
Lunderberg
commented
May 14, 2024
ContributorAuthor
This PR is marked as a draft, until the upstream dmlc changes land. At that point, this PR will be updated to also include a version bump for |
Lunderberg
marked this pull request as ready for review
May 22, 2024 13:19
Lunderberg
commented
May 22, 2024
ContributorAuthor
Upstream |
tqchen
commented
May 28, 2024
Member
@tvm-bot rerun |
Lunderberg
commented
May 29, 2024
ContributorAuthor
tqchen
approved these changes
May 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates TVM implementations of
dmlc::Stream. With dmlc/dmlc-core#686, this API now requires theWritemethod to return the number of bytes written. This change allows partial writes to be correctly handled.