[TOPI] Add dense schedule for fp16 and fp32 using gemm - #17091

Merged
ekalda merged 15 commits into
apache:mainfrom
eirenevp:gemm-dense
Jul 9, 2024
Merged

[TOPI] Add dense schedule for fp16 and fp32 using gemm#17091
ekalda merged 15 commits into
apache:mainfrom
eirenevp:gemm-dense

Conversation

@eirenevp

@eirenevpeirenevp commented Jun 13, 2024

Copy link
Copy Markdown

Add a new schedule for the dense operator
based on the gemm algorithm.

Eirene Pandi
[TOPI] Add dense schedule for fp16 and fp32 using gemm
b2ac3ab
Add a new schedule for the dense operator
based on the gemm algorithm.
Change-Id: Iaf4423d21d20b5813c77a0a27c4751f8cbd1d8b8
@ekalda

ekalda commented Jun 13, 2024

Copy link
Copy Markdown
Contributor

cc @Anndrey24@lhutton1@leandron

Eirini Vlassi Pandi added 2 commits June 13, 2024 14:51
Eirini Vlassi Pandi
[TOPI] Restore topi x86 dense file
8c74c3c
Change-Id: I545a805f40197db01d91ce622a890754d4a3b901
Eirini Vlassi Pandi
[lint] Ignore unused args and disable mypy type checking
6eea7a6
Change-Id: Ica02890f132b67e3c9bd64f3fb98ee8c060e8c05
Anndrey24
Anndrey24 reviewed Jun 14, 2024
View reviewed changes

@Anndrey24Anndrey24 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @eirenevp ! It's great to finally have an arm_cpu-specific dense schedule which we could possibly extend to also generate SVE instructions in the future.
I've just left a few comments based on my experience with the conv2d schedule.

Comment threadcmake/config.cmake
Comment threadpython/tvm/relay/op/strategy/arm_cpu.py
Comment threadpython/tvm/relay/op/strategy/arm_cpu.py
Comment threadpython/tvm/topi/arm_cpu/dense_alter_op.py Outdated
Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py Outdated
Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py Outdated
Comment threadtests/python/relay/test_dense.py Outdated
Comment threadtests/python/relay/test_dense.py Outdated
Comment threadtests/python/relay/test_dense.py Outdated
Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py Outdated
Eirini Vlassi Pandi added 11 commits June 17, 2024 17:17
Eirini Vlassi Pandi
[TOPI] Update dense shedule files
17bfe7c
Change-Id: I11126864bdcfec1c88dbc39bafa18c8b78bbe5fc
Eirini Vlassi Pandi
[lint] Disable invalid names
0362f62
Change-Id: Ibbcfa2a94d14c9013e231c95725b0f651ae4ff46
Eirini Vlassi Pandi
[TOPI] Change tol depending on dtpye for test dense
9eda309
Change-Id: Iaefc79b7c415d4cdca2917b5c5fa5842eba2f71d
Eirini Vlassi Pandi
[TOPI] Run dense gemm test only on aarch64
eefb274
Change-Id: Ia6468fe6cf113781819c871e1f110bf4e98a3d59
Eirini Vlassi Pandi
[lint] Lint test dense file
c6ca352
Change-Id: I3e5c532ed041c691237bf04fda4645bf25befbcc
Eirini Vlassi Pandi
[TOPI] Update dense_alter_op to work with relay.traspose
a60717b
Change-Id: I1217eaec3b63eccfa32bcbf3b410f09fa0997f36
Eirini Vlassi Pandi
[TOPI] Update test_select_implementation
0f8aa94
Change-Id: Iccd59c8afdd70a98da031ff2d0cf8f5d3378a700
Eirini Vlassi Pandi
[TOPI] Fix test_select_implementationfor dense_gemm.arm_cpu
078988d
Change-Id: I8851b227a9dacf90046e4d3d1b0418355145e79a
Eirini Vlassi Pandi
[TOPI] Remove topi test for arm cpu dense
0822244
Change-Id: Ib50606a829142202142b326a111580f9eec72f8c
Eirini Vlassi Pandi
[TOPI] Run keras test with level 3 opt
f6d7a17
Change-Id: I44bf4bfbf85b5ab4fa91d653af25ae22f01ed79a
Eirini Vlassi Pandi
[TOPI] Disable test any dense for aarch64
6f5fb0f
Change-Id: Ie85f7d5c6d0e99fc389bd9b3f29787065e1e0cd0
Eirini Vlassi Pandi
[lint] tests/python/relay/test_any.py
e0b544a
Change-Id: I170e09358b61217586adc3591c020b065e2f5d3e
ekalda
ekalda approved these changes Jul 9, 2024
View reviewed changes

@ekaldaekalda left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the work on this @eirenevp!

@ekalda
ekalda merged commit c4e6f96 into apache:mainJul 9, 2024
@ysh329ysh329 mentioned this pull request Jul 20, 2024
Closed
@kurisu6912kurisu6912 mentioned this pull request Sep 5, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lhutton1lhutton1lhutton1 left review comments
@ekaldaekaldaekalda approved these changes
+1 more reviewer
@Anndrey24Anndrey24Anndrey24 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@eirenevp@ekalda@Anndrey24@lhutton1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[TOPI] Add dense schedule for fp16 and fp32 using gemm - #17091
Merged
ekalda merged 15 commits into
apache:mainfrom 
eirenevp:gemm-dense
Jul 9, 2024
Merged
[TOPI] Add dense schedule for fp16 and fp32 using gemm#17091
ekalda merged 15 commits into
apache:mainfrom 
eirenevp:gemm-dense
Conversation
@eirenevp
@eirenevpeirenevp
commented
Jun 13, 2024

Copy link


Copy Markdown

Add a new schedule for the dense operator

based on the gemm algorithm.
Eirene Pandi
[TOPI] Add dense schedule for fp16 and fp32 using gemm
b2ac3ab
Add a new schedule for the dense operator
based on the gemm algorithm.
Change-Id: Iaf4423d21d20b5813c77a0a27c4751f8cbd1d8b8
@ekalda
ekalda
commented
Jun 13, 2024

Copy link


Copy Markdown

Contributor
cc @Anndrey24@lhutton1@leandron
Eirini Vlassi Pandi
added 2 commits
June 13, 2024 14:51
Eirini Vlassi Pandi
[TOPI] Restore topi x86 dense file
8c74c3c
Change-Id: I545a805f40197db01d91ce622a890754d4a3b901
Eirini Vlassi Pandi
[lint] Ignore unused args and disable mypy type checking
6eea7a6
Change-Id: Ica02890f132b67e3c9bd64f3fb98ee8c060e8c05
Anndrey24
Anndrey24
reviewed
Jun 14, 2024
View reviewed changes
@Anndrey24Anndrey24
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @eirenevp ! It's great to finally have an arm_cpu-specific dense schedule which we could possibly extend to also generate SVE instructions in the future.

I've just left a few comments based on my experience with the conv2d schedule.
Comment threadcmake/config.cmake
Comment threadpython/tvm/relay/op/strategy/arm_cpu.py
Comment threadpython/tvm/relay/op/strategy/arm_cpu.py
Comment threadpython/tvm/topi/arm_cpu/dense_alter_op.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Eirini Vlassi Pandi
added 11 commits
June 17, 2024 17:17
Eirini Vlassi Pandi
[TOPI] Update dense shedule files
17bfe7c
Change-Id: I11126864bdcfec1c88dbc39bafa18c8b78bbe5fc
Eirini Vlassi Pandi
[lint] Disable invalid names
0362f62
Change-Id: Ibbcfa2a94d14c9013e231c95725b0f651ae4ff46
Eirini Vlassi Pandi
[TOPI] Change tol depending on dtpye for test dense
9eda309
Change-Id: Iaefc79b7c415d4cdca2917b5c5fa5842eba2f71d
Eirini Vlassi Pandi
[TOPI] Run dense gemm test only on aarch64
eefb274
Change-Id: Ia6468fe6cf113781819c871e1f110bf4e98a3d59
Eirini Vlassi Pandi
[lint] Lint test dense file
c6ca352
Change-Id: I3e5c532ed041c691237bf04fda4645bf25befbcc
Eirini Vlassi Pandi
[TOPI] Update dense_alter_op to work with relay.traspose
a60717b
Change-Id: I1217eaec3b63eccfa32bcbf3b410f09fa0997f36
Eirini Vlassi Pandi
[TOPI] Update test_select_implementation
0f8aa94
Change-Id: Iccd59c8afdd70a98da031ff2d0cf8f5d3378a700
Eirini Vlassi Pandi
[TOPI] Fix test_select_implementationfor dense_gemm.arm_cpu
078988d
Change-Id: I8851b227a9dacf90046e4d3d1b0418355145e79a
Eirini Vlassi Pandi
[TOPI] Remove topi test for arm cpu dense
0822244
Change-Id: Ib50606a829142202142b326a111580f9eec72f8c
Eirini Vlassi Pandi
[TOPI] Run keras test with level 3 opt
f6d7a17
Change-Id: I44bf4bfbf85b5ab4fa91d653af25ae22f01ed79a
Eirini Vlassi Pandi
[TOPI] Disable test any dense for aarch64
6f5fb0f
Change-Id: Ie85f7d5c6d0e99fc389bd9b3f29787065e1e0cd0
Eirini Vlassi Pandi
[lint] tests/python/relay/test_any.py
e0b544a
Change-Id: I170e09358b61217586adc3591c020b065e2f5d3e
ekalda
ekalda
approved these changes
Jul 9, 2024
View reviewed changes
@ekaldaekalda
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the work on this @eirenevp!
@ekalda
ekalda
merged commit c4e6f96
into
apache:mainJul 9, 2024
@ysh329ysh329
mentioned this pull request
Jul 20, 2024

Closed

@kurisu6912kurisu6912
mentioned this pull request
Sep 5, 2025
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lhutton1lhutton1lhutton1 left review comments
@ekaldaekaldaekalda approved these changes

+1 more reviewer

@Anndrey24Anndrey24Anndrey24 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@eirenevp@ekalda@Anndrey24@lhutton1

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[TOPI] Add dense schedule for fp16 and fp32 using gemm - #17091
Merged
ekalda merged 15 commits into
apache:mainfrom 
eirenevp:gemm-dense
Jul 9, 2024
Merged
[TOPI] Add dense schedule for fp16 and fp32 using gemm#17091
ekalda merged 15 commits into
apache:mainfrom 
eirenevp:gemm-dense
Conversation
@eirenevp
@eirenevpeirenevp
commented
Jun 13, 2024

Copy link


Copy Markdown

Add a new schedule for the dense operator

based on the gemm algorithm.
Eirene Pandi
[TOPI] Add dense schedule for fp16 and fp32 using gemm
b2ac3ab
Add a new schedule for the dense operator
based on the gemm algorithm.
Change-Id: Iaf4423d21d20b5813c77a0a27c4751f8cbd1d8b8
@ekalda
ekalda
commented
Jun 13, 2024

Copy link


Copy Markdown

Contributor
cc @Anndrey24@lhutton1@leandron
Eirini Vlassi Pandi
added 2 commits
June 13, 2024 14:51
Eirini Vlassi Pandi
[TOPI] Restore topi x86 dense file
8c74c3c
Change-Id: I545a805f40197db01d91ce622a890754d4a3b901
Eirini Vlassi Pandi
[lint] Ignore unused args and disable mypy type checking
6eea7a6
Change-Id: Ica02890f132b67e3c9bd64f3fb98ee8c060e8c05
Anndrey24
Anndrey24
reviewed
Jun 14, 2024
View reviewed changes
@Anndrey24Anndrey24
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @eirenevp ! It's great to finally have an arm_cpu-specific dense schedule which we could possibly extend to also generate SVE instructions in the future.

I've just left a few comments based on my experience with the conv2d schedule.
Comment threadcmake/config.cmake
Comment threadpython/tvm/relay/op/strategy/arm_cpu.py
Comment threadpython/tvm/relay/op/strategy/arm_cpu.py
Comment threadpython/tvm/topi/arm_cpu/dense_alter_op.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Eirini Vlassi Pandi
added 11 commits
June 17, 2024 17:17
Eirini Vlassi Pandi
[TOPI] Update dense shedule files
17bfe7c
Change-Id: I11126864bdcfec1c88dbc39bafa18c8b78bbe5fc
Eirini Vlassi Pandi
[lint] Disable invalid names
0362f62
Change-Id: Ibbcfa2a94d14c9013e231c95725b0f651ae4ff46
Eirini Vlassi Pandi
[TOPI] Change tol depending on dtpye for test dense
9eda309
Change-Id: Iaefc79b7c415d4cdca2917b5c5fa5842eba2f71d
Eirini Vlassi Pandi
[TOPI] Run dense gemm test only on aarch64
eefb274
Change-Id: Ia6468fe6cf113781819c871e1f110bf4e98a3d59
Eirini Vlassi Pandi
[lint] Lint test dense file
c6ca352
Change-Id: I3e5c532ed041c691237bf04fda4645bf25befbcc
Eirini Vlassi Pandi
[TOPI] Update dense_alter_op to work with relay.traspose
a60717b
Change-Id: I1217eaec3b63eccfa32bcbf3b410f09fa0997f36
Eirini Vlassi Pandi
[TOPI] Update test_select_implementation
0f8aa94
Change-Id: Iccd59c8afdd70a98da031ff2d0cf8f5d3378a700
Eirini Vlassi Pandi
[TOPI] Fix test_select_implementationfor dense_gemm.arm_cpu
078988d
Change-Id: I8851b227a9dacf90046e4d3d1b0418355145e79a
Eirini Vlassi Pandi
[TOPI] Remove topi test for arm cpu dense
0822244
Change-Id: Ib50606a829142202142b326a111580f9eec72f8c
Eirini Vlassi Pandi
[TOPI] Run keras test with level 3 opt
f6d7a17
Change-Id: I44bf4bfbf85b5ab4fa91d653af25ae22f01ed79a
Eirini Vlassi Pandi
[TOPI] Disable test any dense for aarch64
6f5fb0f
Change-Id: Ie85f7d5c6d0e99fc389bd9b3f29787065e1e0cd0
Eirini Vlassi Pandi
[lint] tests/python/relay/test_any.py
e0b544a
Change-Id: I170e09358b61217586adc3591c020b065e2f5d3e
ekalda
ekalda
approved these changes
Jul 9, 2024
View reviewed changes
@ekaldaekalda
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the work on this @eirenevp!
@ekalda
ekalda
merged commit c4e6f96
into
apache:mainJul 9, 2024
@ysh329ysh329
mentioned this pull request
Jul 20, 2024

Closed

@kurisu6912kurisu6912
mentioned this pull request
Sep 5, 2025
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lhutton1lhutton1lhutton1 left review comments
@ekaldaekaldaekalda approved these changes

+1 more reviewer

@Anndrey24Anndrey24Anndrey24 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@eirenevp@ekalda@Anndrey24@lhutton1

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[TOPI] Add dense schedule for fp16 and fp32 using gemm - #17091
Merged
ekalda merged 15 commits into
apache:mainfrom 
eirenevp:gemm-dense
Jul 9, 2024
Merged
[TOPI] Add dense schedule for fp16 and fp32 using gemm#17091
ekalda merged 15 commits into
apache:mainfrom 
eirenevp:gemm-dense
Conversation
@eirenevp
@eirenevpeirenevp
commented
Jun 13, 2024

Copy link


Copy Markdown

Add a new schedule for the dense operator

based on the gemm algorithm.
Eirene Pandi
[TOPI] Add dense schedule for fp16 and fp32 using gemm
b2ac3ab
Add a new schedule for the dense operator
based on the gemm algorithm.
Change-Id: Iaf4423d21d20b5813c77a0a27c4751f8cbd1d8b8
@ekalda
ekalda
commented
Jun 13, 2024

Copy link


Copy Markdown

Contributor
cc @Anndrey24@lhutton1@leandron
Eirini Vlassi Pandi
added 2 commits
June 13, 2024 14:51
Eirini Vlassi Pandi
[TOPI] Restore topi x86 dense file
8c74c3c
Change-Id: I545a805f40197db01d91ce622a890754d4a3b901
Eirini Vlassi Pandi
[lint] Ignore unused args and disable mypy type checking
6eea7a6
Change-Id: Ica02890f132b67e3c9bd64f3fb98ee8c060e8c05
Anndrey24
Anndrey24
reviewed
Jun 14, 2024
View reviewed changes
@Anndrey24Anndrey24
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @eirenevp ! It's great to finally have an arm_cpu-specific dense schedule which we could possibly extend to also generate SVE instructions in the future.

I've just left a few comments based on my experience with the conv2d schedule.
Comment threadcmake/config.cmake
Comment threadpython/tvm/relay/op/strategy/arm_cpu.py
Comment threadpython/tvm/relay/op/strategy/arm_cpu.py
Comment threadpython/tvm/topi/arm_cpu/dense_alter_op.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Eirini Vlassi Pandi
added 11 commits
June 17, 2024 17:17
Eirini Vlassi Pandi
[TOPI] Update dense shedule files
17bfe7c
Change-Id: I11126864bdcfec1c88dbc39bafa18c8b78bbe5fc
Eirini Vlassi Pandi
[lint] Disable invalid names
0362f62
Change-Id: Ibbcfa2a94d14c9013e231c95725b0f651ae4ff46
Eirini Vlassi Pandi
[TOPI] Change tol depending on dtpye for test dense
9eda309
Change-Id: Iaefc79b7c415d4cdca2917b5c5fa5842eba2f71d
Eirini Vlassi Pandi
[TOPI] Run dense gemm test only on aarch64
eefb274
Change-Id: Ia6468fe6cf113781819c871e1f110bf4e98a3d59
Eirini Vlassi Pandi
[lint] Lint test dense file
c6ca352
Change-Id: I3e5c532ed041c691237bf04fda4645bf25befbcc
Eirini Vlassi Pandi
[TOPI] Update dense_alter_op to work with relay.traspose
a60717b
Change-Id: I1217eaec3b63eccfa32bcbf3b410f09fa0997f36
Eirini Vlassi Pandi
[TOPI] Update test_select_implementation
0f8aa94
Change-Id: Iccd59c8afdd70a98da031ff2d0cf8f5d3378a700
Eirini Vlassi Pandi
[TOPI] Fix test_select_implementationfor dense_gemm.arm_cpu
078988d
Change-Id: I8851b227a9dacf90046e4d3d1b0418355145e79a
Eirini Vlassi Pandi
[TOPI] Remove topi test for arm cpu dense
0822244
Change-Id: Ib50606a829142202142b326a111580f9eec72f8c
Eirini Vlassi Pandi
[TOPI] Run keras test with level 3 opt
f6d7a17
Change-Id: I44bf4bfbf85b5ab4fa91d653af25ae22f01ed79a
Eirini Vlassi Pandi
[TOPI] Disable test any dense for aarch64
6f5fb0f
Change-Id: Ie85f7d5c6d0e99fc389bd9b3f29787065e1e0cd0
Eirini Vlassi Pandi
[lint] tests/python/relay/test_any.py
e0b544a
Change-Id: I170e09358b61217586adc3591c020b065e2f5d3e
ekalda
ekalda
approved these changes
Jul 9, 2024
View reviewed changes
@ekaldaekalda
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the work on this @eirenevp!
@ekalda
ekalda
merged commit c4e6f96
into
apache:mainJul 9, 2024
@ysh329ysh329
mentioned this pull request
Jul 20, 2024

Closed

@kurisu6912kurisu6912
mentioned this pull request
Sep 5, 2025
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lhutton1lhutton1lhutton1 left review comments
@ekaldaekaldaekalda approved these changes

+1 more reviewer

@Anndrey24Anndrey24Anndrey24 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@eirenevp@ekalda@Anndrey24@lhutton1

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[TOPI] Add dense schedule for fp16 and fp32 using gemm - #17091
Merged
ekalda merged 15 commits into
apache:mainfrom 
eirenevp:gemm-dense
Jul 9, 2024
Merged
[TOPI] Add dense schedule for fp16 and fp32 using gemm#17091
ekalda merged 15 commits into
apache:mainfrom 
eirenevp:gemm-dense
Conversation
@eirenevp
@eirenevpeirenevp
commented
Jun 13, 2024

Copy link


Copy Markdown

Add a new schedule for the dense operator

based on the gemm algorithm.
Eirene Pandi
[TOPI] Add dense schedule for fp16 and fp32 using gemm
b2ac3ab
Add a new schedule for the dense operator
based on the gemm algorithm.
Change-Id: Iaf4423d21d20b5813c77a0a27c4751f8cbd1d8b8
@ekalda
ekalda
commented
Jun 13, 2024

Copy link


Copy Markdown

Contributor
cc @Anndrey24@lhutton1@leandron
Eirini Vlassi Pandi
added 2 commits
June 13, 2024 14:51
Eirini Vlassi Pandi
[TOPI] Restore topi x86 dense file
8c74c3c
Change-Id: I545a805f40197db01d91ce622a890754d4a3b901
Eirini Vlassi Pandi
[lint] Ignore unused args and disable mypy type checking
6eea7a6
Change-Id: Ica02890f132b67e3c9bd64f3fb98ee8c060e8c05
Anndrey24
Anndrey24
reviewed
Jun 14, 2024
View reviewed changes
@Anndrey24Anndrey24
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @eirenevp ! It's great to finally have an arm_cpu-specific dense schedule which we could possibly extend to also generate SVE instructions in the future.

I've just left a few comments based on my experience with the conv2d schedule.
Comment threadcmake/config.cmake
Comment threadpython/tvm/relay/op/strategy/arm_cpu.py
Comment threadpython/tvm/relay/op/strategy/arm_cpu.py
Comment threadpython/tvm/topi/arm_cpu/dense_alter_op.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Eirini Vlassi Pandi
added 11 commits
June 17, 2024 17:17
Eirini Vlassi Pandi
[TOPI] Update dense shedule files
17bfe7c
Change-Id: I11126864bdcfec1c88dbc39bafa18c8b78bbe5fc
Eirini Vlassi Pandi
[lint] Disable invalid names
0362f62
Change-Id: Ibbcfa2a94d14c9013e231c95725b0f651ae4ff46
Eirini Vlassi Pandi
[TOPI] Change tol depending on dtpye for test dense
9eda309
Change-Id: Iaefc79b7c415d4cdca2917b5c5fa5842eba2f71d
Eirini Vlassi Pandi
[TOPI] Run dense gemm test only on aarch64
eefb274
Change-Id: Ia6468fe6cf113781819c871e1f110bf4e98a3d59
Eirini Vlassi Pandi
[lint] Lint test dense file
c6ca352
Change-Id: I3e5c532ed041c691237bf04fda4645bf25befbcc
Eirini Vlassi Pandi
[TOPI] Update dense_alter_op to work with relay.traspose
a60717b
Change-Id: I1217eaec3b63eccfa32bcbf3b410f09fa0997f36
Eirini Vlassi Pandi
[TOPI] Update test_select_implementation
0f8aa94
Change-Id: Iccd59c8afdd70a98da031ff2d0cf8f5d3378a700
Eirini Vlassi Pandi
[TOPI] Fix test_select_implementationfor dense_gemm.arm_cpu
078988d
Change-Id: I8851b227a9dacf90046e4d3d1b0418355145e79a
Eirini Vlassi Pandi
[TOPI] Remove topi test for arm cpu dense
0822244
Change-Id: Ib50606a829142202142b326a111580f9eec72f8c
Eirini Vlassi Pandi
[TOPI] Run keras test with level 3 opt
f6d7a17
Change-Id: I44bf4bfbf85b5ab4fa91d653af25ae22f01ed79a
Eirini Vlassi Pandi
[TOPI] Disable test any dense for aarch64
6f5fb0f
Change-Id: Ie85f7d5c6d0e99fc389bd9b3f29787065e1e0cd0
Eirini Vlassi Pandi
[lint] tests/python/relay/test_any.py
e0b544a
Change-Id: I170e09358b61217586adc3591c020b065e2f5d3e
ekalda
ekalda
approved these changes
Jul 9, 2024
View reviewed changes
@ekaldaekalda
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the work on this @eirenevp!
@ekalda
ekalda
merged commit c4e6f96
into
apache:mainJul 9, 2024
@ysh329ysh329
mentioned this pull request
Jul 20, 2024

Closed

@kurisu6912kurisu6912
mentioned this pull request
Sep 5, 2025
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lhutton1lhutton1lhutton1 left review comments
@ekaldaekaldaekalda approved these changes

+1 more reviewer

@Anndrey24Anndrey24Anndrey24 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@eirenevp@ekalda@Anndrey24@lhutton1

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[TOPI] Add dense schedule for fp16 and fp32 using gemm - #17091
Merged
ekalda merged 15 commits into
apache:mainfrom 
eirenevp:gemm-dense
Jul 9, 2024
Merged
[TOPI] Add dense schedule for fp16 and fp32 using gemm#17091
ekalda merged 15 commits into
apache:mainfrom 
eirenevp:gemm-dense
Conversation
@eirenevp
@eirenevpeirenevp
commented
Jun 13, 2024

Copy link


Copy Markdown

Add a new schedule for the dense operator

based on the gemm algorithm.
Eirene Pandi
[TOPI] Add dense schedule for fp16 and fp32 using gemm
b2ac3ab
Add a new schedule for the dense operator
based on the gemm algorithm.
Change-Id: Iaf4423d21d20b5813c77a0a27c4751f8cbd1d8b8
@ekalda
ekalda
commented
Jun 13, 2024

Copy link


Copy Markdown

Contributor
cc @Anndrey24@lhutton1@leandron
Eirini Vlassi Pandi
added 2 commits
June 13, 2024 14:51
Eirini Vlassi Pandi
[TOPI] Restore topi x86 dense file
8c74c3c
Change-Id: I545a805f40197db01d91ce622a890754d4a3b901
Eirini Vlassi Pandi
[lint] Ignore unused args and disable mypy type checking
6eea7a6
Change-Id: Ica02890f132b67e3c9bd64f3fb98ee8c060e8c05
Anndrey24
Anndrey24
reviewed
Jun 14, 2024
View reviewed changes
@Anndrey24Anndrey24
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @eirenevp ! It's great to finally have an arm_cpu-specific dense schedule which we could possibly extend to also generate SVE instructions in the future.

I've just left a few comments based on my experience with the conv2d schedule.
Comment threadcmake/config.cmake
Comment threadpython/tvm/relay/op/strategy/arm_cpu.py
Comment threadpython/tvm/relay/op/strategy/arm_cpu.py
Comment threadpython/tvm/topi/arm_cpu/dense_alter_op.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Eirini Vlassi Pandi
added 11 commits
June 17, 2024 17:17
Eirini Vlassi Pandi
[TOPI] Update dense shedule files
17bfe7c
Change-Id: I11126864bdcfec1c88dbc39bafa18c8b78bbe5fc
Eirini Vlassi Pandi
[lint] Disable invalid names
0362f62
Change-Id: Ibbcfa2a94d14c9013e231c95725b0f651ae4ff46
Eirini Vlassi Pandi
[TOPI] Change tol depending on dtpye for test dense
9eda309
Change-Id: Iaefc79b7c415d4cdca2917b5c5fa5842eba2f71d
Eirini Vlassi Pandi
[TOPI] Run dense gemm test only on aarch64
eefb274
Change-Id: Ia6468fe6cf113781819c871e1f110bf4e98a3d59
Eirini Vlassi Pandi
[lint] Lint test dense file
c6ca352
Change-Id: I3e5c532ed041c691237bf04fda4645bf25befbcc
Eirini Vlassi Pandi
[TOPI] Update dense_alter_op to work with relay.traspose
a60717b
Change-Id: I1217eaec3b63eccfa32bcbf3b410f09fa0997f36
Eirini Vlassi Pandi
[TOPI] Update test_select_implementation
0f8aa94
Change-Id: Iccd59c8afdd70a98da031ff2d0cf8f5d3378a700
Eirini Vlassi Pandi
[TOPI] Fix test_select_implementationfor dense_gemm.arm_cpu
078988d
Change-Id: I8851b227a9dacf90046e4d3d1b0418355145e79a
Eirini Vlassi Pandi
[TOPI] Remove topi test for arm cpu dense
0822244
Change-Id: Ib50606a829142202142b326a111580f9eec72f8c
Eirini Vlassi Pandi
[TOPI] Run keras test with level 3 opt
f6d7a17
Change-Id: I44bf4bfbf85b5ab4fa91d653af25ae22f01ed79a
Eirini Vlassi Pandi
[TOPI] Disable test any dense for aarch64
6f5fb0f
Change-Id: Ie85f7d5c6d0e99fc389bd9b3f29787065e1e0cd0
Eirini Vlassi Pandi
[lint] tests/python/relay/test_any.py
e0b544a
Change-Id: I170e09358b61217586adc3591c020b065e2f5d3e
ekalda
ekalda
approved these changes
Jul 9, 2024
View reviewed changes
@ekaldaekalda
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the work on this @eirenevp!
@ekalda
ekalda
merged commit c4e6f96
into
apache:mainJul 9, 2024
@ysh329ysh329
mentioned this pull request
Jul 20, 2024

Closed

@kurisu6912kurisu6912
mentioned this pull request
Sep 5, 2025
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lhutton1lhutton1lhutton1 left review comments
@ekaldaekaldaekalda approved these changes

+1 more reviewer

@Anndrey24Anndrey24Anndrey24 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@eirenevp@ekalda@Anndrey24@lhutton1

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[TOPI] Add dense schedule for fp16 and fp32 using gemm - #17091
Merged
ekalda merged 15 commits into
apache:mainfrom 
eirenevp:gemm-dense
Jul 9, 2024
Merged
[TOPI] Add dense schedule for fp16 and fp32 using gemm#17091
ekalda merged 15 commits into
apache:mainfrom 
eirenevp:gemm-dense
Conversation
@eirenevp
@eirenevpeirenevp
commented
Jun 13, 2024

Copy link


Copy Markdown

Add a new schedule for the dense operator

based on the gemm algorithm.
Eirene Pandi
[TOPI] Add dense schedule for fp16 and fp32 using gemm
b2ac3ab
Add a new schedule for the dense operator
based on the gemm algorithm.
Change-Id: Iaf4423d21d20b5813c77a0a27c4751f8cbd1d8b8
@ekalda
ekalda
commented
Jun 13, 2024

Copy link


Copy Markdown

Contributor
cc @Anndrey24@lhutton1@leandron
Eirini Vlassi Pandi
added 2 commits
June 13, 2024 14:51
Eirini Vlassi Pandi
[TOPI] Restore topi x86 dense file
8c74c3c
Change-Id: I545a805f40197db01d91ce622a890754d4a3b901
Eirini Vlassi Pandi
[lint] Ignore unused args and disable mypy type checking
6eea7a6
Change-Id: Ica02890f132b67e3c9bd64f3fb98ee8c060e8c05
Anndrey24
Anndrey24
reviewed
Jun 14, 2024
View reviewed changes
@Anndrey24Anndrey24
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @eirenevp ! It's great to finally have an arm_cpu-specific dense schedule which we could possibly extend to also generate SVE instructions in the future.

I've just left a few comments based on my experience with the conv2d schedule.
Comment threadcmake/config.cmake
Comment threadpython/tvm/relay/op/strategy/arm_cpu.py
Comment threadpython/tvm/relay/op/strategy/arm_cpu.py
Comment threadpython/tvm/topi/arm_cpu/dense_alter_op.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Eirini Vlassi Pandi
added 11 commits
June 17, 2024 17:17
Eirini Vlassi Pandi
[TOPI] Update dense shedule files
17bfe7c
Change-Id: I11126864bdcfec1c88dbc39bafa18c8b78bbe5fc
Eirini Vlassi Pandi
[lint] Disable invalid names
0362f62
Change-Id: Ibbcfa2a94d14c9013e231c95725b0f651ae4ff46
Eirini Vlassi Pandi
[TOPI] Change tol depending on dtpye for test dense
9eda309
Change-Id: Iaefc79b7c415d4cdca2917b5c5fa5842eba2f71d
Eirini Vlassi Pandi
[TOPI] Run dense gemm test only on aarch64
eefb274
Change-Id: Ia6468fe6cf113781819c871e1f110bf4e98a3d59
Eirini Vlassi Pandi
[lint] Lint test dense file
c6ca352
Change-Id: I3e5c532ed041c691237bf04fda4645bf25befbcc
Eirini Vlassi Pandi
[TOPI] Update dense_alter_op to work with relay.traspose
a60717b
Change-Id: I1217eaec3b63eccfa32bcbf3b410f09fa0997f36
Eirini Vlassi Pandi
[TOPI] Update test_select_implementation
0f8aa94
Change-Id: Iccd59c8afdd70a98da031ff2d0cf8f5d3378a700
Eirini Vlassi Pandi
[TOPI] Fix test_select_implementationfor dense_gemm.arm_cpu
078988d
Change-Id: I8851b227a9dacf90046e4d3d1b0418355145e79a
Eirini Vlassi Pandi
[TOPI] Remove topi test for arm cpu dense
0822244
Change-Id: Ib50606a829142202142b326a111580f9eec72f8c
Eirini Vlassi Pandi
[TOPI] Run keras test with level 3 opt
f6d7a17
Change-Id: I44bf4bfbf85b5ab4fa91d653af25ae22f01ed79a
Eirini Vlassi Pandi
[TOPI] Disable test any dense for aarch64
6f5fb0f
Change-Id: Ie85f7d5c6d0e99fc389bd9b3f29787065e1e0cd0
Eirini Vlassi Pandi
[lint] tests/python/relay/test_any.py
e0b544a
Change-Id: I170e09358b61217586adc3591c020b065e2f5d3e
ekalda
ekalda
approved these changes
Jul 9, 2024
View reviewed changes
@ekaldaekalda
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the work on this @eirenevp!
@ekalda
ekalda
merged commit c4e6f96
into
apache:mainJul 9, 2024
@ysh329ysh329
mentioned this pull request
Jul 20, 2024

Closed

@kurisu6912kurisu6912
mentioned this pull request
Sep 5, 2025
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lhutton1lhutton1lhutton1 left review comments
@ekaldaekaldaekalda approved these changes

+1 more reviewer

@Anndrey24Anndrey24Anndrey24 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@eirenevp@ekalda@Anndrey24@lhutton1

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[TOPI] Add dense schedule for fp16 and fp32 using gemm - #17091
Merged
ekalda merged 15 commits into
apache:mainfrom 
eirenevp:gemm-dense
Jul 9, 2024
Merged
[TOPI] Add dense schedule for fp16 and fp32 using gemm#17091
ekalda merged 15 commits into
apache:mainfrom 
eirenevp:gemm-dense
Conversation
@eirenevp
@eirenevpeirenevp
commented
Jun 13, 2024

Copy link


Copy Markdown

Add a new schedule for the dense operator

based on the gemm algorithm.
Eirene Pandi
[TOPI] Add dense schedule for fp16 and fp32 using gemm
b2ac3ab
Add a new schedule for the dense operator
based on the gemm algorithm.
Change-Id: Iaf4423d21d20b5813c77a0a27c4751f8cbd1d8b8
@ekalda
ekalda
commented
Jun 13, 2024

Copy link


Copy Markdown

Contributor
cc @Anndrey24@lhutton1@leandron
Eirini Vlassi Pandi
added 2 commits
June 13, 2024 14:51
Eirini Vlassi Pandi
[TOPI] Restore topi x86 dense file
8c74c3c
Change-Id: I545a805f40197db01d91ce622a890754d4a3b901
Eirini Vlassi Pandi
[lint] Ignore unused args and disable mypy type checking
6eea7a6
Change-Id: Ica02890f132b67e3c9bd64f3fb98ee8c060e8c05
Anndrey24
Anndrey24
reviewed
Jun 14, 2024
View reviewed changes
@Anndrey24Anndrey24
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes, @eirenevp ! It's great to finally have an arm_cpu-specific dense schedule which we could possibly extend to also generate SVE instructions in the future.

I've just left a few comments based on my experience with the conv2d schedule.
Comment threadcmake/config.cmake
Comment threadpython/tvm/relay/op/strategy/arm_cpu.py
Comment threadpython/tvm/relay/op/strategy/arm_cpu.py
Comment threadpython/tvm/topi/arm_cpu/dense_alter_op.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadtests/python/relay/test_dense.py
Outdated

Comment threadpython/tvm/topi/arm_cpu/dense_gemm.py
Outdated

Eirini Vlassi Pandi
added 11 commits
June 17, 2024 17:17
Eirini Vlassi Pandi
[TOPI] Update dense shedule files
17bfe7c
Change-Id: I11126864bdcfec1c88dbc39bafa18c8b78bbe5fc
Eirini Vlassi Pandi
[lint] Disable invalid names
0362f62
Change-Id: Ibbcfa2a94d14c9013e231c95725b0f651ae4ff46
Eirini Vlassi Pandi
[TOPI] Change tol depending on dtpye for test dense
9eda309
Change-Id: Iaefc79b7c415d4cdca2917b5c5fa5842eba2f71d
Eirini Vlassi Pandi
[TOPI] Run dense gemm test only on aarch64
eefb274
Change-Id: Ia6468fe6cf113781819c871e1f110bf4e98a3d59
Eirini Vlassi Pandi
[lint] Lint test dense file
c6ca352
Change-Id: I3e5c532ed041c691237bf04fda4645bf25befbcc
Eirini Vlassi Pandi
[TOPI] Update dense_alter_op to work with relay.traspose
a60717b
Change-Id: I1217eaec3b63eccfa32bcbf3b410f09fa0997f36
Eirini Vlassi Pandi
[TOPI] Update test_select_implementation
0f8aa94
Change-Id: Iccd59c8afdd70a98da031ff2d0cf8f5d3378a700
Eirini Vlassi Pandi
[TOPI] Fix test_select_implementationfor dense_gemm.arm_cpu
078988d
Change-Id: I8851b227a9dacf90046e4d3d1b0418355145e79a
Eirini Vlassi Pandi
[TOPI] Remove topi test for arm cpu dense
0822244
Change-Id: Ib50606a829142202142b326a111580f9eec72f8c
Eirini Vlassi Pandi
[TOPI] Run keras test with level 3 opt
f6d7a17
Change-Id: I44bf4bfbf85b5ab4fa91d653af25ae22f01ed79a
Eirini Vlassi Pandi
[TOPI] Disable test any dense for aarch64
6f5fb0f
Change-Id: Ie85f7d5c6d0e99fc389bd9b3f29787065e1e0cd0
Eirini Vlassi Pandi
[lint] tests/python/relay/test_any.py
e0b544a
Change-Id: I170e09358b61217586adc3591c020b065e2f5d3e
ekalda
ekalda
approved these changes
Jul 9, 2024
View reviewed changes
@ekaldaekalda
left a comment


Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for all the work on this @eirenevp!
@ekalda
ekalda
merged commit c4e6f96
into
apache:mainJul 9, 2024
@ysh329ysh329
mentioned this pull request
Jul 20, 2024

Closed

@kurisu6912kurisu6912
mentioned this pull request
Sep 5, 2025
 Closed

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@lhutton1lhutton1lhutton1 left review comments
@ekaldaekaldaekalda approved these changes

+1 more reviewer

@Anndrey24Anndrey24Anndrey24 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@eirenevp@ekalda@Anndrey24@lhutton1