Skip to content

[FRONTEND][TENSPRFLOW] Add split support - #2001

Closed
nishi-t wants to merge 3 commits into
apache:masterfrom
nishi-t:tf_split
Closed

[FRONTEND][TENSPRFLOW] Add split support#2001
nishi-t wants to merge 3 commits into
apache:masterfrom
nishi-t:tf_split

Conversation

@nishi-t

@nishi-tnishi-t commented Oct 26, 2018

Copy link
Copy Markdown
Contributor

This PR adds following operators support to tensorflow frontend:

  • Split
  • SplitV

srkreddy1238
srkreddy1238 requested changes Oct 26, 2018
View reviewed changes
Comment threadnnvm/tests/python/frontend/tensorflow/test_forward.py Outdated

# Relational ops
test_forward_rel_ops()

@srkreddy1238srkreddy1238Oct 26, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest to move under transforms.

Comment threadnnvm/tests/python/frontend/tensorflow/test_forward.py Outdated
_test_forward_rel_op([t1, t2], math_ops.equal)
_test_forward_rel_op([t1, t2], math_ops.not_equal)

#######################################################################

@srkreddy1238srkreddy1238Oct 26, 2018

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls add another test case with Split+Concat.

ghost
ghost reviewed Oct 26, 2018
View reviewed changes
Comment threadnnvm/tests/python/frontend/tensorflow/test_forward.py Outdated
test_forward_reduce()
test_forward_mean()
#test_forward_reduce()
#test_forward_mean()

@ghostghostOct 26, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason for commenting them?

@ghostghostOct 26, 2018

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw changes in your fix.

@tqchentqchen added the status: need update need update based on feedbacks label Oct 27, 2018
@nishi-t
nishi-tforce-pushed the tf_split branch 3 times, most recently from 93ab1c2 to 3ef3ec0CompareOctober 29, 2018 04:28
@nishi-tnishi-t mentioned this pull request Oct 29, 2018
Merged
srkreddy1238
srkreddy1238 approved these changes Oct 29, 2018
View reviewed changes

@srkreddy1238srkreddy1238 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nishi-t. LGTM.

srkreddy1238
srkreddy1238 requested changes Oct 29, 2018
View reviewed changes

@srkreddy1238srkreddy1238 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nishi-t
#1572
You can take ref from this about how to handle split output.

@nishi-t

nishi-t commented Oct 29, 2018

Copy link
Copy Markdown
ContributorAuthor

Thank you for your review and approve, but the test case that concat after split currently is not passed. For now, I'll comment out this test case.

@nishi-t

nishi-t commented Oct 29, 2018•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@srkreddy1238 Thaks for the information. I'll check it out and work on the problem of handling split outputs.

@alexeyralexeyr mentioned this pull request Nov 16, 2018
Merged
@alexeyr

alexeyr commented Nov 16, 2018

Copy link
Copy Markdown
Contributor

I think my pull request #2105 got SplitV correct. For your case it should be tuple(np.cumsum(indices)[:-1]).

@nishi-t

nishi-t commented Nov 16, 2018

Copy link
Copy Markdown
ContributorAuthor

Sorry, I couldn't work for this PR recently. I'll close my PR.
@alexeyr Thank you for submitting PR to support Split.

@nishi-tnishi-t closed this Nov 16, 2018
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@srkreddy1238srkreddy1238srkreddy1238 requested changes
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: need updateneed update based on feedbacks

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nishi-t@alexeyr@srkreddy1238@tqchen