Skip to content

[FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. - #2757

Merged
srkreddy1238 merged 4 commits into
apache:masterfrom
srkreddy1238:tf-rebase
Mar 19, 2019
Merged

[FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM.#2757
srkreddy1238 merged 4 commits into
apache:masterfrom
srkreddy1238:tf-rebase

Conversation

@srkreddy1238

@srkreddy1238srkreddy1238 commented Mar 9, 2019•
edited
Loading

Copy link
Copy Markdown
Contributor

commit 76188a4
Author: Siva sivar.b@huawei.com
[NNVM][TENSORFLOW] bugfix. (#2444)

commit 6737739
Author: Ashutosh Parkhi ashutosh.parkhi@imgtec.com
[Tensorflow] Support for Crop (#2285)

commit f6c3f99
Author: Alexey Romanov alexey.v.romanov@gmail.com
[FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (#2242)

commit e5d92e1
Author: Dominic Symes 36929632+dominicsymes@users.noreply.github.com
[FRONTEND][TENSORFLOW] Bugfix (#2326)

commit 00d509d
Author: Alexey Romanov alexey.v.romanov@gmail.com
[FRONTEND][TENSORFLOW] Support Unstack and Split (#2105)

commit df9d3ad
Author: Siva sivar.b@huawei.com
[FRONTEND][TENSORFLOW] Bugfix (#2267)

commit d1a0c90
Author: Zhebin Jin zhebin.jzb@alibaba-inc.com
[FRONTEND][TENSORFLOW]Add Split and realdiv op support (#2123)
* Add Split and realdiv op support
* Fix the pad calculation in the case of dilated convolution

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.

@tqchen

tqchen commented Mar 9, 2019

Copy link
Copy Markdown
Member

@kazum@Huyuwei please review this PR

@srkreddy1238

srkreddy1238 commented Mar 10, 2019

Copy link
Copy Markdown
ContributorAuthor

Also @yongwww & @ashutoshparkhi welcome to review

@srkreddy1238
[FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM.
686da01
commit 76188a4
Author: Siva sivar.b@huawei.com
[NNVM][TENSORFLOW] bugfix. (apache#2444)
commit 6737739
Author: Ashutosh Parkhi ashutosh.parkhi@imgtec.com
[Tensorflow] Support for Crop (apache#2285)
commit f6c3f99
Author: Alexey Romanov alexey.v.romanov@gmail.com
[FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242)
commit e5d92e1
Author: Dominic Symes 36929632+dominicsymes@users.noreply.github.com
[FRONTEND][TENSORFLOW] Bugfix (apache#2326)
commit 00d509d
Author: Alexey Romanov alexey.v.romanov@gmail.com
[FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105)
commit df9d3ad
Author: Siva sivar.b@huawei.com
[FRONTEND][TENSORFLOW] Bugfix (apache#2267)
commit d1a0c90
Author: Zhebin Jin zhebin.jzb@alibaba-inc.com
[FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123)
* Add Split and realdiv op support
* Fix the pad calculation in the case of dilated convolution
kazum
kazum reviewed Mar 12, 2019
View reviewed changes
Comment threadnnvm/tests/python/frontend/tensorflow/test_forward.py Outdated
Comment threadpython/tvm/relay/frontend/tensorflow.py Outdated
kazum
kazum requested changes Mar 12, 2019
View reviewed changes
Comment threadnnvm/tests/python/frontend/tensorflow/test_forward.py
Comment threadpython/tvm/relay/frontend/tensorflow.py Outdated
Comment threadpython/tvm/relay/frontend/tensorflow.py Outdated
kazum
kazum approved these changes Mar 12, 2019
View reviewed changes

@kazumkazum left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

yongwww
yongwww requested changes Mar 12, 2019
View reviewed changes
Comment threadpython/tvm/relay/frontend/tensorflow.py
elif shape and node.name in shape:
# Give priority to user argument.
self._output_shapes[node.name] = [shape[node.name]]
elif node.op == 'Placeholder':

@yongwwwyongwwwMar 12, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually the change here was merged with pr #2493. It is okay to ignore the following three commits since #2493 was merged.

commit f347b52
Author: Yong Wu yongwu@amazon.com
Get tags of saved model automatically
commit 916576c
Author: Zhi Chen chzhi@amazon.com
Support TensorFlow saved model
TF parser: return the consistent error message to error handler
commit f1782f3
Author: Yong Wu yongwu@amazon.com
Add tf parser wrapper, infer shape automatically

@srkreddy1238srkreddy1238Mar 12, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. Removed now.

@tqchen

tqchen commented Mar 14, 2019

Copy link
Copy Markdown
Member

@srkreddy1238 please send another push to re-trigger CI. @yongwww please https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly

yongwww
yongwww approved these changes Mar 15, 2019
View reviewed changes

@yongwwwyongwww left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work!

@srkreddy1238
srkreddy1238 merged commit bb3c815 into apache:masterMar 19, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request Mar 20, 2019
@srkreddy1238Wei Chen
[FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. (apa…
d8d2538
…che#2757)
* [FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM.
commit 76188a4
Author: Siva sivar.b@huawei.com
[NNVM][TENSORFLOW] bugfix. (apache#2444)
commit 6737739
Author: Ashutosh Parkhi ashutosh.parkhi@imgtec.com
[Tensorflow] Support for Crop (apache#2285)
commit f6c3f99
Author: Alexey Romanov alexey.v.romanov@gmail.com
[FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242)
commit e5d92e1
Author: Dominic Symes 36929632+dominicsymes@users.noreply.github.com
[FRONTEND][TENSORFLOW] Bugfix (apache#2326)
commit 00d509d
Author: Alexey Romanov alexey.v.romanov@gmail.com
[FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105)
commit df9d3ad
Author: Siva sivar.b@huawei.com
[FRONTEND][TENSORFLOW] Bugfix (apache#2267)
commit d1a0c90
Author: Zhebin Jin zhebin.jzb@alibaba-inc.com
[FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123)
* Add Split and realdiv op support
* Fix the pad calculation in the case of dilated convolution
* * review comments
* * resnet fix.
* * review comments
ghost
ghost reviewed Mar 20, 2019
View reviewed changes
Comment threadpython/tvm/relay/frontend/tensorflow.py
# This means the node is 1d in Relay and 0d in TF.
# See `_expand_dims_0d_aware`.
if self._outputs_are_0d[node_name][tensor_slot] and input_shape:
input_0d_mismatch.add(in_sym)

@ghostghostMar 20, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be in_sym[tensor_slot]?

@srkreddy1238srkreddy1238Mar 20, 2019

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think tensor_slot us already handled above.

@ghostghostMar 20, 2019

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my variant of inception_v3, in_sym comes as a list of Var instead of _expr.TupleWrapper.

@yongwwwyongwwwMar 21, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ashutoshparkhi will fix it in pr #2830

wweic pushed a commit to neo-ai/tvm that referenced this pull request Mar 20, 2019
@srkreddy1238Wei Chen
[FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM. (apa…
ec7acb9
…che#2757)
* [FRONTEND][TENSORFLOW] Enhance with left over patches from NNVM.
commit 76188a4
Author: Siva sivar.b@huawei.com
[NNVM][TENSORFLOW] bugfix. (apache#2444)
commit 6737739
Author: Ashutosh Parkhi ashutosh.parkhi@imgtec.com
[Tensorflow] Support for Crop (apache#2285)
commit f6c3f99
Author: Alexey Romanov alexey.v.romanov@gmail.com
[FRONTEND][TENSORFLOW] Use input shapes directly instead of 1-element lists (apache#2242)
commit e5d92e1
Author: Dominic Symes 36929632+dominicsymes@users.noreply.github.com
[FRONTEND][TENSORFLOW] Bugfix (apache#2326)
commit 00d509d
Author: Alexey Romanov alexey.v.romanov@gmail.com
[FRONTEND][TENSORFLOW] Support Unstack and Split (apache#2105)
commit df9d3ad
Author: Siva sivar.b@huawei.com
[FRONTEND][TENSORFLOW] Bugfix (apache#2267)
commit d1a0c90
Author: Zhebin Jin zhebin.jzb@alibaba-inc.com
[FRONTEND][TENSORFLOW]Add Split and realdiv op support (apache#2123)
* Add Split and realdiv op support
* Fix the pad calculation in the case of dilated convolution
* * review comments
* * resnet fix.
* * review comments
@tqchentqchen mentioned this pull request Nov 8, 2019
Closed
@srkreddy1238
srkreddy1238 deleted the tf-rebase branch January 24, 2020 04:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yongwwwyongwwwyongwww approved these changes
@kazumkazumkazum approved these changes
+1 more reviewer
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: need review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@srkreddy1238@tqchen@kazum@yongwww