Uh oh!
There was an error while loading. Please reload this page.
[Relay][TensorFlow] Remove 'input_0d_mismatch' special handling - #3087
Merged
Conversation
alexeyr
commented
Apr 24, 2019
Contributor
I won't be able to review before going on vacation, though it's good if Relay doesn't need it anymore. Maybe add some tests directly for |
lixiaoquan
commented
Apr 25, 2019
ContributorAuthor
Test is added |
yongwww
reviewed
Apr 25, 2019
| _test_forward_expand_dims(np.int32(1), 0) | ||
| _test_forward_expand_dims(np.array([1]), 0) | ||
| _test_forward_expand_dims(np.array([[1], [2]]), 0) | ||
| _test_forward_expand_dims(np.array([[1], [2]]), 1) |
Member
There was a problem hiding this comment.
not sure if "axis = -1" is supported here
srkreddy1238
requested changes
Apr 26, 2019
Uh oh!
There was an error while loading. Please reload this page.
yzhliu
commented
Apr 26, 2019
Member
wweic pushed a commit
to wweic/tvm
that referenced
this pull request
May 13, 2019
…he#3087) * [Relay][TensorFlow] Remove 'input_0d_mismatch' special handling * Add more tests. * Cover the case that strided_slice outputs a scalar
wweic pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 13, 2019
…he#3087) * [Relay][TensorFlow] Remove 'input_0d_mismatch' special handling * Add more tests. * Cover the case that strided_slice outputs a scalar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@srkreddy1238@alexeyr Please review