Skip to content

[Relay][Frontend][ONNX] Fix reshape precompute, and type error - #3230

Merged
tqchen merged 9 commits into
apache:masterfrom
jroesch:onnx-shape-of
Jun 17, 2019
Merged

[Relay][Frontend][ONNX] Fix reshape precompute, and type error#3230
tqchen merged 9 commits into
apache:masterfrom
jroesch:onnx-shape-of

Conversation

@jroesch

@jroeschjroesch commented May 23, 2019

Copy link
Copy Markdown
Member

Fix the code which precomputes shapes, and repair type error by casting literal integers to int32.

@jroesch

jroesch commented May 23, 2019

Copy link
Copy Markdown
MemberAuthor

cc @tqchen@zhreshold

@jroesch
jroesch requested review from tqchen and zhresholdMay 23, 2019 01:36
@tqchen

tqchen commented May 23, 2019

Copy link
Copy Markdown
Member

Please fix the lint error

@tqchen

tqchen commented May 24, 2019

Copy link
Copy Markdown
Member

@jroesch can you look into the CI error?

@jroesch

jroesch commented May 28, 2019

Copy link
Copy Markdown
MemberAuthor

I disabled a few tests that require debugging version issues on CI. I propose we merge this, and I'll do a follow up pass afterwards.

See my recent issue #3247.

@zhreshold

zhreshold commented May 28, 2019

Copy link
Copy Markdown
Member

The CI dependency version issue is really a headache now.

@jroesch

jroesch commented May 30, 2019

Copy link
Copy Markdown
MemberAuthor

Yeah this is annoying, @zhreshold@tqchen can we bump the ONNX version?

@tqchen

tqchen commented May 30, 2019•
edited
Loading

Copy link
Copy Markdown
Member

Ideally, we should make the code compatible with both versions. Please try to do that and let us merge it in. Please send a PR to https://github.com/dmlc/tvm/blob/master/docker/install/ubuntu_install_onnx.sh#L24 to ping the onnx to a specific version. then we can try to upgrade the image

@jroesch

jroesch commented Jun 4, 2019

Copy link
Copy Markdown
MemberAuthor

Ideally, we should make the code compatible with both versions. Please try to do that and let us merge it in. Please send a PR to https://github.com/dmlc/tvm/blob/master/docker/install/ubuntu_install_onnx.sh#L24 to ping the onnx to a specific version. then we can try to upgrade the image

The problem is that the operator support in ONNX and in the torch export functionality varies across versions, so tests have to be conditionally enabled if we want to test model support. I believe it is important we test the entire pipeline on our CI because these models seem to have a lot of failures on the discuss board lately.

@tqchen

tqchen commented Jun 14, 2019

Copy link
Copy Markdown
Member

#3374 updates the docker image to the latest state

tmoreau89
tmoreau89 approved these changes Jun 17, 2019
View reviewed changes
Comment threadtests/python/frontend/onnx/test_forward.py
check_torch_conversion(torchvision.models.resnet18, (1,3,224,224))
# check_torch_conversion(torchvision.models.resnet101, (1,3,224,224))

# def test_alexnet():

@tmoreau89tmoreau89Jun 17, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for these tests being commented out? Can we add a TODO if it's pending on some feature that isn't implemented yet?

@tqchen
tqchen merged commit df6957a into apache:masterJun 17, 2019
@tqchen

tqchen commented Jun 17, 2019

Copy link
Copy Markdown
Member

Thanks @jroesch@zhreshold this PR has been merged. I need to fix issues in #3374 and will report back when that is ready

tqchen added a commit that referenced this pull request Jun 17, 2019
@tqchen
Revert "[Relay][Frontend][ONNX] Fix reshape precompute, and type error (
d808b63
#3230)"
This reverts commit df6957a.
@tqchentqchen mentioned this pull request Jun 17, 2019
Merged
tqchen added a commit that referenced this pull request Jun 17, 2019
@tqchen
Revert "[Relay][Frontend][ONNX] Fix reshape precompute, and type error (
1119c40
#3230)" (#3385)
This reverts commit df6957a.
@tqchen

tqchen commented Jun 17, 2019

Copy link
Copy Markdown
Member

Note: I reverted this PR for now due to CI errors, please open a new PR to bring things back, sorry about the trouble.

@zhiics

zhiics commented Jun 17, 2019

Copy link
Copy Markdown
Member

The problem is because fusion was not performed here:
https://github.com/dmlc/tvm/pull/3230/files#diff-03149f7671cff8be6734838f7707a24dR417

@zhiicszhiics mentioned this pull request Jun 18, 2019
Merged
@tqchen

tqchen commented Jun 18, 2019

Copy link
Copy Markdown
Member

NOTE, now that #3374 has been merged, you should be able to use the latest env

wweic pushed a commit to wweic/tvm that referenced this pull request Jun 26, 2019
@jroeschWei Chen
[Relay][Frontend][ONNX] Fix reshape precompute, and type error (apach…
e852b5c
…e#3230)
wweic pushed a commit to wweic/tvm that referenced this pull request Jun 26, 2019
@tqchenWei Chen
Revert "[Relay][Frontend][ONNX] Fix reshape precompute, and type error (
28a3b75
apache#3230)" (apache#3385)
This reverts commit df6957a.
wweic pushed a commit to neo-ai/tvm that referenced this pull request Jun 27, 2019
@jroeschWei Chen
[Relay][Frontend][ONNX] Fix reshape precompute, and type error (apach…
c052d97
…e#3230)
wweic pushed a commit to neo-ai/tvm that referenced this pull request Jun 27, 2019
@tqchenWei Chen
Revert "[Relay][Frontend][ONNX] Fix reshape precompute, and type error (
ede42aa
apache#3230)" (apache#3385)
This reverts commit df6957a.
@yzhliuyzhliu mentioned this pull request Nov 11, 2019
Closed
@jroesch
jroesch deleted the onnx-shape-of branch February 4, 2021 04:40
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmoreau89tmoreau89tmoreau89 approved these changes
@tqchentqchenAwaiting requested review from tqchen
+1 more reviewer
@zhresholdzhresholdzhreshold approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jroesch@tqchen@zhreshold@zhiics@tmoreau89