Uh oh!
There was an error while loading. Please reload this page.
Add support for MXNet pad operator, for parameter 'None' in slice operator, 1D Convolution and 1D Deconvolution - #3739
Merged
Conversation
| struct PadAttrs : public tvm::AttrsNode<PadAttrs> { | ||
| double pad_value; | ||
| Array<Array<IndexExpr> > pad_width; | ||
| std::string pad_mode; |
Contributor
There was a problem hiding this comment.
Can we add test cases for different modes?
ContributorAuthor
There was a problem hiding this comment.
I've added tests, please review again
yongwww
commented
Aug 21, 2019
Member
@kevinthesun @icemelon9 @zhiics great to get feedback from any of you guys |
yongwww
requested changes
Aug 21, 2019
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
kevinthesun
commented
Aug 23, 2019
Contributor
@alexgl-github Can you resolve the conflict and take a look at the ci issue? |
alexgl-github
commented
Aug 27, 2019
ContributorAuthor
|
kevinthesun
commented
Sep 5, 2019
Contributor
@alexgl-github looks like sanity check is still failing. |
alexgl-githubforce-pushed
the
mxnet-pad2
branch
from
September 9, 2019 23:05
b01ae9c to
df63f20Comparealexgl-github
commented
Sep 11, 2019
ContributorAuthor
@kevinthesun please review again. |
alexgl-githubforce-pushed
the
mxnet-pad2
branch
from
September 13, 2019 20:10
d09e583 to
903ad7fComparealexgl-githubforce-pushed
the
mxnet-pad2
branch
5 times, most recently
from
September 13, 2019 22:09
eaad44b to
da0bc0eCompare
MXNet pad is described at: https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.pad Add support for parameter 'None' in MXNet slice operator. MXNet 'slice' is described at https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.slice Add support for MXNet cos, sin, arctan MXNet 'cos' is described at https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.cos MXNet 'sin' is described at https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.sin MXNet arctan is descirbed at https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.arctan Add support for MXNet 1D Convolution and 1D Deconvolution MXNet convolution is described at: https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.Convolution MXNet Deconvolution is described at: https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.Deconvolution
alexgl-githubforce-pushed
the
mxnet-pad2
branch
from
September 20, 2019 00:50
da0bc0e to
90e81fdComparekevinthesun
approved these changes
Sep 20, 2019
kevinthesun
commented
Sep 20, 2019
Contributor
Thanks! |
anijain2305 added a commit
to anijain2305/tvm
that referenced
this pull request
Sep 21, 2019
tqchen pushed a commit
that referenced
this pull request
Sep 23, 2019
wweic pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 30, 2019
MXNet pad is described at: https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.pad Add support for parameter 'None' in MXNet slice operator. MXNet 'slice' is described at https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.slice Add support for MXNet cos, sin, arctan MXNet 'cos' is described at https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.cos MXNet 'sin' is described at https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.sin MXNet arctan is descirbed at https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.arctan Add support for MXNet 1D Convolution and 1D Deconvolution MXNet convolution is described at: https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.Convolution MXNet Deconvolution is described at: https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.Deconvolution
wweic pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 30, 2019
wweic pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 30, 2019
MXNet pad is described at: https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.pad Add support for parameter 'None' in MXNet slice operator. MXNet 'slice' is described at https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.slice Add support for MXNet cos, sin, arctan MXNet 'cos' is described at https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.cos MXNet 'sin' is described at https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.sin MXNet arctan is descirbed at https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.arctan Add support for MXNet 1D Convolution and 1D Deconvolution MXNet convolution is described at: https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.Convolution MXNet Deconvolution is described at: https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.Deconvolution
wweic pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 30, 2019
wweic pushed a commit
to neo-ai/tvm
that referenced
this pull request
Oct 1, 2019
MXNet pad is described at: https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.pad Add support for parameter 'None' in MXNet slice operator. MXNet 'slice' is described at https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.slice Add support for MXNet cos, sin, arctan MXNet 'cos' is described at https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.cos MXNet 'sin' is described at https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.sin MXNet arctan is descirbed at https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.arctan Add support for MXNet 1D Convolution and 1D Deconvolution MXNet convolution is described at: https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.Convolution MXNet Deconvolution is described at: https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.Deconvolution
wweic pushed a commit
to neo-ai/tvm
that referenced
this pull request
Oct 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MXNet pad is described at:
https://mxnet.incubator.apache.org/api/python/symbol/symbol.html#mxnet.symbol.pad
Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers.