Uh oh!
There was an error while loading. Please reload this page.
[Legalize][QNN] Pass out_types to Legalize - #3782
Merged
Merged
Conversation
anijain2305
commented
Aug 16, 2019
ContributorAuthor
| @reg.register_legalize("nn.conv2d") | ||
| def legalize_conv2d(attrs, inputs, arg_dtypes): | ||
| def legalize_conv2d(attrs, inputs, types): | ||
| """Legalize conv2d""" |
Contributor
There was a problem hiding this comment.
can you also add the doc string here.
ContributorAuthor
There was a problem hiding this comment.
Good idea. Let me do it.
Contributor
There was a problem hiding this comment.
I understand that this method inherits params from def conv2d_legalize(attrs, inputs, types, F):. for convenience, we can add that the doc string comes from def conv2d_legalize(attrs, inputs, types, F)
yzhliu
approved these changes
Aug 17, 2019
yzhliu
commented
Aug 17, 2019
Member
we can merge once @shoubhik approves. |
shoubhik
approved these changes
Aug 17, 2019
shoubhik
commented
Aug 17, 2019
Contributor
LGTM, i have approved the change. |
zhiics
reviewed
Aug 17, 2019
| auto out_type = types[1]; | ||
| auto out_tensor_type = out_type.as<TensorTypeNode>(); | ||
| CHECK(out_tensor_type != nullptr) << "Type information missing." | ||
| << " Please run infer_type pass."; |
zhiics
reviewed
Aug 17, 2019
| The args of the Relay expr to be legalized. | ||
| types : list of types | ||
| List of input and output types | ||
| F: symbol |
anijain2305force-pushed
the
legalize
branch
3 times, most recently
from
August 17, 2019 20:01
506d83d to
f3c7491Comparetqchen
requested changes
Aug 19, 2019
| return topi.nn.conv2d_legalize(attrs, inputs, arg_dtypes, op) | ||
| def legalize_conv2d(attrs, inputs, types): | ||
| """Legalize conv2d op. | ||
| Parameters |
anijain2305
commented
Aug 21, 2019
ContributorAuthor
@tqchen Let me know if you have more comments. |
…read from out_types.
tqchen
approved these changes
Aug 23, 2019
yzhliu
commented
Aug 23, 2019
Member
Thanks @anijain2305@shoubhik@tqchen@zhiics ! |
wweic pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 16, 2019
…read from out_types. (apache#3782)
wweic pushed a commit
to wweic/tvm
that referenced
this pull request
Sep 16, 2019
…read from out_types. (apache#3782)
wweic pushed a commit
to neo-ai/tvm
that referenced
this pull request
Sep 16, 2019
…read from out_types. (apache#3782)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, updated QNN requantize to read from out_types.