Skip to content

Do type checking for the input and kernel in the qnn conv2d - #3904

Merged
zhiics merged 4 commits into
apache:masterfrom
anijain2305:qnn_conv2d
Sep 12, 2019
Merged

Do type checking for the input and kernel in the qnn conv2d#3904
zhiics merged 4 commits into
apache:masterfrom
anijain2305:qnn_conv2d

Conversation

@shoubhik

@shoubhikshoubhik commented Sep 5, 2019

Copy link
Copy Markdown
Contributor

The privous commit #3580 did not have the data type checks needed for qnn conv2d. Existing test cases are passing.

@shoubhik

shoubhik commented Sep 5, 2019

Copy link
Copy Markdown
ContributorAuthor

@anijain2305 can you verify the checks.

anijain2305
anijain2305 requested changes Sep 6, 2019
View reviewed changes

@anijain2305anijain2305 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shoubhik for boosting the type checking. Indeed I missed the checks.
Left few comments.

Tagging others for merge assignment - @zhiics@vinx13

Comment threadsrc/relay/qnn/op/convolution.cc Outdated
Comment threadsrc/relay/qnn/op/convolution.cc Outdated
Comment threadsrc/relay/qnn/op/convolution.cc Outdated
anijain2305
anijain2305 reviewed Sep 6, 2019
View reviewed changes
Comment threadsrc/relay/qnn/op/convolution.cc
@shoubhik

shoubhik commented Sep 6, 2019

Copy link
Copy Markdown
ContributorAuthor

@zhiics@vinx13 can you take a look at this PR.

zhiics
zhiics approved these changes Sep 9, 2019
View reviewed changes

@zhiicszhiics left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anijain2305

anijain2305 commented Sep 10, 2019

Copy link
Copy Markdown
Contributor

@vinx13 can this be merged?

@anijain2305

anijain2305 commented Sep 12, 2019

Copy link
Copy Markdown
Contributor

@zhiics can this be merged?

@zhiics
zhiics merged commit 880c260 into apache:masterSep 12, 2019
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 16, 2019
@shoubhikWei Chen
Do type checking for the input and kernel in the qnn conv2d (apache#3904
599ef84
)
* [QNN] Convolution 2D Implementation.
Rebasing. Empty commit.
Clang-format styling.
* Reformatting code.
* Fixing lint issues.
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 16, 2019
@shoubhikWei Chen
Do type checking for the input and kernel in the qnn conv2d (apache#3904
aec54ed
)
* [QNN] Convolution 2D Implementation.
Rebasing. Empty commit.
Clang-format styling.
* Reformatting code.
* Fixing lint issues.
wweic pushed a commit to neo-ai/tvm that referenced this pull request Sep 16, 2019
@shoubhikWei Chen
Do type checking for the input and kernel in the qnn conv2d (apache#3904
99235fd
)
* [QNN] Convolution 2D Implementation.
Rebasing. Empty commit.
Clang-format styling.
* Reformatting code.
* Fixing lint issues.
@tqchentqchen mentioned this pull request Nov 8, 2019
Closed
@anijain2305
anijain2305 deleted the qnn_conv2d branch November 13, 2019 00:30
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhiicszhiicszhiics approved these changes
@anijain2305anijain2305anijain2305 approved these changes
@kevinthesunkevinthesunkevinthesun approved these changes

Assignees

No one assigned

Labels

status: accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shoubhik@anijain2305@zhiics@kevinthesun