Skip to content

Qnn fully connected - #3910

Merged
zhiics merged 7 commits into
apache:masterfrom
anijain2305:qnn_fully_connected
Sep 22, 2019
Merged

Qnn fully connected#3910
zhiics merged 7 commits into
apache:masterfrom
anijain2305:qnn_fully_connected

Conversation

@shoubhik

@shoubhikshoubhik commented Sep 6, 2019

Copy link
Copy Markdown
Contributor

This is continuation of the Qnn dialect. After the convolution #3580 this the implementaion of Dense layer with quantized inputs. In future revisions we will add schdules for more optimal performance.

@shoubhik

shoubhik commented Sep 6, 2019•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@anijain2305@zhiics@vinx13 can you take a look at this PR.

anijain2305
anijain2305 reviewed Sep 6, 2019
View reviewed changes

@anijain2305anijain2305 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Some minor comments.

Comment threadsrc/relay/pass/pattern_util.h Outdated
Comment threadpython/tvm/relay/qnn/op/qnn.py
Comment threadsrc/relay/qnn/op/dense.cc
Comment threadsrc/relay/qnn/op/dense.cc Outdated
Comment threadsrc/relay/qnn/op/dense.cc Outdated
Comment threadsrc/relay/qnn/op/dense.cc Outdated
Comment threadsrc/relay/qnn/op/dense.cc Outdated
Comment threadsrc/relay/qnn/op/dense.cc
Comment threadtests/python/relay/test_qnn_dense.py Outdated
anijain2305
anijain2305 approved these changes Sep 6, 2019
View reviewed changes
Comment threadsrc/relay/qnn/op/convolution.cc
@shoubhik

shoubhik commented Sep 9, 2019

Copy link
Copy Markdown
ContributorAuthor

@zhiics@vinx13@jackwish can you take a look at this PR.

@anijain2305

anijain2305 commented Sep 12, 2019

Copy link
Copy Markdown
Contributor

@shoubhik Can you please fix the lint?

@zhiics@vinx13 Can you please review?

@shoubhik

shoubhik commented Sep 12, 2019

Copy link
Copy Markdown
ContributorAuthor

Fixed the test related issue.

zhiics
zhiics reviewed Sep 13, 2019
View reviewed changes

@zhiicszhiics left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just left a few nits.
@jackwish Could you take a look as well when you have cycles?

Also, plz fix the ci error.

Comment threadpython/tvm/relay/qnn/op/qnn.py
Comment threadpython/tvm/relay/qnn/op/qnn.py
@shoubhik

shoubhik commented Sep 20, 2019

Copy link
Copy Markdown
ContributorAuthor

@jackwish Could you take a look

zhenhuaw-me
zhenhuaw-me approved these changes Sep 21, 2019
View reviewed changes

@zhenhuaw-mezhenhuaw-me left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry that I have missed this :)

@shoubhik

shoubhik commented Sep 21, 2019

Copy link
Copy Markdown
ContributorAuthor

@zhiics can you merge this.

@zhiics
zhiics merged commit 43f54a5 into apache:masterSep 22, 2019
@zhiics

zhiics commented Sep 22, 2019

Copy link
Copy Markdown
Member

Thanks everyone. This is now merged.

wweic pushed a commit to wweic/tvm that referenced this pull request Sep 30, 2019
@shoubhikWei Chen
Qnn fully connected (apache#3910)
c2f47e7
* Qnn Dense layer.
* Reformatting code.
* Reformatting code and making the test case more readable.
* Fixing lint issues.
* Fixing test method names to pass the nose related configurations.
* Aligning the code for code style.
wweic pushed a commit to wweic/tvm that referenced this pull request Sep 30, 2019
@shoubhikWei Chen
Qnn fully connected (apache#3910)
9214cd8
* Qnn Dense layer.
* Reformatting code.
* Reformatting code and making the test case more readable.
* Fixing lint issues.
* Fixing test method names to pass the nose related configurations.
* Aligning the code for code style.
wweic pushed a commit to neo-ai/tvm that referenced this pull request Oct 1, 2019
@shoubhikWei Chen
Qnn fully connected (apache#3910)
aaf04ec
* Qnn Dense layer.
* Reformatting code.
* Reformatting code and making the test case more readable.
* Fixing lint issues.
* Fixing test method names to pass the nose related configurations.
* Aligning the code for code style.
@tqchentqchen mentioned this pull request Nov 8, 2019
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zhiicszhiicszhiics approved these changes
@anijain2305anijain2305anijain2305 approved these changes
+1 more reviewer
@zhenhuaw-mezhenhuaw-mezhenhuaw-me approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@zhiicszhiics

Labels

status: accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shoubhik@anijain2305@zhiics@zhenhuaw-me