Uh oh!
There was an error while loading. Please reload this page.
[QNN] Multiplication operator - #3927
Conversation
anijain2305
left a comment
There was a problem hiding this comment.
Thanks for the contribution! Please feel free to ping me for any QNN related PRs :)
I have a concern about the lowering.
| * \param arg_types The types of input and output. | ||
| * \return The sequence of Relay ops for mul op. | ||
| */ | ||
| Expr QnnMulCanonicalize(const Attrs& attrs, const Array<Expr>& new_args, |
There was a problem hiding this comment.
I think that there is a mistake in the lowering. Can you please provide description of how the lowering instructions are decided?
There was a problem hiding this comment.
I think that there is a mistake in the lowering. Can you please provide description of how the lowering instructions are decided?
Same as the addition operator - only difference is that the requantized tensors are multiplied to provide the output. Let me know which part of the instructions you see an issue with and I'll take a closer look - Thanks
tqchen
commented
Oct 10, 2019
@tristan-arm@anijain2305 please followup on this thread :) |
anijain2305
commented
Oct 16, 2019
@tristan-arm Sorry for the huge delay. This is what the lowering should look like. Let me know what do you think about this. |
tqchen
commented
Oct 24, 2019
ping @tristan-arm please follow up :) |
Implementation of the qnn multiplication operator following the same pattern as the addition operator.