[RFC][RUNTIME] Introduce new object protocol. by tqchen · Pull Request #4115 · apache/tvm

tqchen · 2019-10-13T05:22:36Z

This PR introduces a new object protocol to unify the node and object.
We also updated the existing runtime::vm code to make use of the new system.

Update to the node will be done in a follow-up PR.

Other changes:

Remove object-related code in json serializer as that code logic was not complete
and we have a separate serializer for VM, can revisit later.

Terminology

Object: the container class, like Node
ObjectPtr: the intrusive pointer
ObjectRef: the reference class

Improvement over Node and old Object System

Support both static and dynamic type_index(tag)
Optimize IsInstance check when class have final attribute
Make use of static type index range for sub-class checking if possible.

tqchen · 2019-10-13T05:29:09Z

cc @jroesch @icemelon9 @junrushao1994 @zhiics @jermainewang

This PR introduces a new object protocol to unify the node and object. We also updated the existing runtime::vm code to make use of the new system. Update to the node will be done in a follow up PR. Other changes: - Remove object related code in json serializer as that code logic was not complete and we have a separate serializer for VM, can revisit later.

tqchen · 2019-10-13T23:27:29Z

@junrushao1994 @icemelon9 @yzh119 can you help review this PR?

zhiics

Thanks for this protocol. It will greatly reduce developers's effort to add a new runtime object so that it can interoperate between python and c++.

So currently we have Object/ObjectRef and Node/NodeRef and we are gonna migrate Node system to Object since it's more generic, right?

zhiics · 2019-10-14T03:53:08Z

+ * the type index will be assigned during runtime.
+ * Runtime type index can be accessed by ObjectType::type_index();
+ * - _type_key:
+ * The unique string identifier of tyep type.


zhiics · 2019-10-14T03:56:12Z

+ * - Use TVM_DECLARE_FINAL_OBJECT_INFO for object classes that cannot be sub-classed.
+ *
+ * New objects can be created using make_object function.
+ * Which will automatically populate the type_index and deleterof the object.


s/deleterof/deleter of

zhiics · 2019-10-14T04:07:48Z


+ protected:
+ // The fields of the base object cell.
+ /*! \brief Type index(tag) that indicate the type of the object. */


s/indicate/indicates

zhiics · 2019-10-14T04:11:18Z

+ * When the function is first time called for a type,
+ * it will register the type to the type table in the runtime.
+ * If the static_tindex is TypeIndex::kDynamic, the function will
+ * will allocate a runtime type index.


zhiics · 2019-10-14T04:19:49Z

+class ObjectRef {
+ public:
+ /*! \brief default constructor */
+ ObjectRef() = default;


Suggested change
ObjectRef() =default;
ObjectRef() =default;

zhiics · 2019-10-14T04:23:54Z

- size_t tag;
- /*! \brief The fields of the structure. */
- std::vector<Object> fields;
+#define TVM_DEFINE_OBJECT_REF_METHODS(TypeName, ParentType, ObjectName) \


zhiics · 2019-10-14T04:48:48Z

+TVM_REGISTER_OBJECT_TYPE(ObjBase);
+TVM_REGISTER_OBJECT_TYPE(ObjA);
+TVM_REGISTER_OBJECT_TYPE(ObjB);
+TVM_REGISTER_OBJECT_TYPE(ObjAA);


TVM_DECLARE_FINAL_OBJECT_INFO? just to have a test for final object as well.

tqchen · 2019-10-14T16:06:23Z

Yes, the goal is to migrate noderef/node to be subclass of object/objectref. The migration needs to take a few steps to complete

tqchen · 2019-10-15T04:05:57Z

ping @zhiics for another round of review

zhiics

LGTM

zhiics · 2019-10-15T05:46:43Z

@tqchen thanks. This is now merged.

* [RUNTIME] Introduce new object protocol. This PR introduces a new object protocol to unify the node and object. We also updated the existing runtime::vm code to make use of the new system. Update to the node will be done in a follow up PR. Other changes: - Remove object related code in json serializer as that code logic was not complete and we have a separate serializer for VM, can revisit later. * address review comment * Fix the child slot logic

* master: (51 commits) [QNN][TFLite] Parsing QNN Add op. Adding MobilenetV2. (apache#4142) [CI] Pin NNPack pthreadtools version (apache#4152) Fix typo (apache#4144) [Relay][Frontend][TF] Add tensor array ops (apache#3798) [relay][vm] Separate VM runtime with executable (apache#4100) [PATCH] Fix undefined __floatdihf in libtvmruntime.so on aarch64. (apache#4119) [DOCKER] Pin torchvision==0.4.1 (apache#4140) [TOPI][x86] Cascade lake support. (apache#4123) [Relay] Improve build error when no lowered funcs are produced (apache#4132) [RUNTIME] Refactor object python FFI to new protocol. (apache#4128) Update PULL_REQUEST_TEMPLATE.md Adding support for dequantizing from int32 to float32. (apache#4130) [Relay][Training] Add and fix gradients (apache#4126) [QNN] Change default rouning to UPWARD. (apache#4131) Fix infer type of kernel in dense. (apache#4125) [Relay][AlterOpLayout] NHWC to NCHWc pad operator. (apache#4103) [ARITH] Fix lowering of floormod(x, y) != 0 (apache#4127) [RFC][RUNTIME] Introduce new object protocol. (apache#4115) [Relay][Topi] Disable conv NHWC pack int8. (apache#4038) Update task_cpp_unittest.sh ...

tqchen mentioned this pull request Oct 13, 2019
[RFC] Unifying Object Protocol in the Stack #4116
Closed
3 tasks

tqchen force-pushed the object branch from d7504d3 to 8c48f2bCompare October 13, 2019 05:28

tqchen force-pushed the object branch 3 times, most recently from 80d9573 to f8f6f50Compare October 13, 2019 19:15

tqchen added the status: need review label Oct 13, 2019

tqchen force-pushed the object branch from f8f6f50 to 00dcdeeCompare October 13, 2019 23:28

tqchen mentioned this pull request Oct 14, 2019
[relay][vm] Separate VM runtime with executable #4100
Merged

zhiics reviewed Oct 14, 2019
View reviewed changes

tqchen added 2 commits October 14, 2019 10:32

address review comment
425c24e

Fix the child slot logic
6ad34ce

tqchen force-pushed the object branch from ca327e7 to 6ad34ceCompare October 14, 2019 21:03

zhiics approved these changes Oct 15, 2019
View reviewed changes

zhiics merged commit a0bd378 into apache:masterOct 15, 2019

zhiics added status: accepted and removed status: need review labels Oct 15, 2019

tqchen mentioned this pull request Nov 8, 2019
[RELEASE][DRAFT] TVM v0.6 Release candidate #4259
Closed

Uh oh!

Conversation

tqchen commented Oct 13, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Terminology

Improvement over Node and old Object System

Uh oh!

tqchen commented Oct 13, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tqchen commented Oct 13, 2019

Uh oh!

zhiics left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tqchen commented Oct 14, 2019

Uh oh!

tqchen commented Oct 15, 2019

Uh oh!

zhiics left a comment

Choose a reason for hiding this comment

Uh oh!

zhiics commented Oct 15, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

tqchen commented Oct 13, 2019•
edited
Loading

tqchen commented Oct 13, 2019•
edited
Loading