Skip to content

remove PEP498 f-string new feature for support python3.5 - #4250

Merged
tqchen merged 9 commits into
apache:masterfrom
KimYannn:master
Nov 4, 2019
Merged

remove PEP498 f-string new feature for support python3.5#4250
tqchen merged 9 commits into
apache:masterfrom
KimYannn:master

Conversation

@KimYannn

Copy link
Copy Markdown
Contributor

As Forum https://discuss.tvm.ai/t/what-is-minimal-python3-version-requirements/4594
Just remove pep498 which is a new feature in python 3.6+
DONE:

  • replace f-strings with format
    TODO:
  • add codestyle check for python3.5

could u kindly have a look at this pr? @tqchen@yongwww@MarisaKirisame

@tqchen

Copy link
Copy Markdown
Member

please fix the CI error

@KimYannn

KimYannn commented Nov 4, 2019

Copy link
Copy Markdown
ContributorAuthor

please fix the CI error

make: *** [pylint] Error 16
Makefile:77: recipe for target 'pylint' failed
script returned exit code 2

I think this ci error not cause by my code?

Comment threadpython/tvm/relay/_parser.py Outdated
@tqchen
tqchen merged commit 996cf30 into apache:masterNov 4, 2019
@tqchen

Copy link
Copy Markdown
Member

Thanks @KimBioInfoStudio

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@KimYannn@tqchen@MarisaKirisame@zhuochenKIDD