Uh oh!
There was an error while loading. Please reload this page.
[RUNTIME] Proper Device Attribute Query for AMD GPU - #4305
Merged
Conversation
petrex
commented
Nov 12, 2019
ContributorAuthor
The error doesn't seem relevant to me, let me kick off the CI again. |
t-vi
reviewed
Nov 14, 2019
Uh oh!
There was an error while loading. Please reload this page.
petrex
commented
Nov 14, 2019
ContributorAuthor
See wiki. One architecture with different compute capabilities. |
masahi
approved these changes
Nov 15, 2019
masahi
commented
Nov 15, 2019
Member
petrexforce-pushed
the
rocm_device
branch
3 times, most recently
from
November 15, 2019 22:11
18df399 to
60064ecComparemasahi
commented
Nov 15, 2019
Member
@petrex can you check indentation issues? I see some weird indentation done by clang-format. It should be consistent with the rest of the code base. |
petrex
commented
Nov 16, 2019
ContributorAuthor
Morning @masahi. That weird clang-format behavior was due to a missing |
zxy844288792 pushed a commit
to zxy844288792/tvm
that referenced
this pull request
Nov 26, 2019
yongwww pushed a commit
to neo-ai/tvm
that referenced
this pull request
Nov 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR implements proper device queries through hip runtime API.
One primary motivation is to support devices across different architectures. Note that we had some hardcoded value before (for example, max thread per block/ warp size), which may not be optimal for the new architecture.
One minor change: replace hipGetDeviceProperties() with hipDeviceGetAttribute() for better perf.