[VTA][TSIM] Enable TSIM CI Testing by liangfu · Pull Request #4407 · apache/tvm

liangfu · 2019-11-23T08:21:30Z

This PR intends to enable testing Chisel VTA design with the help of TSIM.

yzhliu · 2019-11-25T16:44:12Z

@tmoreau89 could you take a look?

tmoreau89

Thanks Liangfu; did the CI docker image build properly with all of the Chisel dependencies?

tmoreau89 · 2019-11-25T18:44:58Z

@liangfu it seems like there are some errors in the CI; were you able to run the unit tests locally? You may have to test it and run it into the CI docker container. You may want to try it locally on your machine. BTW, the reason I had to comment out these lines of code is because the tests in the docker was causing some issues. I can spend cycles help debug what's wrong.

liangfu · 2019-11-26T01:55:42Z

It seems to me that Chisel dependencies are handled properly already, except for fixing the sbt version to 1.1.1 in installing sbt throught apt, so that an update to sbt version is no longer necessary.

@tmoreau89 Yes, I'm able to run the unit tests locally. The error reported in the CI seems to be related to the build configuration. I will put on an update once I found the root cause.

tmoreau89 · 2019-11-27T00:00:56Z

thanks @liangfu

liangfu · 2020-01-07T10:26:15Z

Hi @tmoreau89 , I have updated the docker/install/ubuntu_install_chisel.sh, do you have any idea how to reflect the change in the CI pipeline?

tmoreau89 · 2020-01-07T17:15:32Z

Thanks @liangfu ; was the test running successfully on the image? We'll need to get @tqchen to update the image registry.

tqchen · 2020-01-07T17:36:41Z

Thanks @liangfu Please send a PR separately for the docker update. Then we can enable tests

liangfu · 2020-01-08T10:07:56Z

Some recent changes made the unit tests unsuccessful.

liangfu · 2020-01-16T12:18:43Z

@tmoreau89 As shown in my last commit , all VTA tests are successful with TSIM backend.

The latest CI log is reporting failure because we have verilator and sbt installed on docker image v0.55 , but not on v0.52 .

tmoreau89 · 2020-01-16T17:01:53Z

Thanks for pushing this through to the finish line @liangfu! Can we update the docker image used for CI testing?

tmoreau89 · 2020-01-16T17:02:36Z

Also do you mind referencing the PR that updates the docker image for future reference?

liangfu · 2020-01-16T22:00:57Z

Also do you mind referencing the PR that updates the docker image for future reference?

Please refer to #4674 for installing verilator and sbt, #4675 for installing their dependencies, and #4677 for using the new image in CI.

tmoreau89 · 2020-01-16T22:13:31Z

Cool, thanks. Since the PRs have been merged, is there a reason why we are still using the old docker image which causes CI to fail?

liangfu · 2020-01-16T22:32:55Z

I think docker image v0.52 is for i386, and it has no svt and verilator install. Previous docker update v0.55 is for x86-64.

tmoreau89 · 2020-01-16T22:34:26Z

Oh so you're saying that we cannot run tsim tests on i386 then? Should we disable the tsim tests for i386 then?

liangfu · 2020-01-16T22:39:11Z

Oh so you're saying that we cannot run tsim tests on i386 then? Should we disable the tsim tests for i386 then?

Yes, but I'm not quite sure about how to do this.

tmoreau89 · 2020-01-16T22:59:40Z

I can suggest the following: we can have a task_python_vta_fsim.sh and a task_python_vta_tsim.sh script that are each separate. One thing we'll need to do before executing tests is to add the cp vta/config/fsim_sample.json vta/config/vta_config.json or cp vta/config/tsim_sample.json vta/config/vta_config.jsonfirst wether we execute fsim or tsim respectively. This ensures that if someone re-orders the tests, functionality won't be affected...

liangfu · 2020-01-16T23:54:36Z

Sure, let's follow this approach.

tmoreau89 · 2020-01-17T02:17:28Z

@liangfu great! Can you also update the jenkins file? Please grep for task_python_vta.sh in the Jenkins file, and for i386 keep the fsim tests, while for x86_64 add both. Thanks!

liangfu · 2020-01-17T03:33:04Z

@tmoreau89 Jenkinsfile has been revised, but why Jenkins is still evaluating task_python_vta.sh ?

tmoreau89 · 2020-01-17T06:22:30Z

hmmm that's odd; try re-triggering it one more time?

liangfu · 2020-01-17T06:57:34Z

I come to understand the reason now. Although PR #4677 changed the image to v0.55, Jenkins still runs on v0.54 on that PR. Therefore, I think Jenkins is a step late to run everything in Jenkinsfile.

For that reason, I've duplicated a copy of task_python_vta_fsim.sh as task_python_vta.sh for now. Once this is merged, we can remove the task_python_vta.sh in a follow up PR, or you might prefer merge #4734 first.

tmoreau89 · 2020-01-17T23:24:10Z

thank you @liangfu the PR has been merged!

* Update task_python_vta.sh * install sbt=1.1.1 with apt-get * update verilator_opt * install verilator with major version 4.0 * disable multi-threading for now * bug fix for correcting uop fetch address in LoadUop module * bug fix for correcting uop fetch address in LoadUop module * adjustment to read from dram_offset * enable USE_THREADS with verilator 4.x * DEBUG: try avoid core dump with verilator 4.x * bug fix in LoadUop module * log mega cycles in tsim * download cat.png to avoid fetching in each run * bug fix in LoadUop module * solve dram_even/sram_even issue * bug fix * introduce scalalint in ci * speedup tsim in ci * bug fix * lint scala code before building * disable multi-threading * split fsim/tsim script * update Jenkins settings * duplicate task_python_vta_fsim.sh as task_python_vta.sh for now Co-authored-by: Thierry Moreau <tmoreau@octoml.ai>

Update task_python_vta.sh
0813fe0

yzhliu added the status: need review label Nov 25, 2019

tmoreau89 approved these changes Nov 25, 2019
View reviewed changes

liangfu mentioned this pull request Dec 21, 2019
[VTA] improved virtual memory mapping #4545
Merged

liangfuand others added 4 commits January 7, 2020 16:27

install sbt=1.1.1 with apt-get
c59ead4

Merge remote-tracking branch 'upstream/master' into patch-16
b7652ac

update verilator_opt
33fa60c

install verilator with major version 4.0
d8b9dfd

disable multi-threading for now
8f63c39

liangfu force-pushed the patch-16 branch from 4ef109e to 8f63c39Compare January 8, 2020 10:26

liangfu added 12 commits January 10, 2020 16:43

bug fix for correcting uop fetch address in LoadUop module
a1d558c

bug fix for correcting uop fetch address in LoadUop module
b284805

adjustment to read from dram_offset
85292ce

Merge branch 'master' into patch-16
0ea9c22

enable USE_THREADS with verilator 4.x
fe24e25

DEBUG: try avoid core dump with verilator 4.x
6f5c6dd

bug fix in LoadUop module
e9e22e4

log mega cycles in tsim
0000e27

Merge remote-tracking branch 'upstream/master' into patch-16
fe9761c

download cat.png to avoid fetching in each run
713e9c9

bug fix in LoadUop module
0fda8c2

solve dram_even/sram_even issue
aea6046

liangfu added 2 commits January 16, 2020 17:31

bug fix
ca0aa2c

lint scala code before building
8b1b12f

liangfu requested a review from tmoreau89 January 16, 2020 10:06

disable multi-threading
444fd2f

split fsim/tsim script
0ec9d81

update Jenkins settings
28be228

liangfu mentioned this pull request Jan 17, 2020
[VTA] Update Jenkinsfile for VTA test with TSIM #4734
Merged

liangfuand others added 2 commits January 17, 2020 19:44

duplicate task_python_vta_fsim.sh as task_python_vta.sh for now
1d85883

Merge branch 'master' into patch-16
84f9410

tmoreau89 merged commit 2738edd into apache:masterJan 17, 2020

liangfu deleted the patch-16 branch April 14, 2020 14:32

Uh oh!

Conversation

liangfu commented Nov 23, 2019• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yzhliu commented Nov 25, 2019

Uh oh!

tmoreau89 left a comment

Choose a reason for hiding this comment

Uh oh!

tmoreau89 commented Nov 25, 2019

Uh oh!

liangfu commented Nov 26, 2019

Uh oh!

tmoreau89 commented Nov 27, 2019

Uh oh!

liangfu commented Jan 7, 2020

Uh oh!

tmoreau89 commented Jan 7, 2020

Uh oh!

tqchen commented Jan 7, 2020

Uh oh!

liangfu commented Jan 8, 2020

Uh oh!

liangfu commented Jan 16, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tmoreau89 commented Jan 16, 2020

Uh oh!

tmoreau89 commented Jan 16, 2020

Uh oh!

liangfu commented Jan 16, 2020

Uh oh!

tmoreau89 commented Jan 16, 2020

Uh oh!

liangfu commented Jan 16, 2020

Uh oh!

tmoreau89 commented Jan 16, 2020

Uh oh!

liangfu commented Jan 16, 2020

Uh oh!

tmoreau89 commented Jan 16, 2020

Uh oh!

liangfu commented Jan 16, 2020

Uh oh!

tmoreau89 commented Jan 17, 2020

Uh oh!

liangfu commented Jan 17, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tmoreau89 commented Jan 17, 2020

Uh oh!

liangfu commented Jan 17, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tmoreau89 commented Jan 17, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

liangfu commented Nov 23, 2019•
edited
Loading

liangfu commented Jan 16, 2020•
edited
Loading

liangfu commented Jan 17, 2020•
edited
Loading

liangfu commented Jan 17, 2020•
edited
Loading