Uh oh!
There was an error while loading. Please reload this page.
[CI][Docker] Bump ONNX version to 1.6 - #4538
Conversation
jwfromm
commented
Dec 18, 2019
Have you managed to get |
With ONNX v1.6, I do get segfault when importing both ONNX and PyTorch (seems to be the same issue as this one). If I remove PyTorch import, my test case in #4536, which uses onnxruntime (which in tern calls check_model) works fine. The following works for me too. Doesn't the CI = green mean we are good to go with v1.6? Assuming the CI is updated with this PR and is running on v1.6 (not sure the correct way to update the CI env) |
tqchen
commented
Dec 18, 2019
The CI is not directly updated when the docker get updated, see https://docs.tvm.ai/contribute/pull_request.html#ci-environment . Would be great if we can have tests to confirm things, i will also followup later this week. |
masahi
commented
Dec 18, 2019
Running tests/python/frontend/onnx/test_forward.py with the new CI should confirm whether ONNX v1.6 is in good state. Based on the discussion so far, it seems likely to crash. |
tqchen
commented
Dec 19, 2019
masahi
commented
Dec 19, 2019
Ok, no problem for me. |
masahi
commented
Dec 20, 2019
I've tested on an environment with ONNX 1.6 + PyTorch master build, I can run onnx/test_forward.py without any issue. I recommend updating our CI env to PyTorch 1.4 (which should be out soon) along with ONNX 1.7. |
This is a prerequisite for #4536
cc @tqchen@jwfromm