Skip to content

[CONV3D] remove incorrect schedule for conv3d_ndhwc - #4659

Closed
optima2005 wants to merge 2 commits into
apache:masterfrom
optima2005:fix_conv3d_ndhwc
Closed

[CONV3D] remove incorrect schedule for conv3d_ndhwc#4659
optima2005 wants to merge 2 commits into
apache:masterfrom
optima2005:fix_conv3d_ndhwc

Conversation

@optima2005

Copy link
Copy Markdown
Contributor

This is a fix to #4604, to remove unnecessary and incorrect cuda schedule for conv3d_ndhwc

@masahi @icemelon9

@tqchentqchen added status: need test case need test cases to cover the change status: need review labels Jan 8, 2020
@masahi

Copy link
Copy Markdown
Member

if you remove schedule_conv3d_ndhwc_cuda, what happens if schedule_conv3d_ndhwc was called on cuda target? You get an error?

@icemelon

Copy link
Copy Markdown
Member

Never mind. I'll fix the conv3d issue in #4644 since I'm changing the TOPI.

@icemelonicemelon closed this Jan 9, 2020
@optima2005

Copy link
Copy Markdown
ContributorAuthor

@masahi Yes. it would report error. Currently at least in TF frontend, the NHWC for conv2d, NDHWC for conv3d are forced to transform to NCHW/NCDHW layout. Please see this, this and this. I guess that might be under perormance consideration. But a more user friendly approach may be needed to notice the user TVM not supporting those layouts under cuda target.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: need reviewstatus: need test caseneed test cases to cover the change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@optima2005@masahi@icemelon@tqchen