Skip to content

[Relay][Frontend][TFlite] Add support for quantized LOGISTIC - #4696

Merged
FrozenGene merged 2 commits into
apache:masterfrom
inadob:qnn_logistic
Feb 7, 2020
Merged

[Relay][Frontend][TFlite] Add support for quantized LOGISTIC#4696
FrozenGene merged 2 commits into
apache:masterfrom
inadob:qnn_logistic

Conversation

@inadob

@inadobinadob commented Jan 13, 2020

Copy link
Copy Markdown
Contributor

This patch is built on top of two pending PRs: #4789 and #4805 (only 70dfaf6)

  • add qnn implementation in the parser
  • add test case for qnn logistic

@inadob

Copy link
Copy Markdown
ContributorAuthor

@anijain2305@FrozenGene, can you please check this patch

@u99127

Copy link
Copy Markdown
* add qnn implementation in the parser
* add test case for qnn logistic

LGTM

Ramana

@u99127

Copy link
Copy Markdown

ping for an approving review ? @FrozenGene@anijain2305.

Comment threadpython/tvm/relay/frontend/tflite.py

@anijain2305anijain2305 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for such a late review. LGTM.

@FrozenGene@u99127 I think we are converging on keeping FP32 softmax for now. I think, once Ina addresses the comments, we can get this PR in.

Comment threadtests/python/frontend/tflite/test_forward.py Outdated
@anijain2305

Copy link
Copy Markdown
Contributor

@inadob Please rebase

@tqchentqchen added the status: need update need update based on feedbacks label Feb 6, 2020
@tqchen

Copy link
Copy Markdown
Member

@inadob please rebase, @FrozenGene please https://docs.tvm.ai/contribute/code_review.html#approve-and-request-changes-explicitly

@FrozenGene

Copy link
Copy Markdown
Member

Thanks @inadob@anijain2305@u99127 This is merged.

@FrozenGene
FrozenGene merged commit 5a13575 into apache:masterFeb 7, 2020
anijain2305 pushed a commit to anijain2305/tvm that referenced this pull request Feb 10, 2020
…4696)
* [Relay][Frontend][TFlite] Add support for quantized LOGISTIC
* add qnn implementation
* add qnn test case for qnn logistic
* Helper functions for quantize and dequantize.
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
…4696)
* [Relay][Frontend][TFlite] Add support for quantized LOGISTIC
* add qnn implementation
* add qnn test case for qnn logistic
* Helper functions for quantize and dequantize.
alexwong pushed a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
…4696)
* [Relay][Frontend][TFlite] Add support for quantized LOGISTIC
* add qnn implementation
* add qnn test case for qnn logistic
* Helper functions for quantize and dequantize.
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
…4696)
* [Relay][Frontend][TFlite] Add support for quantized LOGISTIC
* add qnn implementation
* add qnn test case for qnn logistic
* Helper functions for quantize and dequantize.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: need updateneed update based on feedbacks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@inadob@u99127@anijain2305@tqchen@FrozenGene