Skip to content

[Tutorial] Add a tutorial for PyTorch - #4936

Merged
masahi merged 8 commits into
apache:masterfrom
alexwong:pytorch_tut
Feb 26, 2020
Merged

[Tutorial] Add a tutorial for PyTorch#4936
masahi merged 8 commits into
apache:masterfrom
alexwong:pytorch_tut

Conversation

@alexwong

Copy link
Copy Markdown
Contributor

Thanks for contributing to TVM! Please refer to guideline https://docs.tvm.ai/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

Wasn't sure if a tutorial is expected for new frontends but I wrote one a while ago and now #4497 is merged.

@alexwongalexwong changed the title Add a tutorial for PyTorch[Tutorial] Add a tutorial for PyTorchFeb 25, 2020

@comaniaccomaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please refer to the comments to fix the Sphinx format issues.

Comment threadtutorials/frontend/from_pytorch.py Outdated
Comment threadtutorials/frontend/from_pytorch.py Outdated
Comment threadtutorials/frontend/from_pytorch.py Outdated
Comment threadtutorials/frontend/from_pytorch.py

@zhiicszhiics left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@masahi please help take a look as well. Thanks.

@comaniaccomaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadtutorials/frontend/from_pytorch.py Outdated
Comment threadtutorials/frontend/from_pytorch.py
Comment threadtutorials/frontend/from_pytorch.py Outdated
Comment threadtutorials/frontend/from_pytorch.py Outdated
Comment threadtutorials/frontend/from_pytorch.py Outdated
Comment threadtutorials/frontend/from_pytorch.py Outdated
Comment threadtutorials/frontend/from_pytorch.py Outdated
@masahimasahi self-assigned this Feb 26, 2020
@masahi
masahi merged commit 61bea50 into apache:masterFeb 26, 2020
@masahi

Copy link
Copy Markdown
Member

Thanks @alexwong@zhiics@comaniac@kevinthesun@yzhliu

alexwong added a commit to alexwong/tvm that referenced this pull request Feb 26, 2020
* Add a tutorial for PyTorch
* Fix sphinx formatting, add version support
* Remove space
* Remove version check
* Some refactoring
* Use no grad
* Rename input
* Update cat img source
alexwong added a commit to alexwong/tvm that referenced this pull request Feb 28, 2020
* Add a tutorial for PyTorch
* Fix sphinx formatting, add version support
* Remove space
* Remove version check
* Some refactoring
* Use no grad
* Rename input
* Update cat img source
zhiics pushed a commit to neo-ai/tvm that referenced this pull request Mar 2, 2020
* Add a tutorial for PyTorch
* Fix sphinx formatting, add version support
* Remove space
* Remove version check
* Some refactoring
* Use no grad
* Rename input
* Update cat img source
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants

@alexwong@masahi@yzhliu@zhiics@comaniac@kevinthesun