[topi][relay] add operation tan to TVM by notoraptor · Pull Request #4938 · apache/tvm

notoraptor · 2020-02-25T16:45:33Z

Hi! This pull request adds operation tan to TVM. The main goal is to make it available in relay module.

kevinthesun · 2020-02-27T20:46:04Z

Minor comments. Also can you rebase master?

notoraptor · 2020-02-27T21:03:41Z

In order to fix failed test (precision error), I am trying to update the tan implementation in llvm target (by replacing sin/cos with a direct call to llvm's tan functions). But it currently generate other issues, so I am working on it.

I can rebase now, but I guess test will fail again.

notoraptor · 2020-02-27T21:17:42Z

Rebased and updated to try to fix failing test.

notoraptor · 2020-02-28T18:43:52Z

Hi @kevinthesun I rebased and added shape function for tan in latest commit.

I still have a mismatch error in tests/python/frontend/tensorflow/test_forward.py::test_forward_tan. It's hard to debug because I cannot reproduce it on my computer. But I am still working on it.

This reverts commit 4da5b50.

Simplify topi/tests/python/test_topi_math. Add testing for tan with float32 and float64. Try again to implement tan as sin/cos in llvm.

notoraptor · 2020-03-04T19:33:22Z

@kevinthesun Tests passed ! I implemented tan in LLVM using sin/cos and I fixed CUDA implementation by using tanf instead of __tanf for float32.

kevinthesun

LGTM

kevinthesun · 2020-03-06T01:17:49Z

@notoraptor Thanks!

tqchen · 2020-03-06T01:20:15Z

NOTE: the git commit message messed up today due to github issue https://discuss.tvm.ai/t/github-issue-the-commit-author-is-wrong-since-today/5880/15 we should refrain from merging others' PR until tomorrow

kevinthesun · 2020-03-06T02:37:46Z

@tqchen Do we need to do something for this PR?

tqchen · 2020-03-07T02:41:35Z

See https://discuss.tvm.ai/t/response-to-github-author-attribution-bug/5909

tqchen · 2020-03-09T19:53:52Z

This PR is among one of the PRs affected by the github squash commit bug. We take every contribution serious in the TVM community. The community has decided to use revert/redo approach to amend the contributions as per #5015

notoraptor · 2020-03-09T20:02:31Z

Hi @tqchen ! OK for that.

Anyway, if it causes some problems, then we can just let things as it is, as my main goal was just to make tan available in relay !

Thanks !

tqchen · 2020-03-09T20:17:54Z

cc @kevinthesun please send the reverting PR, then @notoraptor can send the patch

This reverts commit d992468.

* Add relay operation relay.op.tan. * Update tan implementation in TVM. * Update tests. * Add shape function for tan. * Add missing main test to python/frontend/tensorflow/test_forward. * Revert, back to sin/cos. * Revert "Revert, back to sin/cos." This reverts commit 4da5b50. * Fix implementation of tan in cuda. Do not support tan for float16. Simplify topi/tests/python/test_topi_math. Add testing for tan with float32 and float64. Try again to implement tan as sin/cos in llvm.

…#5017) This reverts commit d992468.

* Add relay operation relay.op.tan. * Update tan implementation in TVM. * Update tests. * Add shape function for tan. * Add missing main test to python/frontend/tensorflow/test_forward. * Revert, back to sin/cos. * Revert "Revert, back to sin/cos." This reverts commit 4da5b50. * Fix implementation of tan in cuda. Do not support tan for float16. Simplify topi/tests/python/test_topi_math. Add testing for tan with float32 and float64. Try again to implement tan as sin/cos in llvm.

…#5017) This reverts commit d992468.

notoraptor requested review from Huyuwei and Laurawly as code owners February 25, 2020 16:45

kevinthesun reviewed Feb 27, 2020
View reviewed changes

Comment threadpython/tvm/relay/op/_tensor.py

notoraptor added 8 commits March 4, 2020 10:34

Add relay operation relay.op.tan.
b3e83cb

Update tan implementation in TVM.
bbbd2a7

Update tests.
9aa1337

Add shape function for tan.
7ac6f78

Add missing main test to python/frontend/tensorflow/test_forward.
308aa9b

Revert, back to sin/cos.
45fbd87

Revert "Revert, back to sin/cos."
68e7088
This reverts commit 4da5b50.

Fix implementation of tan in cuda. Do not support tan for float16.
cb51518
Simplify topi/tests/python/test_topi_math. Add testing for tan with float32 and float64. Try again to implement tan as sin/cos in llvm.

kevinthesun approved these changes Mar 6, 2020
View reviewed changes

kevinthesun merged commit d992468 into apache:masterMar 6, 2020

tqchen mentioned this pull request Mar 9, 2020
[DEV] Amend Github Attribution Bug #5015
Closed
5 tasks

kevinthesun added a commit to kevinthesun/tvm that referenced this pull request Mar 9, 2020
Revert "[topi][relay] add operation tan to TVM (apache#4938)"
fedc0c6
This reverts commit d992468.

kevinthesun mentioned this pull request Mar 9, 2020
Revert "[topi][relay] add operation tan to TVM (#4938)" #5017
Merged

masahi pushed a commit that referenced this pull request Mar 10, 2020
Revert "[topi][relay] add operation tan to TVM (#4938)" (#5017)
c0bc188
This reverts commit d992468.

notoraptor mentioned this pull request Mar 10, 2020
[topi][relay] new PR to re-add tan to TVM #5025
Merged

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Apr 16, 2020
Revert "[topi][relay] add operation tan to TVM (apache#4938)" (apache…
105a366
…#5017) This reverts commit d992468.

zhiics pushed a commit to neo-ai/tvm that referenced this pull request Apr 17, 2020
Revert "[topi][relay] add operation tan to TVM (apache#4938)" (apache…
87c2ec1
…#5017) This reverts commit d992468.

ZihengJiang mentioned this pull request Sep 17, 2020
TVM v0.7 Release Note Candidate #6486
Closed

Uh oh!

Conversation

notoraptor commented Feb 25, 2020

Uh oh!

Uh oh!

kevinthesun commented Feb 27, 2020

Uh oh!

notoraptor commented Feb 27, 2020

Uh oh!

notoraptor commented Feb 27, 2020

Uh oh!

notoraptor commented Feb 28, 2020

Uh oh!

notoraptor commented Mar 4, 2020

Uh oh!

kevinthesun left a comment

Choose a reason for hiding this comment

Uh oh!

kevinthesun commented Mar 6, 2020

Uh oh!

tqchen commented Mar 6, 2020

Uh oh!

kevinthesun commented Mar 6, 2020

Uh oh!

tqchen commented Mar 7, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tqchen commented Mar 9, 2020• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

notoraptor commented Mar 9, 2020

Uh oh!

tqchen commented Mar 9, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

tqchen commented Mar 7, 2020•
edited
Loading

tqchen commented Mar 9, 2020•
edited
Loading