Uh oh!
There was an error while loading. Please reload this page.
[BUGFIX] Fix CRT static test bug - #5293
Merged
Merged
Conversation
tqchen
commented
Apr 9, 2020
MemberAuthor
zhiics
approved these changes
Apr 9, 2020
tqchen
commented
Apr 9, 2020
MemberAuthor
Followup #5294 |
tmoreau89
approved these changes
Apr 9, 2020
tmoreau89
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the fix, LGTM
mehrdadh
reviewed
Apr 9, 2020
| @@ -103,6 +104,6 @@ int main(int argc, char **argv) { | |||
| (t3.tv_sec-t2.tv_sec)*1000000 + (t3.tv_usec-t2.tv_usec)/1000.f, | |||
Member
There was a problem hiding this comment.
1000000 should change to 1000 since this is second to ms conversion.
mehrdadh
reviewed
Apr 9, 2020
| @@ -118,6 +120,6 @@ int main(int argc, char **argv) { | |||
tqchen
commented
Apr 9, 2020
MemberAuthor
Thanks @masahi@zhiics@mehrdadhe@tmoreau89 this pr is now merged |
This was referenced Apr 9, 2020
trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
Apr 16, 2020
* [CI][DOCS] Make sure to refresh the cython part * [BUGFIX] Fix CRT static test bug * Fix demo_static * resolve review comment
zhiics pushed a commit
to neo-ai/tvm
that referenced
this pull request
Apr 17, 2020
* [CI][DOCS] Make sure to refresh the cython part * [BUGFIX] Fix CRT static test bug * Fix demo_static * resolve review comment
dpankratz pushed a commit
to dpankratz/incubator-tvm
that referenced
this pull request
Apr 24, 2020
* [CI][DOCS] Make sure to refresh the cython part * [BUGFIX] Fix CRT static test bug * Fix demo_static * resolve review comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a segfault caused by wrongly assigning the address of the array pointer to the shape instead of the array. This problem was revealed by a compiler warning .
This PR fixes the recent compiler flaky error on i386