Uh oh!
There was an error while loading. Please reload this page.
[random] support random fill - #5913
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
tqchen
commented
Jun 24, 2020
see comments, we don't need to expose the(non_empty) function as a primitive function, given that it is not a numpy function, and is only used in AutoTVM, instead we can achieve the same goal by x=nd.empty(..)
random_fill=get_packed_func("contrib.random.random_fill") random_fill(x)Notably, the above solution is better because:
|
Uh oh!
There was an error while loading. Please reload this page.
junrushao
commented
Jun 24, 2020
I agree with TQ's point. Also, I am a bit concerned if we really need a C API for this. |
FrozenGene
commented
Jun 28, 2020
I will handle it as comments |
tqchen
commented
Jul 10, 2020
@FrozenGene please followup |
Thanks for reminding. I want to complete the clflush pr and model based runtime pr, then handle this pr. Could you help to handle model based runtime pr now? |
@tqchen I restart this work. This way we could make the random initialization on the device (i.e. |
@FrozenGene Please followup. It is okay to do the path |
tqchen
commented
Aug 6, 2020
Ping |
FrozenGene
commented
Aug 6, 2020
@merrymercy Our current method is we will introduce one @tqchen 's suggestion we could leverage I will follow up my pr that move our implementation to the |
de37081 to
696fdd9Compare
@merrymercy@tqchen I have updated the code and verified it in the remote cpu / remote mali gpu. We could do |
Uh oh!
There was an error while loading. Please reload this page.
FrozenGene
commented
Aug 13, 2020
Yes. |
FrozenGene
commented
Aug 14, 2020
@tqchen@merrymercy gental ping. Code has been updated. |
Uh oh!
There was an error while loading. Please reload this page.
FrozenGene
commented
Aug 17, 2020
@tqchen@merrymercy@comaniac do you have other comments? |
tqchen
commented
Aug 17, 2020
@FrozenGene Can you send the follow-up PRs to enable this in ansor and autotvm? |
FrozenGene
commented
Aug 27, 2020
Thanks for reminding @merrymercy. My agenda is completely full tomorrow and weekend. I could do this next week. |
This pr support us to allocate non empty values of nd array, which could solve the issue of autotvm measurement is not correct (see #5200). This is one standalone part of Ansor (#5883).
@kevinthesun@merrymercy@minminsun@jcf94