Skip to content

Cache object refs in loop partitioner instead of object pointers - #6004

Merged
tqchen merged 2 commits into
apache:masterfrom
kparzysz-quic:loop-part
Jul 8, 2020
Merged

Cache object refs in loop partitioner instead of object pointers#6004
tqchen merged 2 commits into
apache:masterfrom
kparzysz-quic:loop-part

Conversation

@kparzysz-quic

Copy link
Copy Markdown
Contributor

Loop partitioner modifies the IR, which can cause TIR objects to become dead and be destroyed. To avoid working on junk data cache object references instead of object pointers.

Loop partitioner modifies the IR, which can cause TIR objects to
become dead and be destroyed. To avoid working on junk data cache
object references instead of object pointers.
@tqchen

Copy link
Copy Markdown
Member

cc @ZihengJiang

@tqchen
tqchen merged commit 2875e4c into apache:masterJul 8, 2020
@tqchen

Copy link
Copy Markdown
Member

Thanks @kparzysz-quic !

pingsutw pushed a commit to pingsutw/incubator-tvm that referenced this pull request Jul 8, 2020
…he#5099)
* [TOPI][Tensor Core] Optimization of CNNs on Tensor Core apache#6004
* update conv2d test
* # pylint: dense_tensorcore.py
* modify
* modify conv2d
* modify the unclear comment,add shape assertion in conv2d compute,combine general gemm intrinsic
* add shape assertion in conv2d compute, combine general gemm intrinsic
Co-authored-by: libaihong <libaihong@inspur.com>
Co-authored-by: libaihong <61525430+libaihong@users.noreply.github.com>
@kparzysz-quic
kparzysz-quic deleted the loop-part branch July 8, 2020 11:46
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jul 14, 2020
…che#6004)
* Cache object refs in loop partitioner instead of object pointers
Loop partitioner modifies the IR, which can cause TIR objects to
become dead and be destroyed. To avoid working on junk data cache
object references instead of object pointers.
* Fix format/lint errors
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jul 14, 2020
…che#6004)
* Cache object refs in loop partitioner instead of object pointers
Loop partitioner modifies the IR, which can cause TIR objects to
become dead and be destroyed. To avoid working on junk data cache
object references instead of object pointers.
* Fix format/lint errors
kevinthesun pushed a commit to kevinthesun/tvm that referenced this pull request Sep 17, 2020
…he#5099)
* [TOPI][Tensor Core] Optimization of CNNs on Tensor Core apache#6004
* update conv2d test
* # pylint: dense_tensorcore.py
* modify
* modify conv2d
* modify the unclear comment,add shape assertion in conv2d compute,combine general gemm intrinsic
* add shape assertion in conv2d compute, combine general gemm intrinsic
Co-authored-by: libaihong <libaihong@inspur.com>
Co-authored-by: libaihong <61525430+libaihong@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@kparzysz-quic@tqchen@ZihengJiang