Skip to content

[Ansor][AutoTVM v2.0] Phase 2: Layout Rewrite in AutoScheduler - #6297

Merged
merrymercy merged 11 commits into
apache:masterfrom
minminsun:master
Sep 9, 2020
Merged

[Ansor][AutoTVM v2.0] Phase 2: Layout Rewrite in AutoScheduler#6297
merrymercy merged 11 commits into
apache:masterfrom
minminsun:master

Conversation

@minminsun

@minminsunminminsun commented Aug 18, 2020

Copy link
Copy Markdown
Contributor

For full upstream plan, see Ansor RFC.

In this PR, we enable AutoScheduler to rewrite the layout of placeholders to best fit the loop nest of the candidate schedule to be applied on ComputeDAG.

Note that the function in this PR is only for performance evaluation with layout rewrite. An end-to-end solution of layout rewrite requires close cooperation with relay passes, which will be provided in future PRs.

CC @merrymercy@jcf94@FrozenGene@comaniac@tqchen

jcf94
jcf94 reviewed Aug 18, 2020
View reviewed changes
Comment threadpython/tvm/auto_scheduler/compute_dag.py
Comment threadinclude/tvm/auto_scheduler/compute_dag.h Outdated
Comment threadpython/tvm/auto_scheduler/measure.py
jcf94
jcf94 requested changes Aug 18, 2020
View reviewed changes
Comment threadpython/tvm/auto_scheduler/measure.py
jcf94
jcf94 reviewed Aug 18, 2020
View reviewed changes
Comment threadinclude/tvm/auto_scheduler/transform_step.h Outdated
comaniac
comaniac requested changes Aug 18, 2020
View reviewed changes

@comaniaccomaniac left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The most important point in this PR to me is lacking of comments to explain what the code is doing. Also please add unit tests.

Comment threadinclude/tvm/auto_scheduler/transform_step.h Outdated
Comment threadsrc/auto_scheduler/compute_dag.cc
Comment threadsrc/auto_scheduler/compute_dag.cc Outdated
Comment threadsrc/auto_scheduler/compute_dag.cc Outdated
Comment threadsrc/auto_scheduler/compute_dag.cc Outdated
Comment threadsrc/auto_scheduler/compute_dag.cc Outdated
Comment threadsrc/auto_scheduler/compute_dag.cc Outdated
Comment threadsrc/auto_scheduler/compute_dag.cc Outdated
Comment threadsrc/auto_scheduler/compute_dag.cc Outdated
Comment threadsrc/auto_scheduler/compute_dag.cc Outdated
@merrymercymerrymercy self-assigned this Aug 25, 2020
@tqchen

tqchen commented Sep 3, 2020

Copy link
Copy Markdown
Member

cc @jwfromm@mbrookhart@yzhliu

jwfromm
jwfromm reviewed Sep 6, 2020
View reviewed changes
Comment threadpython/tvm/auto_scheduler/compute_dag.py Outdated
Comment threadsrc/auto_scheduler/compute_dag.cc Outdated
merrymercy
merrymercy reviewed Sep 9, 2020
View reviewed changes
Comment threadinclude/tvm/auto_scheduler/compute_dag.h Outdated
merrymercy
merrymercy requested changes Sep 9, 2020
View reviewed changes
Comment threadpython/tvm/auto_scheduler/compute_dag.py Outdated
Comment threadsrc/auto_scheduler/compute_dag.cc Outdated
Comment threadsrc/auto_scheduler/compute_dag.cc Outdated
@merrymercy

merrymercy commented Sep 9, 2020•
edited
Loading

Copy link
Copy Markdown
Member

@minminsun Please fix some final style comments and we can merge this

@minminsun

minminsun commented Sep 9, 2020

Copy link
Copy Markdown
ContributorAuthor

@minminsun Please fix some final style comments and we can merge this

Done.

@merrymercy
merrymercy merged commit 8499d58 into apache:masterSep 9, 2020
@zhiicszhiics mentioned this pull request Sep 9, 2020
Merged
kevinthesun pushed a commit to kevinthesun/tvm that referenced this pull request Sep 17, 2020
@minminsun@kevinthesun
[Ansor][AutoTVM v2.0] Phase 2: Layout Rewrite in AutoScheduler (apach…
07b0b3f
…e#6297)
* enable layout rewrite for auto scheduler
* refine
* update
* fix CI
* fix CI
* fix CI
* resolve review comments
* add ut
* resolve comments
* resolve comments
* fix coding style
kevinthesun pushed a commit to kevinthesun/tvm that referenced this pull request Sep 18, 2020
@minminsun@kevinthesun
[Ansor][AutoTVM v2.0] Phase 2: Layout Rewrite in AutoScheduler (apach…
5db365a
…e#6297)
* enable layout rewrite for auto scheduler
* refine
* update
* fix CI
* fix CI
* fix CI
* resolve review comments
* add ut
* resolve comments
* resolve comments
* fix coding style
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Sep 18, 2020
@minminsun@trevor-m
[Ansor][AutoTVM v2.0] Phase 2: Layout Rewrite in AutoScheduler (apach…
c3f243e
…e#6297)
* enable layout rewrite for auto scheduler
* refine
* update
* fix CI
* fix CI
* fix CI
* resolve review comments
* add ut
* resolve comments
* resolve comments
* fix coding style
@jcf94jcf94 mentioned this pull request Oct 24, 2020
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jwfrommjwfrommjwfromm left review comments
@jcf94jcf94jcf94 requested changes
@comaniaccomaniaccomaniac requested changes
@merrymercymerrymercymerrymercy approved these changes

Assignees

@merrymercymerrymercy

Labels

status: review in progress

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@minminsun@tqchen@merrymercy@comaniac@jwfromm@jcf94@ZihengJiang