Skip to content

[Relay] Support for PyTorch Non-Maximum Suppression - #6314

Merged
masahi merged 3 commits into
apache:masterfrom
yongwww:nms_pt
Aug 24, 2020
Merged

[Relay] Support for PyTorch Non-Maximum Suppression#6314
masahi merged 3 commits into
apache:masterfrom
yongwww:nms_pt

Conversation

@yongwww

Copy link
Copy Markdown
Member

@masahi@alexwong@kevinthesun@zhiics please help take a look

Comment threadpython/tvm/relay/frontend/pytorch.py Outdated
Comment threadtests/python/frontend/pytorch/test_forward.py
Comment threadtests/python/frontend/pytorch/test_forward.py
Comment threadtests/python/frontend/pytorch/test_forward.py Outdated
@yongwww

Copy link
Copy Markdown
MemberAuthor

@masahi have incorporated your comments, please take another look, thanks!

@zhiicszhiics left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevinthesunkevinthesun left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadtests/python/frontend/pytorch/test_forward.py Outdated
@ZihengJiangZihengJiang added the status: need update need update based on feedbacks label Aug 21, 2020
@yongwww

Copy link
Copy Markdown
MemberAuthor

@masahi please take another look

@masahi
masahi merged commit 37cbbd7 into apache:masterAug 24, 2020
@masahi

Copy link
Copy Markdown
Member

Thanks @yongwww@kevinthesun@zhiics

@masahimasahi mentioned this pull request Aug 24, 2020
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
* [Relay] Support for PyTorch Non-Maximum Suppression
* fix comment
* add verify_model_vm
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
* [Relay] Support for PyTorch Non-Maximum Suppression
* fix comment
* add verify_model_vm
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Aug 26, 2020
* [Relay] Support for PyTorch Non-Maximum Suppression
* fix comment
* add verify_model_vm
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Sep 2, 2020
* [Relay] Support for PyTorch Non-Maximum Suppression
* fix comment
* add verify_model_vm
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Sep 3, 2020
* [Relay] Support for PyTorch Non-Maximum Suppression
* fix comment
* add verify_model_vm
@yongwww
yongwww deleted the nms_pt branch December 8, 2020 13:00
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status: need updateneed update based on feedbacks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@yongwww@masahi@zhiics@kevinthesun@ZihengJiang