Skip to content

[VERILOG] Basic Verilog Testflow - #70

Merged
tqchen merged 4 commits into
masterfrom
tqchen
Mar 14, 2017
Merged

[VERILOG] Basic Verilog Testflow#70
tqchen merged 4 commits into
masterfrom
tqchen

Conversation

@tqchen

@tqchentqchen commented Mar 14, 2017•
edited
Loading

Copy link
Copy Markdown
Member

@tqchen
tqchen requested a review from tmoreau89March 14, 2017 03:04
@tmoreau89

tmoreau89 commented Mar 14, 2017•
edited
Loading

Copy link
Copy Markdown
Contributor

Looks good to me.

In https://github.com/tqchen/tvm/blob/tqchen/tests/verilog/test_counter.v#L7 the #() can be deleted since the module does not take in parameters.

@tqchentqchen reopened this Mar 14, 2017
tmoreau89
tmoreau89 reviewed Mar 14, 2017
View reviewed changes
Comment threadpython/tvm/addon/verilog.py Outdated


def compile_file(file_name, file_target, options=None):
"""Compile cuda code with NVCC from env.

@tmoreau89tmoreau89Mar 14, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be about running the verilog simulation

@tqchentqchenMar 14, 2017

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed in next commit

tmoreau89
tmoreau89 approved these changes Mar 14, 2017
View reviewed changes

@tmoreau89tmoreau89 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@tqchen
tqchen merged commit 9e660db into masterMar 14, 2017
cyx-6 added a commit to cyx-6/tvm that referenced this pull request Jul 27, 2022
@cyx-6
restops,Assertandglobals(apache#70)
72f833b
* rest `op`s, `Assert` and `globals`
* apply code review suggestions
* apply code review suggestions
sunggg pushed a commit to sunggg/tvm that referenced this pull request Apr 15, 2024
@csullivan
[Fix] Fix GPU build on systems without GPUs installed (apache#70)
838c4ed
csullivan added a commit to csullivan/tvm that referenced this pull request Apr 27, 2024
@csullivan
[Fixup] Reapplyapache#70after merge with upstream inapache#72(apa…
9bb2c19
…che#81)
MasterJH5574 pushed a commit to MasterJH5574/tvm that referenced this pull request Aug 17, 2025
@spectrometerHBH
[Kernel] H100 fp16 Flash Attn (apache#70)
fe2e4d0
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* fix some bugs
* fix some bugs
* fix some bugs
* non CAUSAL correct
* debugging CAUSAL
* correct
* perf done
tlopex pushed a commit to tlopex/tvm that referenced this pull request Mar 9, 2026
@spectrometerHBH
[Kernel] H100 fp16 Flash Attn (apache#70)
9e8cea6
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* dev
* fix some bugs
* fix some bugs
* fix some bugs
* non CAUSAL correct
* debugging CAUSAL
* correct
* perf done
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmoreau89tmoreau89tmoreau89 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tqchen@tmoreau89