Uh oh!
There was an error while loading. Please reload this page.
[CUDA][PASS]Legalize tensorcore - #7147
Merged
Merged
Conversation
kongroo
reviewed
Dec 22, 2020
Uh oh!
There was an error while loading. Please reload this page.
jwfromm
previously requested changes
Dec 23, 2020
jwfromm
left a comment
Contributor
There was a problem hiding this comment.
Thanks for your contribution! I like the idea of padding to make other shapes work on tensorcore, but I think its important that you add some tests to confirm this features works as expected before we consider merging.
Uh oh!
There was an error while loading. Please reload this page.
Conflicts: python/tvm/topi/nn/batch_matmul.py python/tvm/topi/nn/dense.py
Meteorixforce-pushed
the
legalize_tensorcore
branch
from
January 11, 2021 06:38
7bf253c to
25dac28CompareMeteorix
commented
Jan 25, 2021
ContributorAuthor
Uh oh!
There was an error while loading. Please reload this page.
| return entry if isinstance(expr, relay.Function) else entry.body | ||
| def test_legalize_conv2d(data_shape, kernel_shape, pad_shape, do_pad=True): |
Contributor
There was a problem hiding this comment.
Please reference test_legalize_pass.py for the CI issue.
Meteorix
commented
Jan 26, 2021
ContributorAuthor
@Laurawly Thanks! The ci passed. |
Laurawly
commented
Jan 26, 2021
Contributor
jcf94
approved these changes
Jan 28, 2021
jcf94
left a comment
Member
There was a problem hiding this comment.
Thanks! Sorry for my late reply. This looks good to me.
jwfromm
approved these changes
Jan 29, 2021
jwfromm
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding the tests, this LGTM now.
Laurawly
commented
Jan 29, 2021
Contributor
alexwong pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
* add pad_to_tensorcore & legalize for dense/bmm/conv2d * fix pad & slice * fix comments * fix comments * resolve conflict * resolve conflict * support only fp16 * add tests/python/relay/test_pass_legalize_tensorcore.py * add tests for legalize tensorcore * fix pylint * fix pylint * code format * use_gpu test only; fix conv2d_alter_op * fix tests params * revert transform fix
electriclilies pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
* add pad_to_tensorcore & legalize for dense/bmm/conv2d * fix pad & slice * fix comments * fix comments * resolve conflict * resolve conflict * support only fp16 * add tests/python/relay/test_pass_legalize_tensorcore.py * add tests for legalize tensorcore * fix pylint * fix pylint * code format * use_gpu test only; fix conv2d_alter_op * fix tests params * revert transform fix
Lokiiiiii pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
* add pad_to_tensorcore & legalize for dense/bmm/conv2d * fix pad & slice * fix comments * fix comments * resolve conflict * resolve conflict * support only fp16 * add tests/python/relay/test_pass_legalize_tensorcore.py * add tests for legalize tensorcore * fix pylint * fix pylint * code format * use_gpu test only; fix conv2d_alter_op * fix tests params * revert transform fix
trevor-m pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
* add pad_to_tensorcore & legalize for dense/bmm/conv2d * fix pad & slice * fix comments * fix comments * resolve conflict * resolve conflict * support only fp16 * add tests/python/relay/test_pass_legalize_tensorcore.py * add tests for legalize tensorcore * fix pylint * fix pylint * code format * use_gpu test only; fix conv2d_alter_op * fix tests params * revert transform fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add legalize pass: padding dense/conv2d/batch_matmul ops to legal shapes for using tensorcore on cuda target. To limit the overhead introduced by padding, we count the
extra_flopsand set the threshold to 2x, which is conservative compared to the speedup of tensorcore.This pr is dependent on #7146 .
@jcf94@merrymercy could you also help review this pr?