Uh oh!
There was an error while loading. Please reload this page.
[TOPI] GPU sort IR refactor to enable sort by keys - #7157
Merged
Conversation
mbrookhart
approved these changes
Dec 23, 2020
mbrookhart
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Yes, thrust's radix sort is very good.
Can you share the benchmark numbers? I'm curious.
Contributor
I definitely didn't promise to be faster than thrust with #7099, just faster that what we had in TIR :) |
MemberAuthor
Ok here it is. I think TIR numbers for 5000 and 10000 agree with the ones you had in #7099
|
Laurawly
approved these changes
Dec 23, 2020
mbrookhart
commented
Dec 23, 2020
Contributor
Yep, this matches the scaling I would expect with that algorithm. I'm kind of surprised that sequential scatter isn't worse than it is. I'm looking for ways to improve the mergesort, but I haven't found a good idea that we can implement in TIR yet, what I've seen requries a |
zhiics
approved these changes
Dec 23, 2020
zhiics
commented
Dec 23, 2020
Member
Thanks @masahi@mbrookhart@Laurawly |
masahi added a commit
to masahi/tvm
that referenced
this pull request
Dec 24, 2020
* sort refactor initial import * sort test working * scatter 1d with positive indices working * remove negatiev indices, using extern for now * minor fix * minor fix * add sort by key test * revert scatter change * add document * fix py format Co-authored-by: masa <masa@pop-os.localdomain>
tkonolige pushed a commit
to tkonolige/incubator-tvm
that referenced
this pull request
Jan 11, 2021
* sort refactor initial import * sort test working * scatter 1d with positive indices working * remove negatiev indices, using extern for now * minor fix * minor fix * add sort by key test * revert scatter change * add document * fix py format Co-authored-by: masa <masa@pop-os.localdomain>
TusharKanekiDey pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Jan 20, 2021
* sort refactor initial import * sort test working * scatter 1d with positive indices working * remove negatiev indices, using extern for now * minor fix * minor fix * add sort by key test * revert scatter change * add document * fix py format Co-authored-by: masa <masa@pop-os.localdomain>
trevor-m pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 21, 2021
* sort refactor initial import * sort test working * scatter 1d with positive indices working * remove negatiev indices, using extern for now * minor fix * minor fix * add sort by key test * revert scatter change * add document * fix py format Co-authored-by: masa <masa@pop-os.localdomain>
electriclilies pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
* sort refactor initial import * sort test working * scatter 1d with positive indices working * remove negatiev indices, using extern for now * minor fix * minor fix * add sort by key test * revert scatter change * add document * fix py format Co-authored-by: masa <masa@pop-os.localdomain>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for sort by key in topi cuda by refactoring the sort IR developed in #7099. By doing different initialization, the exact same sort IR can be reused for sort by key. This is because the original IR already supports argsort and argsort is just a special case of sort by key.
My motivation was to improve the default performance of scatter 1D using sorting based approach (see #7056), when thrust is not available. But it turns out that the sequential scatter kernel is much faster than doing TIR sort, so I dropped that goal for now (this also suggests that thrust's radix sort I used in #7056 is insanely fast). I am sending this PR anyway in the hope that someone would find sort by key useful. My branch that does scatter 1D using the TIR sorting kernel, along with a benchmark script, is available at https://github.com/masahi/tvm/tree/sort_ir_refactor_with_scatter
I also removed
sort_nms_ir, since it is not used anymore and I think it would be much faster to sort entire rows usingsort_iranyway.please review @mbrookhart@Laurawly@zhiics@tkonolige