Uh oh!
There was an error while loading. Please reload this page.
[QNN][TFLite] TFLite rounding mode support - #7456
Conversation
06c238d to
4112141Compare4112141 to
5fe08eaCompareUh oh!
There was an error while loading. Please reload this page.
tqchen
commented
Feb 17, 2021
Thanks @FrozenGene can you move the analysis change to a separate PR so we can review that part carefully |
FrozenGene
commented
Feb 18, 2021
have separated it and resolve your comment |
mbrookhart
commented
Apr 23, 2021
@FrozenGene Any chance you can rebase and fix CI? Thanks! |
jroesch
commented
Jan 19, 2022
This PR appears to be out of date, please feel free to reopen it if this is not the case. As part of the new year we are attempting to triage the project's open pull requests to ensure that code which Thanks again for your contribution, and feel free to reach out to discuss these changes. |
Almost work is done by @Fwd-IV Thanks! I just port it from #4828.
Some other import changes should be noticed is in the rewrite_simplify.cc / canonical_simplify.cc. We introduce expression complexity to determine whether we should do these optimizations. After introducing tflite rounding, we will have complex expressions, like this:

If we don't disable this , we even can not compile whole mobilenet v2 quantized model successfully.
This is also initial support for TFLite bit extract comparison . After this work, our qnn mobilenetv1/v2/inception and so on models we could get bit extract compared with tflite. I also think we have more work to do for more models.
Co-author-by: @Fwd-IV
@anijain2305@mbrookhart@giuseros