Rename GraphRuntime to GraphExecutor - #7653

Merged
tqchen merged 16 commits into
apache:mainfrom
areusch:executor-rename
Mar 30, 2021
Merged

Rename GraphRuntime to GraphExecutor#7653
tqchen merged 16 commits into
apache:mainfrom
areusch:executor-rename

Conversation

@areusch

@areuschareusch commented Mar 12, 2021

Copy link
Copy Markdown
Contributor

This PR implements the "GraphRuntime" part of [RFC] Rename GraphRuntime and ilk to e.g. GraphExecutor. It's quite invasive, so it would be great if everyone could look it over. I think this PR is almost entirely targeted find-replace, as shown by the commit history.

one thing I noticed: @u99127 to look at ARM Compute Lib changes, i'm not sure how you prefer to notate ARM compute lib.

@tqchen@jroesch@junrushao1994@tkonolige@zhiics@manupa-arm@ZihengJiang

@areusch

areusch commented Mar 12, 2021

Copy link
Copy Markdown
ContributorAuthor

µTVM note: you will need to nuke build/standalone_crt after this change.

@u99127

u99127 commented Mar 12, 2021

Copy link
Copy Markdown

@d-smirnov , @lhutton1 , @mbaret : could you please take a look ?

tkonolige
tkonolige reviewed Mar 12, 2021
View reviewed changes
Comment threadCMakeLists.txt Outdated

if(USE_GRAPH_RUNTIME)
if(USE_GRAPH_EXECUTOR)
message(STATUS "Build with Graph runtime support...")

@tkonoligetkonoligeMar 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one

tkonolige
tkonolige reviewed Mar 12, 2021
View reviewed changes
Comment threadCMakeLists.txt Outdated
@@ -326,7 +326,7 @@ if(USE_PROFILER)
file(GLOB RUNTIME_GRAPH_DEBUG_SRCS src/runtime/graph/debug/*.cc)

@tkonoligetkonoligeMar 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed this

@areuschareuschMar 18, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, the var name derives from the path. or do you mean we should fix path to e.g. src/runtime/graph_executor/...?

Comment threaddocs/install/from_source.rst Outdated
- Change ``set(USE_CUDA OFF)`` to ``set(USE_CUDA ON)`` to enable CUDA backend. Do the same for other backends and libraries
you want to build for (OpenCL, RCOM, METAL, VULKAN, ...).
- To help with debugging, ensure the embedded graph runtime and debugging functions are enabled with ``set(USE_GRAPH_RUNTIME ON)`` and ``set(USE_GRAPH_RUNTIME_DEBUG ON)``
- To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_GRAPH_EXECUTOR_DEBUG ON)``

@tkonoligetkonoligeMar 12, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_GRAPH_EXECUTOR_DEBUG ON)``
- To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_PROFILER ON)``

@areuschareuschMar 18, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

zhiics
zhiics reviewed Mar 16, 2021
View reviewed changes

@zhiicszhiics left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably need to create an alias for graph_runtime (if they are all replaced by graph_executor) and remove it in the next release for backward compatibility. We can issue a warning to when graph_runtime is used. Otherwise, I think it would break the downstream deployment once they sync with upstream TVM. Please ignore if you have it already.

@areusch

areusch commented Mar 18, 2021

Copy link
Copy Markdown
ContributorAuthor

@zhiics good call. I added python backwards compatibility for the create API. I don't know whether we are sensitive to backwards compatibility for the other languages. since the rest are compiled, it seems like we may not need a deprecation warning there (but, I am happy to add one, I am just not sure what would be best). I could also see us doing something slightly different than precedent here given the magnitude of the change.

@tqchentqchen added status: need review status: need update need update based on feedbacks labels Mar 18, 2021
@areusch
areuschforce-pushed the executor-rename branch 2 times, most recently from b0ff20a to bc9bab8CompareMarch 19, 2021 15:35
@zhiics

zhiics commented Mar 23, 2021

Copy link
Copy Markdown
Member

@areusch yeah, warning may not be needed. I was just trying to make sure that we don't break all the downstream deployment by letting them know that what is going to happen there.

@areusch

areusch commented Mar 23, 2021

Copy link
Copy Markdown
ContributorAuthor

@zhiics it's definitely a breaking change, i'm not opposed to the warning or some other way to notify downstream users. I don't know if code or forum or other is the best channel for that--i'm inclined to lean towards code in case forum or elsewhere also has snippets that may become outdated. i'm happy to do whatever you propose--which way do you prefer?

@tqchen@jroesch in case they have thoughts

@areusch
areuschforce-pushed the executor-rename branch 2 times, most recently from 50110b3 to 2f10d74CompareMarch 23, 2021 19:26
@tqchen

tqchen commented Mar 23, 2021

Copy link
Copy Markdown
Member

Given we are pre-1.0 we can just do our best effort when backward compact is possible but not necessary have to spend an extra mile of effort. may not hurt to post a notice to forum as well. e.g. https://discuss.tvm.apache.org/t/notice-tvm-runtime-rpc-upgrade-in-pr7488/9237/5

@zhiics

zhiics commented Mar 24, 2021

Copy link
Copy Markdown
Member

@zhiics it's definitely a breaking change, i'm not opposed to the warning or some other way to notify downstream users. I don't know if code or forum or other is the best channel for that--i'm inclined to lean towards code in case forum or elsewhere also has snippets that may become outdated. i'm happy to do whatever you propose--which way do you prefer?

@tqchen@jroesch in case they have thoughts

@areusch Thanks. I also prefer code for the the same reason you mentioned.

@areusch

areusch commented Mar 24, 2021

Copy link
Copy Markdown
ContributorAuthor

@zhiics I've added Python backwards-compat. Please let me know if you think this is adequate. If so, I think we are ready to merge.

cnv1989
cnv1989 reviewed Mar 24, 2021
View reviewed changes
Comment threadapps/android_deploy/app/src/main/java/org/apache/tvm/android/demo/MainActivity.java Outdated
mResultView.setText(label);
}
Log.i(TAG, "prediction finished");
if (null != graphExecutorModule) {

@cnv1989cnv1989Mar 24, 2021•
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the indent size here is 2 while everywhere else its 4?

@areuschareuschMar 24, 2021

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @cnv1989, I had run git-clang-format directly rather than with the script, and it looks like it affected java files. reverted.

@areusch
areuschforce-pushed the executor-rename branch 3 times, most recently from 3ce0117 to f5b48b6CompareMarch 25, 2021 00:00
zhiics
zhiics reviewed Mar 25, 2021
View reviewed changes

@zhiicszhiics left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @yzhliu@jroesch@tqchen please also take a look since there are language binding changes as well.

@areusch

areusch commented Mar 26, 2021

Copy link
Copy Markdown
ContributorAuthor

@yzhliu@jroesch@tqchen would be great if we can merge this soon as it's easy for this PR to run in to merge conflicts.

@tqchen

tqchen commented Mar 26, 2021

Copy link
Copy Markdown
Member

oops. sorry there is a merge conflict due to another renaming PR. @areusch can you rebase. will prioritize merging this

@areusch
areuschforce-pushed the executor-rename branch 2 times, most recently from 2bf1d69 to a269414CompareMarch 28, 2021 16:46
@tqchen
tqchen merged commit 9b43a64 into apache:mainMar 30, 2021
@tqchentqchen added status: accepted and removed status: need review status: need update need update based on feedbacks labels Mar 30, 2021
@areuschareusch mentioned this pull request Apr 16, 2021
Merged
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
3152778
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
5c4c73e
Fix graph runtime -> graph executor
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
28f9c45
Fix graph runtime -> graph executor
lint
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request May 11, 2021
Andrew Reusch@trevor-m
Rename GraphRuntime to GraphExecutor (apache#7653)
e94b6e7
Fix graph runtime -> graph executor
lint
@dvhgdvhg mentioned this pull request Jun 8, 2021
Merged
@akmaruakmaru mentioned this pull request Jun 9, 2021
Merged
@areuschareusch mentioned this pull request Jun 17, 2021
Merged
Lunderberg added a commit to Lunderberg/tvm-vta that referenced this pull request Aug 13, 2021
@Lunderberg
Renamed graph_runtime references to graph_executor.
06c911e
Following TVM's rename in apache/tvm#7653,
update to avoid errors when tvm.contrib.graph_runtime is removed
entirely.
@LunderbergLunderberg mentioned this pull request Aug 13, 2021
Merged
tmoreau89 pushed a commit to apache/tvm-vta that referenced this pull request Aug 19, 2021
@Lunderberg
Renamed graph_runtime references to graph_executor. (#31)
4f7d249
Following TVM's rename in apache/tvm#7653,
update to avoid errors when tvm.contrib.graph_runtime is removed
entirely.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tkonoligetkonoligetkonolige left review comments
@zhiicszhiicszhiics approved these changes
+1 more reviewer
@cnv1989cnv1989cnv1989 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

status: accepted

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@areusch@u99127@zhiics@tqchen@cnv1989@tkonolige
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Rename GraphRuntime to GraphExecutor - #7653
Merged
tqchen merged 16 commits into
apache:mainfrom 
areusch:executor-rename
Mar 30, 2021
Merged
Rename GraphRuntime to GraphExecutor#7653
tqchen merged 16 commits into
apache:mainfrom 
areusch:executor-rename
Conversation
@areusch
@areuschareusch
commented
Mar 12, 2021

Copy link


Copy Markdown

Contributor
This PR implements the "GraphRuntime" part of [RFC] Rename GraphRuntime and ilk to e.g. GraphExecutor. It's quite invasive, so it would be great if everyone could look it over. I think this PR is almost entirely targeted find-replace, as shown by the commit history.
one thing I noticed: @u99127 to look at ARM Compute Lib changes, i'm not sure how you prefer to notate ARM compute lib.
@tqchen@jroesch@junrushao1994@tkonolige@zhiics@manupa-arm@ZihengJiang
@areusch
areusch
commented
Mar 12, 2021

Copy link


Copy Markdown

ContributorAuthor
µTVM note: you will need to nuke build/standalone_crt after this change.
@u99127
u99127
commented
Mar 12, 2021

Copy link


Copy Markdown

@d-smirnov , @lhutton1 , @mbaret : could you please take a look ?
tkonolige
tkonolige
reviewed
Mar 12, 2021
View reviewed changes
Comment threadCMakeLists.txt
Outdated


if(USE_GRAPH_RUNTIME)
if(USE_GRAPH_EXECUTOR)
 message(STATUS "Build with Graph runtime support...")
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one
tkonolige
tkonolige
reviewed
Mar 12, 2021
View reviewed changes
Comment threadCMakeLists.txt
Outdated

@@ -326,7 +326,7 @@ if(USE_PROFILER)
 file(GLOB RUNTIME_GRAPH_DEBUG_SRCS src/runtime/graph/debug/*.cc)
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed this
@areuschareuschMar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, the var name derives from the path. or do you mean we should fix path to e.g. src/runtime/graph_executor/...?
Comment threaddocs/install/from_source.rst
Outdated

 - Change ``set(USE_CUDA OFF)`` to ``set(USE_CUDA ON)`` to enable CUDA backend. Do the same for other backends and libraries
 you want to build for (OpenCL, RCOM, METAL, VULKAN, ...).
 - To help with debugging, ensure the embedded graph runtime and debugging functions are enabled with ``set(USE_GRAPH_RUNTIME ON)`` and ``set(USE_GRAPH_RUNTIME_DEBUG ON)``
 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_GRAPH_EXECUTOR_DEBUG ON)``
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_GRAPH_EXECUTOR_DEBUG ON)``
 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_PROFILER ON)``
@areuschareuschMar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
zhiics
zhiics
reviewed
Mar 16, 2021
View reviewed changes
@zhiicszhiics
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably need to create an alias for graph_runtime (if they are all replaced by graph_executor) and remove it in the next release for backward compatibility. We can issue a warning to when graph_runtime is used. Otherwise, I think it would break the downstream deployment once they sync with upstream TVM. Please ignore if you have it already.
@areusch
areusch
commented
Mar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics good call. I added python backwards compatibility for the create API. I don't know whether we are sensitive to backwards compatibility for the other languages. since the rest are compiled, it seems like we may not need a deprecation warning there (but, I am happy to add one, I am just not sure what would be best). I could also see us doing something slightly different than precedent here given the magnitude of the change.
@tqchentqchen
added

status: need review

status: need update
need update based on feedbacks
labels
Mar 18, 2021
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
b0ff20a to
bc9bab8CompareMarch 19, 2021 15:35
@zhiics
zhiics
commented
Mar 23, 2021

Copy link


Copy Markdown

Member
@areusch yeah, warning may not be needed. I was just trying to make sure that we don't break all the downstream deployment by letting them know that what is going to happen there.
@areusch
areusch
commented
Mar 23, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics it's definitely a breaking change, i'm not opposed to the warning or some other way to notify downstream users. I don't know if code or forum or other is the best channel for that--i'm inclined to lean towards code in case forum or elsewhere also has snippets that may become outdated. i'm happy to do whatever you propose--which way do you prefer?
@tqchen@jroesch in case they have thoughts
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
50110b3 to
2f10d74CompareMarch 23, 2021 19:26
@tqchen
tqchen
commented
Mar 23, 2021

Copy link


Copy Markdown

Member
Given we are pre-1.0 we can just do our best effort when backward compact is possible but not necessary have to spend an extra mile of effort. may not hurt to post a notice to forum as well. e.g. https://discuss.tvm.apache.org/t/notice-tvm-runtime-rpc-upgrade-in-pr7488/9237/5
@zhiics
zhiics
commented
Mar 24, 2021

Copy link


Copy Markdown

Member
@zhiics it's definitely a breaking change, i'm not opposed to the warning or some other way to notify downstream users. I don't know if code or forum or other is the best channel for that--i'm inclined to lean towards code in case forum or elsewhere also has snippets that may become outdated. i'm happy to do whatever you propose--which way do you prefer?
@tqchen@jroesch in case they have thoughts
@areusch Thanks. I also prefer code for the the same reason you mentioned.
@areusch
areusch
commented
Mar 24, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics I've added Python backwards-compat. Please let me know if you think this is adequate. If so, I think we are ready to merge.
cnv1989
cnv1989
reviewed
Mar 24, 2021
View reviewed changes
Comment threadapps/android_deploy/app/src/main/java/org/apache/tvm/android/demo/MainActivity.java
Outdated

 mResultView.setText(label);
 }
 Log.i(TAG, "prediction finished");
 if (null != graphExecutorModule) {
@cnv1989cnv1989Mar 24, 2021•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the indent size here is 2 while everywhere else its 4?
@areuschareuschMar 24, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @cnv1989, I had run git-clang-format directly rather than with the script, and it looks like it affected java files. reverted.
@areusch
areuschforce-pushed
the
executor-rename
branch
3 times, most recently
from
3ce0117 to
f5b48b6CompareMarch 25, 2021 00:00
zhiics
zhiics
reviewed
Mar 25, 2021
View reviewed changes
@zhiicszhiics
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @yzhliu@jroesch@tqchen please also take a look since there are language binding changes as well.
@areusch
areusch
commented
Mar 26, 2021

Copy link


Copy Markdown

ContributorAuthor
@yzhliu@jroesch@tqchen would be great if we can merge this soon as it's easy for this PR to run in to merge conflicts.
@tqchen
tqchen
commented
Mar 26, 2021

Copy link


Copy Markdown

Member
oops. sorry there is a merge conflict due to another renaming PR. @areusch can you rebase. will prioritize merging this
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
2bf1d69 to
a269414CompareMarch 28, 2021 16:46
@tqchen
tqchen
merged commit 9b43a64
into
apache:mainMar 30, 2021
@tqchentqchen
added

status: accepted

and removed

status: need review

status: need update
need update based on feedbacks
labels
Mar 30, 2021
@areuschareusch
mentioned this pull request
Apr 16, 2021
 Merged

trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
3152778
trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
5c4c73e
Fix graph runtime -> graph executor
trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
28f9c45
Fix graph runtime -> graph executor
lint
trevor-m pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
Andrew Reusch@trevor-m
Rename GraphRuntime to GraphExecutor (apache#7653)
e94b6e7
Fix graph runtime -> graph executor
lint
@dvhgdvhg
mentioned this pull request
Jun 8, 2021
 Merged

@akmaruakmaru
mentioned this pull request
Jun 9, 2021
 Merged

@areuschareusch
mentioned this pull request
Jun 17, 2021
 Merged

Lunderberg added a commit
to Lunderberg/tvm-vta
that referenced
this pull request
Aug 13, 2021
@Lunderberg
Renamed graph_runtime references to graph_executor.
06c911e
Following TVM's rename in apache/tvm#7653,
update to avoid errors when tvm.contrib.graph_runtime is removed
entirely.
@LunderbergLunderberg
mentioned this pull request
Aug 13, 2021
 Merged

tmoreau89 pushed a commit
to apache/tvm-vta
that referenced
this pull request
Aug 19, 2021
@Lunderberg
Renamed graph_runtime references to graph_executor. (#31)
4f7d249
Following TVM's rename in apache/tvm#7653,
update to avoid errors when tvm.contrib.graph_runtime is removed
entirely.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tkonoligetkonoligetkonolige left review comments
@zhiicszhiicszhiics approved these changes

+1 more reviewer

@cnv1989cnv1989cnv1989 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

status: accepted

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@areusch@u99127@zhiics@tqchen@cnv1989@tkonolige

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rename GraphRuntime to GraphExecutor - #7653
Merged
tqchen merged 16 commits into
apache:mainfrom 
areusch:executor-rename
Mar 30, 2021
Merged
Rename GraphRuntime to GraphExecutor#7653
tqchen merged 16 commits into
apache:mainfrom 
areusch:executor-rename
Conversation
@areusch
@areuschareusch
commented
Mar 12, 2021

Copy link


Copy Markdown

Contributor
This PR implements the "GraphRuntime" part of [RFC] Rename GraphRuntime and ilk to e.g. GraphExecutor. It's quite invasive, so it would be great if everyone could look it over. I think this PR is almost entirely targeted find-replace, as shown by the commit history.
one thing I noticed: @u99127 to look at ARM Compute Lib changes, i'm not sure how you prefer to notate ARM compute lib.
@tqchen@jroesch@junrushao1994@tkonolige@zhiics@manupa-arm@ZihengJiang
@areusch
areusch
commented
Mar 12, 2021

Copy link


Copy Markdown

ContributorAuthor
µTVM note: you will need to nuke build/standalone_crt after this change.
@u99127
u99127
commented
Mar 12, 2021

Copy link


Copy Markdown

@d-smirnov , @lhutton1 , @mbaret : could you please take a look ?
tkonolige
tkonolige
reviewed
Mar 12, 2021
View reviewed changes
Comment threadCMakeLists.txt
Outdated


if(USE_GRAPH_RUNTIME)
if(USE_GRAPH_EXECUTOR)
 message(STATUS "Build with Graph runtime support...")
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one
tkonolige
tkonolige
reviewed
Mar 12, 2021
View reviewed changes
Comment threadCMakeLists.txt
Outdated

@@ -326,7 +326,7 @@ if(USE_PROFILER)
 file(GLOB RUNTIME_GRAPH_DEBUG_SRCS src/runtime/graph/debug/*.cc)
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed this
@areuschareuschMar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, the var name derives from the path. or do you mean we should fix path to e.g. src/runtime/graph_executor/...?
Comment threaddocs/install/from_source.rst
Outdated

 - Change ``set(USE_CUDA OFF)`` to ``set(USE_CUDA ON)`` to enable CUDA backend. Do the same for other backends and libraries
 you want to build for (OpenCL, RCOM, METAL, VULKAN, ...).
 - To help with debugging, ensure the embedded graph runtime and debugging functions are enabled with ``set(USE_GRAPH_RUNTIME ON)`` and ``set(USE_GRAPH_RUNTIME_DEBUG ON)``
 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_GRAPH_EXECUTOR_DEBUG ON)``
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_GRAPH_EXECUTOR_DEBUG ON)``
 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_PROFILER ON)``
@areuschareuschMar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
zhiics
zhiics
reviewed
Mar 16, 2021
View reviewed changes
@zhiicszhiics
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably need to create an alias for graph_runtime (if they are all replaced by graph_executor) and remove it in the next release for backward compatibility. We can issue a warning to when graph_runtime is used. Otherwise, I think it would break the downstream deployment once they sync with upstream TVM. Please ignore if you have it already.
@areusch
areusch
commented
Mar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics good call. I added python backwards compatibility for the create API. I don't know whether we are sensitive to backwards compatibility for the other languages. since the rest are compiled, it seems like we may not need a deprecation warning there (but, I am happy to add one, I am just not sure what would be best). I could also see us doing something slightly different than precedent here given the magnitude of the change.
@tqchentqchen
added

status: need review

status: need update
need update based on feedbacks
labels
Mar 18, 2021
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
b0ff20a to
bc9bab8CompareMarch 19, 2021 15:35
@zhiics
zhiics
commented
Mar 23, 2021

Copy link


Copy Markdown

Member
@areusch yeah, warning may not be needed. I was just trying to make sure that we don't break all the downstream deployment by letting them know that what is going to happen there.
@areusch
areusch
commented
Mar 23, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics it's definitely a breaking change, i'm not opposed to the warning or some other way to notify downstream users. I don't know if code or forum or other is the best channel for that--i'm inclined to lean towards code in case forum or elsewhere also has snippets that may become outdated. i'm happy to do whatever you propose--which way do you prefer?
@tqchen@jroesch in case they have thoughts
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
50110b3 to
2f10d74CompareMarch 23, 2021 19:26
@tqchen
tqchen
commented
Mar 23, 2021

Copy link


Copy Markdown

Member
Given we are pre-1.0 we can just do our best effort when backward compact is possible but not necessary have to spend an extra mile of effort. may not hurt to post a notice to forum as well. e.g. https://discuss.tvm.apache.org/t/notice-tvm-runtime-rpc-upgrade-in-pr7488/9237/5
@zhiics
zhiics
commented
Mar 24, 2021

Copy link


Copy Markdown

Member
@zhiics it's definitely a breaking change, i'm not opposed to the warning or some other way to notify downstream users. I don't know if code or forum or other is the best channel for that--i'm inclined to lean towards code in case forum or elsewhere also has snippets that may become outdated. i'm happy to do whatever you propose--which way do you prefer?
@tqchen@jroesch in case they have thoughts
@areusch Thanks. I also prefer code for the the same reason you mentioned.
@areusch
areusch
commented
Mar 24, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics I've added Python backwards-compat. Please let me know if you think this is adequate. If so, I think we are ready to merge.
cnv1989
cnv1989
reviewed
Mar 24, 2021
View reviewed changes
Comment threadapps/android_deploy/app/src/main/java/org/apache/tvm/android/demo/MainActivity.java
Outdated

 mResultView.setText(label);
 }
 Log.i(TAG, "prediction finished");
 if (null != graphExecutorModule) {
@cnv1989cnv1989Mar 24, 2021•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the indent size here is 2 while everywhere else its 4?
@areuschareuschMar 24, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @cnv1989, I had run git-clang-format directly rather than with the script, and it looks like it affected java files. reverted.
@areusch
areuschforce-pushed
the
executor-rename
branch
3 times, most recently
from
3ce0117 to
f5b48b6CompareMarch 25, 2021 00:00
zhiics
zhiics
reviewed
Mar 25, 2021
View reviewed changes
@zhiicszhiics
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @yzhliu@jroesch@tqchen please also take a look since there are language binding changes as well.
@areusch
areusch
commented
Mar 26, 2021

Copy link


Copy Markdown

ContributorAuthor
@yzhliu@jroesch@tqchen would be great if we can merge this soon as it's easy for this PR to run in to merge conflicts.
@tqchen
tqchen
commented
Mar 26, 2021

Copy link


Copy Markdown

Member
oops. sorry there is a merge conflict due to another renaming PR. @areusch can you rebase. will prioritize merging this
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
2bf1d69 to
a269414CompareMarch 28, 2021 16:46
@tqchen
tqchen
merged commit 9b43a64
into
apache:mainMar 30, 2021
@tqchentqchen
added

status: accepted

and removed

status: need review

status: need update
need update based on feedbacks
labels
Mar 30, 2021
@areuschareusch
mentioned this pull request
Apr 16, 2021
 Merged

trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
3152778
trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
5c4c73e
Fix graph runtime -> graph executor
trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
28f9c45
Fix graph runtime -> graph executor
lint
trevor-m pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
Andrew Reusch@trevor-m
Rename GraphRuntime to GraphExecutor (apache#7653)
e94b6e7
Fix graph runtime -> graph executor
lint
@dvhgdvhg
mentioned this pull request
Jun 8, 2021
 Merged

@akmaruakmaru
mentioned this pull request
Jun 9, 2021
 Merged

@areuschareusch
mentioned this pull request
Jun 17, 2021
 Merged

Lunderberg added a commit
to Lunderberg/tvm-vta
that referenced
this pull request
Aug 13, 2021
@Lunderberg
Renamed graph_runtime references to graph_executor.
06c911e
Following TVM's rename in apache/tvm#7653,
update to avoid errors when tvm.contrib.graph_runtime is removed
entirely.
@LunderbergLunderberg
mentioned this pull request
Aug 13, 2021
 Merged

tmoreau89 pushed a commit
to apache/tvm-vta
that referenced
this pull request
Aug 19, 2021
@Lunderberg
Renamed graph_runtime references to graph_executor. (#31)
4f7d249
Following TVM's rename in apache/tvm#7653,
update to avoid errors when tvm.contrib.graph_runtime is removed
entirely.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tkonoligetkonoligetkonolige left review comments
@zhiicszhiicszhiics approved these changes

+1 more reviewer

@cnv1989cnv1989cnv1989 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

status: accepted

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@areusch@u99127@zhiics@tqchen@cnv1989@tkonolige

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rename GraphRuntime to GraphExecutor - #7653
Merged
tqchen merged 16 commits into
apache:mainfrom 
areusch:executor-rename
Mar 30, 2021
Merged
Rename GraphRuntime to GraphExecutor#7653
tqchen merged 16 commits into
apache:mainfrom 
areusch:executor-rename
Conversation
@areusch
@areuschareusch
commented
Mar 12, 2021

Copy link


Copy Markdown

Contributor
This PR implements the "GraphRuntime" part of [RFC] Rename GraphRuntime and ilk to e.g. GraphExecutor. It's quite invasive, so it would be great if everyone could look it over. I think this PR is almost entirely targeted find-replace, as shown by the commit history.
one thing I noticed: @u99127 to look at ARM Compute Lib changes, i'm not sure how you prefer to notate ARM compute lib.
@tqchen@jroesch@junrushao1994@tkonolige@zhiics@manupa-arm@ZihengJiang
@areusch
areusch
commented
Mar 12, 2021

Copy link


Copy Markdown

ContributorAuthor
µTVM note: you will need to nuke build/standalone_crt after this change.
@u99127
u99127
commented
Mar 12, 2021

Copy link


Copy Markdown

@d-smirnov , @lhutton1 , @mbaret : could you please take a look ?
tkonolige
tkonolige
reviewed
Mar 12, 2021
View reviewed changes
Comment threadCMakeLists.txt
Outdated


if(USE_GRAPH_RUNTIME)
if(USE_GRAPH_EXECUTOR)
 message(STATUS "Build with Graph runtime support...")
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one
tkonolige
tkonolige
reviewed
Mar 12, 2021
View reviewed changes
Comment threadCMakeLists.txt
Outdated

@@ -326,7 +326,7 @@ if(USE_PROFILER)
 file(GLOB RUNTIME_GRAPH_DEBUG_SRCS src/runtime/graph/debug/*.cc)
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed this
@areuschareuschMar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, the var name derives from the path. or do you mean we should fix path to e.g. src/runtime/graph_executor/...?
Comment threaddocs/install/from_source.rst
Outdated

 - Change ``set(USE_CUDA OFF)`` to ``set(USE_CUDA ON)`` to enable CUDA backend. Do the same for other backends and libraries
 you want to build for (OpenCL, RCOM, METAL, VULKAN, ...).
 - To help with debugging, ensure the embedded graph runtime and debugging functions are enabled with ``set(USE_GRAPH_RUNTIME ON)`` and ``set(USE_GRAPH_RUNTIME_DEBUG ON)``
 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_GRAPH_EXECUTOR_DEBUG ON)``
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_GRAPH_EXECUTOR_DEBUG ON)``
 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_PROFILER ON)``
@areuschareuschMar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
zhiics
zhiics
reviewed
Mar 16, 2021
View reviewed changes
@zhiicszhiics
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably need to create an alias for graph_runtime (if they are all replaced by graph_executor) and remove it in the next release for backward compatibility. We can issue a warning to when graph_runtime is used. Otherwise, I think it would break the downstream deployment once they sync with upstream TVM. Please ignore if you have it already.
@areusch
areusch
commented
Mar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics good call. I added python backwards compatibility for the create API. I don't know whether we are sensitive to backwards compatibility for the other languages. since the rest are compiled, it seems like we may not need a deprecation warning there (but, I am happy to add one, I am just not sure what would be best). I could also see us doing something slightly different than precedent here given the magnitude of the change.
@tqchentqchen
added

status: need review

status: need update
need update based on feedbacks
labels
Mar 18, 2021
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
b0ff20a to
bc9bab8CompareMarch 19, 2021 15:35
@zhiics
zhiics
commented
Mar 23, 2021

Copy link


Copy Markdown

Member
@areusch yeah, warning may not be needed. I was just trying to make sure that we don't break all the downstream deployment by letting them know that what is going to happen there.
@areusch
areusch
commented
Mar 23, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics it's definitely a breaking change, i'm not opposed to the warning or some other way to notify downstream users. I don't know if code or forum or other is the best channel for that--i'm inclined to lean towards code in case forum or elsewhere also has snippets that may become outdated. i'm happy to do whatever you propose--which way do you prefer?
@tqchen@jroesch in case they have thoughts
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
50110b3 to
2f10d74CompareMarch 23, 2021 19:26
@tqchen
tqchen
commented
Mar 23, 2021

Copy link


Copy Markdown

Member
Given we are pre-1.0 we can just do our best effort when backward compact is possible but not necessary have to spend an extra mile of effort. may not hurt to post a notice to forum as well. e.g. https://discuss.tvm.apache.org/t/notice-tvm-runtime-rpc-upgrade-in-pr7488/9237/5
@zhiics
zhiics
commented
Mar 24, 2021

Copy link


Copy Markdown

Member
@zhiics it's definitely a breaking change, i'm not opposed to the warning or some other way to notify downstream users. I don't know if code or forum or other is the best channel for that--i'm inclined to lean towards code in case forum or elsewhere also has snippets that may become outdated. i'm happy to do whatever you propose--which way do you prefer?
@tqchen@jroesch in case they have thoughts
@areusch Thanks. I also prefer code for the the same reason you mentioned.
@areusch
areusch
commented
Mar 24, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics I've added Python backwards-compat. Please let me know if you think this is adequate. If so, I think we are ready to merge.
cnv1989
cnv1989
reviewed
Mar 24, 2021
View reviewed changes
Comment threadapps/android_deploy/app/src/main/java/org/apache/tvm/android/demo/MainActivity.java
Outdated

 mResultView.setText(label);
 }
 Log.i(TAG, "prediction finished");
 if (null != graphExecutorModule) {
@cnv1989cnv1989Mar 24, 2021•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the indent size here is 2 while everywhere else its 4?
@areuschareuschMar 24, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @cnv1989, I had run git-clang-format directly rather than with the script, and it looks like it affected java files. reverted.
@areusch
areuschforce-pushed
the
executor-rename
branch
3 times, most recently
from
3ce0117 to
f5b48b6CompareMarch 25, 2021 00:00
zhiics
zhiics
reviewed
Mar 25, 2021
View reviewed changes
@zhiicszhiics
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @yzhliu@jroesch@tqchen please also take a look since there are language binding changes as well.
@areusch
areusch
commented
Mar 26, 2021

Copy link


Copy Markdown

ContributorAuthor
@yzhliu@jroesch@tqchen would be great if we can merge this soon as it's easy for this PR to run in to merge conflicts.
@tqchen
tqchen
commented
Mar 26, 2021

Copy link


Copy Markdown

Member
oops. sorry there is a merge conflict due to another renaming PR. @areusch can you rebase. will prioritize merging this
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
2bf1d69 to
a269414CompareMarch 28, 2021 16:46
@tqchen
tqchen
merged commit 9b43a64
into
apache:mainMar 30, 2021
@tqchentqchen
added

status: accepted

and removed

status: need review

status: need update
need update based on feedbacks
labels
Mar 30, 2021
@areuschareusch
mentioned this pull request
Apr 16, 2021
 Merged

trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
3152778
trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
5c4c73e
Fix graph runtime -> graph executor
trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
28f9c45
Fix graph runtime -> graph executor
lint
trevor-m pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
Andrew Reusch@trevor-m
Rename GraphRuntime to GraphExecutor (apache#7653)
e94b6e7
Fix graph runtime -> graph executor
lint
@dvhgdvhg
mentioned this pull request
Jun 8, 2021
 Merged

@akmaruakmaru
mentioned this pull request
Jun 9, 2021
 Merged

@areuschareusch
mentioned this pull request
Jun 17, 2021
 Merged

Lunderberg added a commit
to Lunderberg/tvm-vta
that referenced
this pull request
Aug 13, 2021
@Lunderberg
Renamed graph_runtime references to graph_executor.
06c911e
Following TVM's rename in apache/tvm#7653,
update to avoid errors when tvm.contrib.graph_runtime is removed
entirely.
@LunderbergLunderberg
mentioned this pull request
Aug 13, 2021
 Merged

tmoreau89 pushed a commit
to apache/tvm-vta
that referenced
this pull request
Aug 19, 2021
@Lunderberg
Renamed graph_runtime references to graph_executor. (#31)
4f7d249
Following TVM's rename in apache/tvm#7653,
update to avoid errors when tvm.contrib.graph_runtime is removed
entirely.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tkonoligetkonoligetkonolige left review comments
@zhiicszhiicszhiics approved these changes

+1 more reviewer

@cnv1989cnv1989cnv1989 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

status: accepted

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@areusch@u99127@zhiics@tqchen@cnv1989@tkonolige

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Rename GraphRuntime to GraphExecutor - #7653
Merged
tqchen merged 16 commits into
apache:mainfrom 
areusch:executor-rename
Mar 30, 2021
Merged
Rename GraphRuntime to GraphExecutor#7653
tqchen merged 16 commits into
apache:mainfrom 
areusch:executor-rename
Conversation
@areusch
@areuschareusch
commented
Mar 12, 2021

Copy link


Copy Markdown

Contributor
This PR implements the "GraphRuntime" part of [RFC] Rename GraphRuntime and ilk to e.g. GraphExecutor. It's quite invasive, so it would be great if everyone could look it over. I think this PR is almost entirely targeted find-replace, as shown by the commit history.
one thing I noticed: @u99127 to look at ARM Compute Lib changes, i'm not sure how you prefer to notate ARM compute lib.
@tqchen@jroesch@junrushao1994@tkonolige@zhiics@manupa-arm@ZihengJiang
@areusch
areusch
commented
Mar 12, 2021

Copy link


Copy Markdown

ContributorAuthor
µTVM note: you will need to nuke build/standalone_crt after this change.
@u99127
u99127
commented
Mar 12, 2021

Copy link


Copy Markdown

@d-smirnov , @lhutton1 , @mbaret : could you please take a look ?
tkonolige
tkonolige
reviewed
Mar 12, 2021
View reviewed changes
Comment threadCMakeLists.txt
Outdated


if(USE_GRAPH_RUNTIME)
if(USE_GRAPH_EXECUTOR)
 message(STATUS "Build with Graph runtime support...")
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one
tkonolige
tkonolige
reviewed
Mar 12, 2021
View reviewed changes
Comment threadCMakeLists.txt
Outdated

@@ -326,7 +326,7 @@ if(USE_PROFILER)
 file(GLOB RUNTIME_GRAPH_DEBUG_SRCS src/runtime/graph/debug/*.cc)
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed this
@areuschareuschMar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, the var name derives from the path. or do you mean we should fix path to e.g. src/runtime/graph_executor/...?
Comment threaddocs/install/from_source.rst
Outdated

 - Change ``set(USE_CUDA OFF)`` to ``set(USE_CUDA ON)`` to enable CUDA backend. Do the same for other backends and libraries
 you want to build for (OpenCL, RCOM, METAL, VULKAN, ...).
 - To help with debugging, ensure the embedded graph runtime and debugging functions are enabled with ``set(USE_GRAPH_RUNTIME ON)`` and ``set(USE_GRAPH_RUNTIME_DEBUG ON)``
 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_GRAPH_EXECUTOR_DEBUG ON)``
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_GRAPH_EXECUTOR_DEBUG ON)``
 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_PROFILER ON)``
@areuschareuschMar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
zhiics
zhiics
reviewed
Mar 16, 2021
View reviewed changes
@zhiicszhiics
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably need to create an alias for graph_runtime (if they are all replaced by graph_executor) and remove it in the next release for backward compatibility. We can issue a warning to when graph_runtime is used. Otherwise, I think it would break the downstream deployment once they sync with upstream TVM. Please ignore if you have it already.
@areusch
areusch
commented
Mar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics good call. I added python backwards compatibility for the create API. I don't know whether we are sensitive to backwards compatibility for the other languages. since the rest are compiled, it seems like we may not need a deprecation warning there (but, I am happy to add one, I am just not sure what would be best). I could also see us doing something slightly different than precedent here given the magnitude of the change.
@tqchentqchen
added

status: need review

status: need update
need update based on feedbacks
labels
Mar 18, 2021
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
b0ff20a to
bc9bab8CompareMarch 19, 2021 15:35
@zhiics
zhiics
commented
Mar 23, 2021

Copy link


Copy Markdown

Member
@areusch yeah, warning may not be needed. I was just trying to make sure that we don't break all the downstream deployment by letting them know that what is going to happen there.
@areusch
areusch
commented
Mar 23, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics it's definitely a breaking change, i'm not opposed to the warning or some other way to notify downstream users. I don't know if code or forum or other is the best channel for that--i'm inclined to lean towards code in case forum or elsewhere also has snippets that may become outdated. i'm happy to do whatever you propose--which way do you prefer?
@tqchen@jroesch in case they have thoughts
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
50110b3 to
2f10d74CompareMarch 23, 2021 19:26
@tqchen
tqchen
commented
Mar 23, 2021

Copy link


Copy Markdown

Member
Given we are pre-1.0 we can just do our best effort when backward compact is possible but not necessary have to spend an extra mile of effort. may not hurt to post a notice to forum as well. e.g. https://discuss.tvm.apache.org/t/notice-tvm-runtime-rpc-upgrade-in-pr7488/9237/5
@zhiics
zhiics
commented
Mar 24, 2021

Copy link


Copy Markdown

Member
@zhiics it's definitely a breaking change, i'm not opposed to the warning or some other way to notify downstream users. I don't know if code or forum or other is the best channel for that--i'm inclined to lean towards code in case forum or elsewhere also has snippets that may become outdated. i'm happy to do whatever you propose--which way do you prefer?
@tqchen@jroesch in case they have thoughts
@areusch Thanks. I also prefer code for the the same reason you mentioned.
@areusch
areusch
commented
Mar 24, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics I've added Python backwards-compat. Please let me know if you think this is adequate. If so, I think we are ready to merge.
cnv1989
cnv1989
reviewed
Mar 24, 2021
View reviewed changes
Comment threadapps/android_deploy/app/src/main/java/org/apache/tvm/android/demo/MainActivity.java
Outdated

 mResultView.setText(label);
 }
 Log.i(TAG, "prediction finished");
 if (null != graphExecutorModule) {
@cnv1989cnv1989Mar 24, 2021•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the indent size here is 2 while everywhere else its 4?
@areuschareuschMar 24, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @cnv1989, I had run git-clang-format directly rather than with the script, and it looks like it affected java files. reverted.
@areusch
areuschforce-pushed
the
executor-rename
branch
3 times, most recently
from
3ce0117 to
f5b48b6CompareMarch 25, 2021 00:00
zhiics
zhiics
reviewed
Mar 25, 2021
View reviewed changes
@zhiicszhiics
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @yzhliu@jroesch@tqchen please also take a look since there are language binding changes as well.
@areusch
areusch
commented
Mar 26, 2021

Copy link


Copy Markdown

ContributorAuthor
@yzhliu@jroesch@tqchen would be great if we can merge this soon as it's easy for this PR to run in to merge conflicts.
@tqchen
tqchen
commented
Mar 26, 2021

Copy link


Copy Markdown

Member
oops. sorry there is a merge conflict due to another renaming PR. @areusch can you rebase. will prioritize merging this
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
2bf1d69 to
a269414CompareMarch 28, 2021 16:46
@tqchen
tqchen
merged commit 9b43a64
into
apache:mainMar 30, 2021
@tqchentqchen
added

status: accepted

and removed

status: need review

status: need update
need update based on feedbacks
labels
Mar 30, 2021
@areuschareusch
mentioned this pull request
Apr 16, 2021
 Merged

trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
3152778
trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
5c4c73e
Fix graph runtime -> graph executor
trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
28f9c45
Fix graph runtime -> graph executor
lint
trevor-m pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
Andrew Reusch@trevor-m
Rename GraphRuntime to GraphExecutor (apache#7653)
e94b6e7
Fix graph runtime -> graph executor
lint
@dvhgdvhg
mentioned this pull request
Jun 8, 2021
 Merged

@akmaruakmaru
mentioned this pull request
Jun 9, 2021
 Merged

@areuschareusch
mentioned this pull request
Jun 17, 2021
 Merged

Lunderberg added a commit
to Lunderberg/tvm-vta
that referenced
this pull request
Aug 13, 2021
@Lunderberg
Renamed graph_runtime references to graph_executor.
06c911e
Following TVM's rename in apache/tvm#7653,
update to avoid errors when tvm.contrib.graph_runtime is removed
entirely.
@LunderbergLunderberg
mentioned this pull request
Aug 13, 2021
 Merged

tmoreau89 pushed a commit
to apache/tvm-vta
that referenced
this pull request
Aug 19, 2021
@Lunderberg
Renamed graph_runtime references to graph_executor. (#31)
4f7d249
Following TVM's rename in apache/tvm#7653,
update to avoid errors when tvm.contrib.graph_runtime is removed
entirely.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tkonoligetkonoligetkonolige left review comments
@zhiicszhiicszhiics approved these changes

+1 more reviewer

@cnv1989cnv1989cnv1989 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

status: accepted

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@areusch@u99127@zhiics@tqchen@cnv1989@tkonolige

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rename GraphRuntime to GraphExecutor - #7653
Merged
tqchen merged 16 commits into
apache:mainfrom 
areusch:executor-rename
Mar 30, 2021
Merged
Rename GraphRuntime to GraphExecutor#7653
tqchen merged 16 commits into
apache:mainfrom 
areusch:executor-rename
Conversation
@areusch
@areuschareusch
commented
Mar 12, 2021

Copy link


Copy Markdown

Contributor
This PR implements the "GraphRuntime" part of [RFC] Rename GraphRuntime and ilk to e.g. GraphExecutor. It's quite invasive, so it would be great if everyone could look it over. I think this PR is almost entirely targeted find-replace, as shown by the commit history.
one thing I noticed: @u99127 to look at ARM Compute Lib changes, i'm not sure how you prefer to notate ARM compute lib.
@tqchen@jroesch@junrushao1994@tkonolige@zhiics@manupa-arm@ZihengJiang
@areusch
areusch
commented
Mar 12, 2021

Copy link


Copy Markdown

ContributorAuthor
µTVM note: you will need to nuke build/standalone_crt after this change.
@u99127
u99127
commented
Mar 12, 2021

Copy link


Copy Markdown

@d-smirnov , @lhutton1 , @mbaret : could you please take a look ?
tkonolige
tkonolige
reviewed
Mar 12, 2021
View reviewed changes
Comment threadCMakeLists.txt
Outdated


if(USE_GRAPH_RUNTIME)
if(USE_GRAPH_EXECUTOR)
 message(STATUS "Build with Graph runtime support...")
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one
tkonolige
tkonolige
reviewed
Mar 12, 2021
View reviewed changes
Comment threadCMakeLists.txt
Outdated

@@ -326,7 +326,7 @@ if(USE_PROFILER)
 file(GLOB RUNTIME_GRAPH_DEBUG_SRCS src/runtime/graph/debug/*.cc)
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed this
@areuschareuschMar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, the var name derives from the path. or do you mean we should fix path to e.g. src/runtime/graph_executor/...?
Comment threaddocs/install/from_source.rst
Outdated

 - Change ``set(USE_CUDA OFF)`` to ``set(USE_CUDA ON)`` to enable CUDA backend. Do the same for other backends and libraries
 you want to build for (OpenCL, RCOM, METAL, VULKAN, ...).
 - To help with debugging, ensure the embedded graph runtime and debugging functions are enabled with ``set(USE_GRAPH_RUNTIME ON)`` and ``set(USE_GRAPH_RUNTIME_DEBUG ON)``
 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_GRAPH_EXECUTOR_DEBUG ON)``
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_GRAPH_EXECUTOR_DEBUG ON)``
 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_PROFILER ON)``
@areuschareuschMar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
zhiics
zhiics
reviewed
Mar 16, 2021
View reviewed changes
@zhiicszhiics
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably need to create an alias for graph_runtime (if they are all replaced by graph_executor) and remove it in the next release for backward compatibility. We can issue a warning to when graph_runtime is used. Otherwise, I think it would break the downstream deployment once they sync with upstream TVM. Please ignore if you have it already.
@areusch
areusch
commented
Mar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics good call. I added python backwards compatibility for the create API. I don't know whether we are sensitive to backwards compatibility for the other languages. since the rest are compiled, it seems like we may not need a deprecation warning there (but, I am happy to add one, I am just not sure what would be best). I could also see us doing something slightly different than precedent here given the magnitude of the change.
@tqchentqchen
added

status: need review

status: need update
need update based on feedbacks
labels
Mar 18, 2021
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
b0ff20a to
bc9bab8CompareMarch 19, 2021 15:35
@zhiics
zhiics
commented
Mar 23, 2021

Copy link


Copy Markdown

Member
@areusch yeah, warning may not be needed. I was just trying to make sure that we don't break all the downstream deployment by letting them know that what is going to happen there.
@areusch
areusch
commented
Mar 23, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics it's definitely a breaking change, i'm not opposed to the warning or some other way to notify downstream users. I don't know if code or forum or other is the best channel for that--i'm inclined to lean towards code in case forum or elsewhere also has snippets that may become outdated. i'm happy to do whatever you propose--which way do you prefer?
@tqchen@jroesch in case they have thoughts
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
50110b3 to
2f10d74CompareMarch 23, 2021 19:26
@tqchen
tqchen
commented
Mar 23, 2021

Copy link


Copy Markdown

Member
Given we are pre-1.0 we can just do our best effort when backward compact is possible but not necessary have to spend an extra mile of effort. may not hurt to post a notice to forum as well. e.g. https://discuss.tvm.apache.org/t/notice-tvm-runtime-rpc-upgrade-in-pr7488/9237/5
@zhiics
zhiics
commented
Mar 24, 2021

Copy link


Copy Markdown

Member
@zhiics it's definitely a breaking change, i'm not opposed to the warning or some other way to notify downstream users. I don't know if code or forum or other is the best channel for that--i'm inclined to lean towards code in case forum or elsewhere also has snippets that may become outdated. i'm happy to do whatever you propose--which way do you prefer?
@tqchen@jroesch in case they have thoughts
@areusch Thanks. I also prefer code for the the same reason you mentioned.
@areusch
areusch
commented
Mar 24, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics I've added Python backwards-compat. Please let me know if you think this is adequate. If so, I think we are ready to merge.
cnv1989
cnv1989
reviewed
Mar 24, 2021
View reviewed changes
Comment threadapps/android_deploy/app/src/main/java/org/apache/tvm/android/demo/MainActivity.java
Outdated

 mResultView.setText(label);
 }
 Log.i(TAG, "prediction finished");
 if (null != graphExecutorModule) {
@cnv1989cnv1989Mar 24, 2021•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the indent size here is 2 while everywhere else its 4?
@areuschareuschMar 24, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @cnv1989, I had run git-clang-format directly rather than with the script, and it looks like it affected java files. reverted.
@areusch
areuschforce-pushed
the
executor-rename
branch
3 times, most recently
from
3ce0117 to
f5b48b6CompareMarch 25, 2021 00:00
zhiics
zhiics
reviewed
Mar 25, 2021
View reviewed changes
@zhiicszhiics
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @yzhliu@jroesch@tqchen please also take a look since there are language binding changes as well.
@areusch
areusch
commented
Mar 26, 2021

Copy link


Copy Markdown

ContributorAuthor
@yzhliu@jroesch@tqchen would be great if we can merge this soon as it's easy for this PR to run in to merge conflicts.
@tqchen
tqchen
commented
Mar 26, 2021

Copy link


Copy Markdown

Member
oops. sorry there is a merge conflict due to another renaming PR. @areusch can you rebase. will prioritize merging this
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
2bf1d69 to
a269414CompareMarch 28, 2021 16:46
@tqchen
tqchen
merged commit 9b43a64
into
apache:mainMar 30, 2021
@tqchentqchen
added

status: accepted

and removed

status: need review

status: need update
need update based on feedbacks
labels
Mar 30, 2021
@areuschareusch
mentioned this pull request
Apr 16, 2021
 Merged

trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
3152778
trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
5c4c73e
Fix graph runtime -> graph executor
trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
28f9c45
Fix graph runtime -> graph executor
lint
trevor-m pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
Andrew Reusch@trevor-m
Rename GraphRuntime to GraphExecutor (apache#7653)
e94b6e7
Fix graph runtime -> graph executor
lint
@dvhgdvhg
mentioned this pull request
Jun 8, 2021
 Merged

@akmaruakmaru
mentioned this pull request
Jun 9, 2021
 Merged

@areuschareusch
mentioned this pull request
Jun 17, 2021
 Merged

Lunderberg added a commit
to Lunderberg/tvm-vta
that referenced
this pull request
Aug 13, 2021
@Lunderberg
Renamed graph_runtime references to graph_executor.
06c911e
Following TVM's rename in apache/tvm#7653,
update to avoid errors when tvm.contrib.graph_runtime is removed
entirely.
@LunderbergLunderberg
mentioned this pull request
Aug 13, 2021
 Merged

tmoreau89 pushed a commit
to apache/tvm-vta
that referenced
this pull request
Aug 19, 2021
@Lunderberg
Renamed graph_runtime references to graph_executor. (#31)
4f7d249
Following TVM's rename in apache/tvm#7653,
update to avoid errors when tvm.contrib.graph_runtime is removed
entirely.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tkonoligetkonoligetkonolige left review comments
@zhiicszhiicszhiics approved these changes

+1 more reviewer

@cnv1989cnv1989cnv1989 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

status: accepted

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@areusch@u99127@zhiics@tqchen@cnv1989@tkonolige

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Rename GraphRuntime to GraphExecutor - #7653
Merged
tqchen merged 16 commits into
apache:mainfrom 
areusch:executor-rename
Mar 30, 2021
Merged
Rename GraphRuntime to GraphExecutor#7653
tqchen merged 16 commits into
apache:mainfrom 
areusch:executor-rename
Conversation
@areusch
@areuschareusch
commented
Mar 12, 2021

Copy link


Copy Markdown

Contributor
This PR implements the "GraphRuntime" part of [RFC] Rename GraphRuntime and ilk to e.g. GraphExecutor. It's quite invasive, so it would be great if everyone could look it over. I think this PR is almost entirely targeted find-replace, as shown by the commit history.
one thing I noticed: @u99127 to look at ARM Compute Lib changes, i'm not sure how you prefer to notate ARM compute lib.
@tqchen@jroesch@junrushao1994@tkonolige@zhiics@manupa-arm@ZihengJiang
@areusch
areusch
commented
Mar 12, 2021

Copy link


Copy Markdown

ContributorAuthor
µTVM note: you will need to nuke build/standalone_crt after this change.
@u99127
u99127
commented
Mar 12, 2021

Copy link


Copy Markdown

@d-smirnov , @lhutton1 , @mbaret : could you please take a look ?
tkonolige
tkonolige
reviewed
Mar 12, 2021
View reviewed changes
Comment threadCMakeLists.txt
Outdated


if(USE_GRAPH_RUNTIME)
if(USE_GRAPH_EXECUTOR)
 message(STATUS "Build with Graph runtime support...")
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one
tkonolige
tkonolige
reviewed
Mar 12, 2021
View reviewed changes
Comment threadCMakeLists.txt
Outdated

@@ -326,7 +326,7 @@ if(USE_PROFILER)
 file(GLOB RUNTIME_GRAPH_DEBUG_SRCS src/runtime/graph/debug/*.cc)
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed this
@areuschareuschMar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, the var name derives from the path. or do you mean we should fix path to e.g. src/runtime/graph_executor/...?
Comment threaddocs/install/from_source.rst
Outdated

 - Change ``set(USE_CUDA OFF)`` to ``set(USE_CUDA ON)`` to enable CUDA backend. Do the same for other backends and libraries
 you want to build for (OpenCL, RCOM, METAL, VULKAN, ...).
 - To help with debugging, ensure the embedded graph runtime and debugging functions are enabled with ``set(USE_GRAPH_RUNTIME ON)`` and ``set(USE_GRAPH_RUNTIME_DEBUG ON)``
 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_GRAPH_EXECUTOR_DEBUG ON)``
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_GRAPH_EXECUTOR_DEBUG ON)``
 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_PROFILER ON)``
@areuschareuschMar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
zhiics
zhiics
reviewed
Mar 16, 2021
View reviewed changes
@zhiicszhiics
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably need to create an alias for graph_runtime (if they are all replaced by graph_executor) and remove it in the next release for backward compatibility. We can issue a warning to when graph_runtime is used. Otherwise, I think it would break the downstream deployment once they sync with upstream TVM. Please ignore if you have it already.
@areusch
areusch
commented
Mar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics good call. I added python backwards compatibility for the create API. I don't know whether we are sensitive to backwards compatibility for the other languages. since the rest are compiled, it seems like we may not need a deprecation warning there (but, I am happy to add one, I am just not sure what would be best). I could also see us doing something slightly different than precedent here given the magnitude of the change.
@tqchentqchen
added

status: need review

status: need update
need update based on feedbacks
labels
Mar 18, 2021
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
b0ff20a to
bc9bab8CompareMarch 19, 2021 15:35
@zhiics
zhiics
commented
Mar 23, 2021

Copy link


Copy Markdown

Member
@areusch yeah, warning may not be needed. I was just trying to make sure that we don't break all the downstream deployment by letting them know that what is going to happen there.
@areusch
areusch
commented
Mar 23, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics it's definitely a breaking change, i'm not opposed to the warning or some other way to notify downstream users. I don't know if code or forum or other is the best channel for that--i'm inclined to lean towards code in case forum or elsewhere also has snippets that may become outdated. i'm happy to do whatever you propose--which way do you prefer?
@tqchen@jroesch in case they have thoughts
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
50110b3 to
2f10d74CompareMarch 23, 2021 19:26
@tqchen
tqchen
commented
Mar 23, 2021

Copy link


Copy Markdown

Member
Given we are pre-1.0 we can just do our best effort when backward compact is possible but not necessary have to spend an extra mile of effort. may not hurt to post a notice to forum as well. e.g. https://discuss.tvm.apache.org/t/notice-tvm-runtime-rpc-upgrade-in-pr7488/9237/5
@zhiics
zhiics
commented
Mar 24, 2021

Copy link


Copy Markdown

Member
@zhiics it's definitely a breaking change, i'm not opposed to the warning or some other way to notify downstream users. I don't know if code or forum or other is the best channel for that--i'm inclined to lean towards code in case forum or elsewhere also has snippets that may become outdated. i'm happy to do whatever you propose--which way do you prefer?
@tqchen@jroesch in case they have thoughts
@areusch Thanks. I also prefer code for the the same reason you mentioned.
@areusch
areusch
commented
Mar 24, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics I've added Python backwards-compat. Please let me know if you think this is adequate. If so, I think we are ready to merge.
cnv1989
cnv1989
reviewed
Mar 24, 2021
View reviewed changes
Comment threadapps/android_deploy/app/src/main/java/org/apache/tvm/android/demo/MainActivity.java
Outdated

 mResultView.setText(label);
 }
 Log.i(TAG, "prediction finished");
 if (null != graphExecutorModule) {
@cnv1989cnv1989Mar 24, 2021•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the indent size here is 2 while everywhere else its 4?
@areuschareuschMar 24, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @cnv1989, I had run git-clang-format directly rather than with the script, and it looks like it affected java files. reverted.
@areusch
areuschforce-pushed
the
executor-rename
branch
3 times, most recently
from
3ce0117 to
f5b48b6CompareMarch 25, 2021 00:00
zhiics
zhiics
reviewed
Mar 25, 2021
View reviewed changes
@zhiicszhiics
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @yzhliu@jroesch@tqchen please also take a look since there are language binding changes as well.
@areusch
areusch
commented
Mar 26, 2021

Copy link


Copy Markdown

ContributorAuthor
@yzhliu@jroesch@tqchen would be great if we can merge this soon as it's easy for this PR to run in to merge conflicts.
@tqchen
tqchen
commented
Mar 26, 2021

Copy link


Copy Markdown

Member
oops. sorry there is a merge conflict due to another renaming PR. @areusch can you rebase. will prioritize merging this
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
2bf1d69 to
a269414CompareMarch 28, 2021 16:46
@tqchen
tqchen
merged commit 9b43a64
into
apache:mainMar 30, 2021
@tqchentqchen
added

status: accepted

and removed

status: need review

status: need update
need update based on feedbacks
labels
Mar 30, 2021
@areuschareusch
mentioned this pull request
Apr 16, 2021
 Merged

trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
3152778
trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
5c4c73e
Fix graph runtime -> graph executor
trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
28f9c45
Fix graph runtime -> graph executor
lint
trevor-m pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
Andrew Reusch@trevor-m
Rename GraphRuntime to GraphExecutor (apache#7653)
e94b6e7
Fix graph runtime -> graph executor
lint
@dvhgdvhg
mentioned this pull request
Jun 8, 2021
 Merged

@akmaruakmaru
mentioned this pull request
Jun 9, 2021
 Merged

@areuschareusch
mentioned this pull request
Jun 17, 2021
 Merged

Lunderberg added a commit
to Lunderberg/tvm-vta
that referenced
this pull request
Aug 13, 2021
@Lunderberg
Renamed graph_runtime references to graph_executor.
06c911e
Following TVM's rename in apache/tvm#7653,
update to avoid errors when tvm.contrib.graph_runtime is removed
entirely.
@LunderbergLunderberg
mentioned this pull request
Aug 13, 2021
 Merged

tmoreau89 pushed a commit
to apache/tvm-vta
that referenced
this pull request
Aug 19, 2021
@Lunderberg
Renamed graph_runtime references to graph_executor. (#31)
4f7d249
Following TVM's rename in apache/tvm#7653,
update to avoid errors when tvm.contrib.graph_runtime is removed
entirely.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tkonoligetkonoligetkonolige left review comments
@zhiicszhiicszhiics approved these changes

+1 more reviewer

@cnv1989cnv1989cnv1989 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

status: accepted

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@areusch@u99127@zhiics@tqchen@cnv1989@tkonolige

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Rename GraphRuntime to GraphExecutor - #7653
Merged
tqchen merged 16 commits into
apache:mainfrom 
areusch:executor-rename
Mar 30, 2021
Merged
Rename GraphRuntime to GraphExecutor#7653
tqchen merged 16 commits into
apache:mainfrom 
areusch:executor-rename
Conversation
@areusch
@areuschareusch
commented
Mar 12, 2021

Copy link


Copy Markdown

Contributor
This PR implements the "GraphRuntime" part of [RFC] Rename GraphRuntime and ilk to e.g. GraphExecutor. It's quite invasive, so it would be great if everyone could look it over. I think this PR is almost entirely targeted find-replace, as shown by the commit history.
one thing I noticed: @u99127 to look at ARM Compute Lib changes, i'm not sure how you prefer to notate ARM compute lib.
@tqchen@jroesch@junrushao1994@tkonolige@zhiics@manupa-arm@ZihengJiang
@areusch
areusch
commented
Mar 12, 2021

Copy link


Copy Markdown

ContributorAuthor
µTVM note: you will need to nuke build/standalone_crt after this change.
@u99127
u99127
commented
Mar 12, 2021

Copy link


Copy Markdown

@d-smirnov , @lhutton1 , @mbaret : could you please take a look ?
tkonolige
tkonolige
reviewed
Mar 12, 2021
View reviewed changes
Comment threadCMakeLists.txt
Outdated


if(USE_GRAPH_RUNTIME)
if(USE_GRAPH_EXECUTOR)
 message(STATUS "Build with Graph runtime support...")
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missed one
tkonolige
tkonolige
reviewed
Mar 12, 2021
View reviewed changes
Comment threadCMakeLists.txt
Outdated

@@ -326,7 +326,7 @@ if(USE_PROFILER)
 file(GLOB RUNTIME_GRAPH_DEBUG_SRCS src/runtime/graph/debug/*.cc)
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed this
@areuschareuschMar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, the var name derives from the path. or do you mean we should fix path to e.g. src/runtime/graph_executor/...?
Comment threaddocs/install/from_source.rst
Outdated

 - Change ``set(USE_CUDA OFF)`` to ``set(USE_CUDA ON)`` to enable CUDA backend. Do the same for other backends and libraries
 you want to build for (OpenCL, RCOM, METAL, VULKAN, ...).
 - To help with debugging, ensure the embedded graph runtime and debugging functions are enabled with ``set(USE_GRAPH_RUNTIME ON)`` and ``set(USE_GRAPH_RUNTIME_DEBUG ON)``
 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_GRAPH_EXECUTOR_DEBUG ON)``
@tkonoligetkonoligeMar 12, 2021

Copy link


Copy Markdown

Contributor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Suggested change

 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_GRAPH_EXECUTOR_DEBUG ON)``
 - To help with debugging, ensure the embedded graph executor and debugging functions are enabled with ``set(USE_GRAPH_EXECUTOR ON)`` and ``set(USE_PROFILER ON)``
@areuschareuschMar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done
zhiics
zhiics
reviewed
Mar 16, 2021
View reviewed changes
@zhiicszhiics
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably need to create an alias for graph_runtime (if they are all replaced by graph_executor) and remove it in the next release for backward compatibility. We can issue a warning to when graph_runtime is used. Otherwise, I think it would break the downstream deployment once they sync with upstream TVM. Please ignore if you have it already.
@areusch
areusch
commented
Mar 18, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics good call. I added python backwards compatibility for the create API. I don't know whether we are sensitive to backwards compatibility for the other languages. since the rest are compiled, it seems like we may not need a deprecation warning there (but, I am happy to add one, I am just not sure what would be best). I could also see us doing something slightly different than precedent here given the magnitude of the change.
@tqchentqchen
added

status: need review

status: need update
need update based on feedbacks
labels
Mar 18, 2021
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
b0ff20a to
bc9bab8CompareMarch 19, 2021 15:35
@zhiics
zhiics
commented
Mar 23, 2021

Copy link


Copy Markdown

Member
@areusch yeah, warning may not be needed. I was just trying to make sure that we don't break all the downstream deployment by letting them know that what is going to happen there.
@areusch
areusch
commented
Mar 23, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics it's definitely a breaking change, i'm not opposed to the warning or some other way to notify downstream users. I don't know if code or forum or other is the best channel for that--i'm inclined to lean towards code in case forum or elsewhere also has snippets that may become outdated. i'm happy to do whatever you propose--which way do you prefer?
@tqchen@jroesch in case they have thoughts
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
50110b3 to
2f10d74CompareMarch 23, 2021 19:26
@tqchen
tqchen
commented
Mar 23, 2021

Copy link


Copy Markdown

Member
Given we are pre-1.0 we can just do our best effort when backward compact is possible but not necessary have to spend an extra mile of effort. may not hurt to post a notice to forum as well. e.g. https://discuss.tvm.apache.org/t/notice-tvm-runtime-rpc-upgrade-in-pr7488/9237/5
@zhiics
zhiics
commented
Mar 24, 2021

Copy link


Copy Markdown

Member
@zhiics it's definitely a breaking change, i'm not opposed to the warning or some other way to notify downstream users. I don't know if code or forum or other is the best channel for that--i'm inclined to lean towards code in case forum or elsewhere also has snippets that may become outdated. i'm happy to do whatever you propose--which way do you prefer?
@tqchen@jroesch in case they have thoughts
@areusch Thanks. I also prefer code for the the same reason you mentioned.
@areusch
areusch
commented
Mar 24, 2021

Copy link


Copy Markdown

ContributorAuthor
@zhiics I've added Python backwards-compat. Please let me know if you think this is adequate. If so, I think we are ready to merge.
cnv1989
cnv1989
reviewed
Mar 24, 2021
View reviewed changes
Comment threadapps/android_deploy/app/src/main/java/org/apache/tvm/android/demo/MainActivity.java
Outdated

 mResultView.setText(label);
 }
 Log.i(TAG, "prediction finished");
 if (null != graphExecutorModule) {
@cnv1989cnv1989Mar 24, 2021•

edited

Loading

Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is the indent size here is 2 while everywhere else its 4?
@areuschareuschMar 24, 2021

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch @cnv1989, I had run git-clang-format directly rather than with the script, and it looks like it affected java files. reverted.
@areusch
areuschforce-pushed
the
executor-rename
branch
3 times, most recently
from
3ce0117 to
f5b48b6CompareMarch 25, 2021 00:00
zhiics
zhiics
reviewed
Mar 25, 2021
View reviewed changes
@zhiicszhiics
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @yzhliu@jroesch@tqchen please also take a look since there are language binding changes as well.
@areusch
areusch
commented
Mar 26, 2021

Copy link


Copy Markdown

ContributorAuthor
@yzhliu@jroesch@tqchen would be great if we can merge this soon as it's easy for this PR to run in to merge conflicts.
@tqchen
tqchen
commented
Mar 26, 2021

Copy link


Copy Markdown

Member
oops. sorry there is a merge conflict due to another renaming PR. @areusch can you rebase. will prioritize merging this
@areusch
areuschforce-pushed
the
executor-rename
branch
2 times, most recently
from
2bf1d69 to
a269414CompareMarch 28, 2021 16:46
@tqchen
tqchen
merged commit 9b43a64
into
apache:mainMar 30, 2021
@tqchentqchen
added

status: accepted

and removed

status: need review

status: need update
need update based on feedbacks
labels
Mar 30, 2021
@areuschareusch
mentioned this pull request
Apr 16, 2021
 Merged

trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
3152778
trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
5c4c73e
Fix graph runtime -> graph executor
trevor-m pushed a commit
to trevor-m/tvm
that referenced
this pull request
May 6, 2021
Andrew ReuschTrevor Morris
Rename GraphRuntime to GraphExecutor (apache#7653)
28f9c45
Fix graph runtime -> graph executor
lint
trevor-m pushed a commit
to neo-ai/tvm
that referenced
this pull request
May 11, 2021
Andrew Reusch@trevor-m
Rename GraphRuntime to GraphExecutor (apache#7653)
e94b6e7
Fix graph runtime -> graph executor
lint
@dvhgdvhg
mentioned this pull request
Jun 8, 2021
 Merged

@akmaruakmaru
mentioned this pull request
Jun 9, 2021
 Merged

@areuschareusch
mentioned this pull request
Jun 17, 2021
 Merged

Lunderberg added a commit
to Lunderberg/tvm-vta
that referenced
this pull request
Aug 13, 2021
@Lunderberg
Renamed graph_runtime references to graph_executor.
06c911e
Following TVM's rename in apache/tvm#7653,
update to avoid errors when tvm.contrib.graph_runtime is removed
entirely.
@LunderbergLunderberg
mentioned this pull request
Aug 13, 2021
 Merged

tmoreau89 pushed a commit
to apache/tvm-vta
that referenced
this pull request
Aug 19, 2021
@Lunderberg
Renamed graph_runtime references to graph_executor. (#31)
4f7d249
Following TVM's rename in apache/tvm#7653,
update to avoid errors when tvm.contrib.graph_runtime is removed
entirely.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@tkonoligetkonoligetkonolige left review comments
@zhiicszhiicszhiics approved these changes

+1 more reviewer

@cnv1989cnv1989cnv1989 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees


No one assigned


Labels

status: accepted

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

6 participants

@areusch@u99127@zhiics@tqchen@cnv1989@tkonolige