Uh oh!
There was an error while loading. Please reload this page.
[Pass] Simplify consecutive casts in Relay - #8081
Closed
icemelon wants to merge 3 commits into
Closed
Conversation
mbrookhart
commented
Jun 14, 2021
Contributor
@icemelon9 can you rebase? I'm not sure if this hit a flakey test or if there's an issue with mobilenet. |
18 tasks
masahi
commented
Jan 9, 2022
Member
@AndrewZhaoLuo would be great if you can take over this PR. |
AndrewZhaoLuo
commented
Jan 24, 2022
Contributor
@icemelon do you still have interest in merging this PR? If not then I can try to take over. |
AndrewZhaoLuo
commented
Jan 31, 2022
Contributor
Ok I'm going to take over merging this PR, probably in a separate branch |
AndrewZhaoLuo
commented
Feb 1, 2022
Contributor
Closing in favor of #10133 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new pattern in the SimplifyExpr in Relay that simplifies consecutive casts into one.
cc @mbrookhart