Skip to content

[CUBLAS] Remove deprecated CUBLAS_TENSOR_OP_MATH flag - #8130

Merged
tqchen merged 1 commit into
apache:mainfrom
tkonolige:remove_cublas_tensorecore_flag
May 26, 2021
Merged

[CUBLAS] Remove deprecated CUBLAS_TENSOR_OP_MATH flag#8130
tqchen merged 1 commit into
apache:mainfrom
tkonolige:remove_cublas_tensorecore_flag

Conversation

@tkonolige

Copy link
Copy Markdown
Contributor

This flag is causes CUBLAS to use tensor cores on all operations. With f32 or f64 operations, this leads to loss of accuracy.

#7995

Supersedes #8108.
@areusch@comaniac

@areuschareusch mentioned this pull request May 25, 2021
17 tasks
@comaniac

Copy link
Copy Markdown
Contributor

How about we keep the API but just use CUBLAS_DEFAULT_MATH? It preserves the interface of leveraging other math flags in the future. Specifically, CUBLAS_TF32_TENSOR_OP_MATH might be used when supporting TF32.

This flag is causes CUBLAS to use tensore cores on all operations. With
f32 or f64 operations, this leads to loss of accuracy.
@tkonolige
tkonoligeforce-pushed the remove_cublas_tensorecore_flag branch from a74de41 to 4b93009CompareMay 25, 2021 23:19
@tqchen
tqchen merged commit 31e21a2 into apache:mainMay 26, 2021
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jun 17, 2021
This flag is causes CUBLAS to use tensore cores on all operations. With
f32 or f64 operations, this leads to loss of accuracy.
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jun 17, 2021
This flag is causes CUBLAS to use tensore cores on all operations. With
f32 or f64 operations, this leads to loss of accuracy.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@tkonolige@comaniac@tqchen