Uh oh!
There was an error while loading. Please reload this page.
[Vulkan][Docs] Minor updates following Vulkan target query implementation - #8151
Merged
Conversation
Lunderberg
commented
May 27, 2021
ContributorAuthor
masahi
commented
May 27, 2021
Member
please fix the build error. |
Lunderbergforce-pushed
the
vulkan_target_query
branch
from
May 27, 2021 21:55
774c875 to
9c05e30CompareLunderberg
commented
May 27, 2021
ContributorAuthor
Build error fixed. Thank you for the catch, and definitely time for me to set up a pre-commit hook, since I've forgotten both this and linting in the past. |
- Better error messages, specifying which capability is needed. - Documentation section outlining the different target capabilities, which vulkan properties they correspond to, and which spir-v capabilities they are required by.
Lunderbergforce-pushed
the
vulkan_target_query
branch
from
June 1, 2021 15:22
9c05e30 to
29744a3CompareLunderberg
commented
Jun 1, 2021
ContributorAuthor
Rebased on main to start CI again, now that the CI fix #8160 is in. |
masahi
approved these changes
Jun 2, 2021
masahi
commented
Jun 2, 2021
Member
Thanks @Lunderberg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better error messages, specifying which capability is needed.
Documentation section outlining the different target capabilities,
which vulkan properties they correspond to, and which spir-v
capabilities they are required by.