Skip to content

[microTVM] Add Arduino CLI support to ci-qemu - #8504

Merged
areusch merged 6 commits into
apache:mainfrom
guberti:ci-qemu-arduino-support
Aug 9, 2021
Merged

[microTVM] Add Arduino CLI support to ci-qemu#8504
areusch merged 6 commits into
apache:mainfrom
guberti:ci-qemu-arduino-support

Conversation

@guberti

@gubertiguberti commented Jul 19, 2021•
edited
Loading

Copy link
Copy Markdown
Member

When merging Arduino support from #8493, we'd like to be able to add unit tests. Since no simulators exist for any of the boards we currently support, we will only be able to test project generation and compilation.

Specifically, this PR adds an ubuntu_install_arduino.sh script that installs arduino-cli via wget (as recommended) and then downloads the SDKs for two of the boards we support.

@guberti
gubertiforce-pushed the ci-qemu-arduino-support branch from 56029c7 to 93c132aCompareJuly 20, 2021 20:42
@guberti
guberti marked this pull request as ready for review July 26, 2021 17:58
areusch
areusch reviewed Jul 26, 2021
View reviewed changes

@areuschareusch left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @guberti , see some comments inline

Comment threaddocker/install/ubuntu_install_arduino.sh Outdated
Comment threaddocker/install/ubuntu_install_arduino.sh Outdated
@gubertiguberti mentioned this pull request Jul 28, 2021
Closed
@gubertiguberti closed this Jul 29, 2021
@gubertiguberti reopened this Jul 29, 2021
@gubertiguberti changed the title Add Arduino CLI support to ci-qemu[microTVM] Add Arduino CLI support to ci-qemuAug 2, 2021
mehrdadh
mehrdadh requested changes Aug 3, 2021
View reviewed changes

@mehrdadhmehrdadh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@guberti thanks for this change! Can you explain your plan on testing Arduino on ci_qemu?
Maybe add information about the board that you are using and etc.

@guberti

guberti commented Aug 5, 2021

Copy link
Copy Markdown
MemberAuthor

As discussed with Mehrdad, the Sony Spresense SDK (the Arduino board I used for development) has a bug that prevents TVM from compiling. The fix is available on the development branch and will be released in version 2.3.0, but that has not yet occurred.

Instead of using a workaround (such as installing from the development branch or cherry-picking the commit), IMO it's better to just test on a different type of board. Commit fe1d4dd replaces the Spresense with the Arduino Due, which is much more popular and works without needing a crazy hack.

mehrdadh
mehrdadh approved these changes Aug 5, 2021
View reviewed changes

@mehrdadhmehrdadh left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I built the image and tested it. LGTM!
Thanks!

@areusch
areusch merged commit 39571c1 into apache:mainAug 9, 2021
@areusch

areusch commented Aug 9, 2021

Copy link
Copy Markdown
Contributor

thanks @guberti, the PR is now merged!

mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Aug 11, 2021
@guberti@mehrdadh
[microTVM] Add Arduino CLI support to ci-qemu (apache#8504)
fff57b4
* Add Arduino CLI support to ci-qemu
* Install latest version of Arduino SDK
* Remove unnecessary --fix-missing
* Tweak to clarify what URLs go with what
* Retrigger CI
* Temporarily replace buggy Spresense core
@gubertiguberti mentioned this pull request Aug 17, 2021
Merged
ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
@guberti@ylc
[microTVM] Add Arduino CLI support to ci-qemu (apache#8504)
fb32de1
* Add Arduino CLI support to ci-qemu
* Install latest version of Arduino SDK
* Remove unnecessary --fix-missing
* Tweak to clarify what URLs go with what
* Retrigger CI
* Temporarily replace buggy Spresense core
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@guberti@ylc
[microTVM] Add Arduino CLI support to ci-qemu (apache#8504)
2cdbd54
* Add Arduino CLI support to ci-qemu
* Install latest version of Arduino SDK
* Remove unnecessary --fix-missing
* Tweak to clarify what URLs go with what
* Retrigger CI
* Temporarily replace buggy Spresense core
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@areuschareuschareusch approved these changes
@mehrdadhmehrdadhmehrdadh approved these changes
@jroeschjroeschAwaiting requested review from jroesch
@leandronleandronAwaiting requested review from leandron

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@guberti@areusch@mehrdadh