Uh oh!
There was an error while loading. Please reload this page.
[Refactor] Remove AttrStmt with storage_scope key - #8516
Merged
Conversation
masahiforce-pushed
the
remove_attr_storage_scope
branch
from
July 20, 2021 23:58
059f41a to
5009d78Comparetqchen
commented
Jul 21, 2021
Member
cc @kparzysz-quic would be great if you can help to manage this PR |
masahi added a commit
to masahi/tvm
that referenced
this pull request
Jul 22, 2021
masahi added a commit
to masahi/tvm
that referenced
this pull request
Jul 22, 2021
masahi
marked this pull request as ready for review
July 22, 2021 19:54
masahi
requested review from
MarisaKirisame, ZihengJiang, anijain2305, areusch, comaniac, jroesch, junrushao, jwfromm, kparzysz-quic, mbrookhart, merrymercy, slyubomirsky, tqchen, vinx13, wweic, yzhliu and zhiics
as code ownersJuly 22, 2021 19:54
masahi
commented
Jul 22, 2021
MemberAuthor
This is ready for review @tqchen@kparzysz-quic@vinx13@csullivan |
masahi
commented
Jul 22, 2021
Uh oh!
There was an error while loading. Please reload this page.
masahi added a commit
to masahi/tvm
that referenced
this pull request
Jul 24, 2021
masahi added a commit
to masahi/tvm
that referenced
this pull request
Jul 24, 2021
masahi added a commit
to masahi/tvm
that referenced
this pull request
Jul 25, 2021
masahi added a commit
to masahi/tvm
that referenced
this pull request
Jul 25, 2021
masahi added a commit
to masahi/tvm
that referenced
this pull request
Jul 25, 2021
masahi added a commit
to masahi/tvm
that referenced
this pull request
Jul 27, 2021
masahiforce-pushed
the
remove_attr_storage_scope
branch
2 times, most recently
from
July 27, 2021 14:30
816f272 to
6815973Comparemasahi added a commit
to masahi/tvm
that referenced
this pull request
Jul 27, 2021
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
kparzysz-quic
approved these changes
Jul 27, 2021
masahiforce-pushed
the
remove_attr_storage_scope
branch
from
July 28, 2021 01:48
edade29 to
58841acComparemasahi added a commit
to masahi/tvm
that referenced
this pull request
Jul 28, 2021
masahi added a commit
to masahi/tvm
that referenced
this pull request
Jul 28, 2021
masahiforce-pushed
the
remove_attr_storage_scope
branch
from
July 28, 2021 20:09
58841ac to
64e1beeComparekparzysz-quic
commented
Jul 29, 2021
Contributor
Thanks @masahi! |
masahi added a commit
to masahi/tvm
that referenced
this pull request
Jul 29, 2021
masahi added a commit
to masahi/tvm
that referenced
this pull request
Jul 29, 2021
masahi added a commit
that referenced
this pull request
Jul 30, 2021
ylc pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* Remove all attr::storage_scope usage * pyformat * fixed VTA tests * Update TIR text printer to print storage_scope on allocate * print storage scope in AllocateNode ReprPrinter * Fixed accidently removed scope tag check * remove unused function Co-authored-by: masa <masa@pop-os.localdomain>
ylc pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
* Fix storage_access not visiting else branch * fix conflict with apache#8516 in the test * update thread sync test following apache#8516 update
ylc pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* Remove all attr::storage_scope usage * pyformat * fixed VTA tests * Update TIR text printer to print storage_scope on allocate * print storage scope in AllocateNode ReprPrinter * Fixed accidently removed scope tag check * remove unused function Co-authored-by: masa <masa@pop-os.localdomain>
ylc pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
* Fix storage_access not visiting else branch * fix conflict with apache#8516 in the test * update thread sync test following apache#8516 update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The final follow-up to #8366
After #8366, storage scopes associated with AttrStmt and PointerType are identical. To consolidate storage scope information into one place, I'm proposing to remove AttrStmt with
attr::storage_scopekey.With this PR, storage scope information is consolidated to
PointerType.TODO
Allocatenode