Skip to content

[Bugfix] Preserve IRModule type definition and imports in NameMangleExtFuncs - #8523

Merged
comaniac merged 4 commits into
apache:mainfrom
zxy844288792:bug_fix_pr
Jul 29, 2021
Merged

[Bugfix] Preserve IRModule type definition and imports in NameMangleExtFuncs#8523
comaniac merged 4 commits into
apache:mainfrom
zxy844288792:bug_fix_pr

Conversation

@zxy844288792

@zxy844288792zxy844288792 commented Jul 21, 2021

Copy link
Copy Markdown

When calling graph_partition pass on tensoraay ops, it fails with errorCheck failed: (it != type_definitions.end()) is false: There is no definition of static_tensor_float32_any_2_3_t This is introduced by #8014.

This fix imports type definations from old module when craeting a new module in NameMangleExtFuncs.

cc @comaniac

Comment threadtests/python/relay/test_tensor_array.py Outdated
@comaniaccomaniac changed the title [Bugfix] check type failed when partitioning tensorarray ops[Bugfix] Preserve IRModule type definition and imports in NameMangleExtFuncsJul 21, 2021
@comaniac

Copy link
Copy Markdown
Contributor

cc @manupa-arm

@comaniaccomaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment threadtests/python/relay/test_pass_partition_graph.py Outdated
Co-authored-by: Cody Yu <comaniac0422@gmail.com>

@manupakmanupak left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! LGTM!

Comment threadtests/python/relay/test_pass_partition_graph.py Outdated
@comaniac
comaniac merged commit e39204e into apache:mainJul 29, 2021
@comaniac

Copy link
Copy Markdown
Contributor

Thanks @zxy844288792@manupa-arm

ylc pushed a commit to ylc/tvm that referenced this pull request Sep 29, 2021
…xtFuncs (apache#8523)
* bug fix and add tensorarray with partition pass test case
* change test function location and address comments
* Update tests/python/relay/test_pass_partition_graph.py
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
* trigger CI
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
…xtFuncs (apache#8523)
* bug fix and add tensorarray with partition pass test case
* change test function location and address comments
* Update tests/python/relay/test_pass_partition_graph.py
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
* trigger CI
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@zxy844288792@comaniac@manupak