[Runtime] Pipeline Executor Initial patch. by huajsj · Pull Request #8702 · apache/tvm

huajsj · 2021-08-10T05:56:18Z

This patch is one of serial patch for PR 7892 splitting. this is initial part the pipeline executor, include the cmake
change and python and c++ interface for pipeline executor.

jroesch · 2021-08-10T17:45:09Z

Is there an RFC for this feature? sorry if it was already posted some where, there is a lot of activity going on.

huajsj · 2021-08-10T19:04:29Z

@jroesch , thanks for the follow up, here is the RFC apache/tvm-rfcs#14,
the discussion thread: https://discuss.tvm.apache.org/t/rfc-compute-graph-pipeline-with-new-subgraph-executor/9839/9

huajsj · 2021-08-12T20:30:58Z

@comaniac

comaniac · 2021-08-12T21:29:40Z

Sorry for the delay review. I'm busy with internal tasks now and will try my best to review the RFC again early next week.
We will be focusing on the RFC and start reviewing the PR with a consent.

huajsj · 2021-08-12T21:57:49Z

thanks @comaniac.

huajsj · 2021-08-27T16:57:49Z

@comaniac, the RFC design already applied into this PR, if you have time please review again.

comaniac

Finish reviewing except for the detail implementation of PipelineModuleConfig. I would like to spend time on it after all the programming models and user interfaces are finalized.

comaniac

Just carefully reviewed the pipeline config as it is the most important user interface of this feature. Please let me know if you have any concern.

huajsj · 2021-09-02T22:27:28Z

@comaniac , all review comments addressed, please review again.

masahi · 2021-09-13T11:05:21Z

@huajsj See below. You said they were fixed, but they are not.

https://github.com/apache/tvm/pull/8702/files#r706562006
https://github.com/apache/tvm/pull/8702/files#r707197383
#8702 (comment)
#8702 (comment)

Before asking a review again, please go through ALL of your writing again and correct as much simple errors as possible (lack of a or the before a noun, s after third-pronoun verb, etc).

huajsj · 2021-09-14T07:12:25Z

@masahi all review comments addressed, please review again.

masahi · 2021-09-15T02:58:30Z

Thanks @huajsj for your patience. I left final comments, once they are fixed I'll merge this.

huajsj · 2021-09-15T06:15:45Z

@masahi, Thanks for the kindly review, all review comments addressed, please take another look.

masahi · 2021-09-15T12:01:26Z

thanks @huajsj @comaniac

@AndrewZhaoLuo

* main: (102 commits) Implementation of relay_to_tir target hook (apache#8423) [Onnx] Fix NLL Loss tests (apache#8971) [Bugfix] Fix other div zero errors also in rewrite_simplify (apache#8983) [ONNX] enable the onnx tests after PR apache#8274 merged (apache#9019) [Hexagon] Disable `thread_local` on Hexagon (apache#9025) [Hexagon] Allow undefined symbols in libtvm_runtime.so on Hexagon (apache#9024) [Onnx] Add momentum (apache#9000) fix (apache#9021) [Community] @AndrewZhaoLuo -> Reviewer (apache#9020) [Hexagon] Implement model launcher (apache#8986) [Relay][Pass] Add ExtractOperators pass (apache#8996) [BYOC][TensorRT] Add TensorRT own int8 calibration support to TensorRT BYOC integration (apache#8808) [ONNX] Add Einsum converter (apache#8985) Add standalone_crt/ to be part of the wheel package, when available. (apache#9005) [Relay] Remove memory planing from LowerTEPass (apache#8974) [Hexagon] Treat floats as float32 when passing args to offloaded kernels (apache#9010) [Runtime] Pipeline Executor Initial patch. (apache#8702) [Hexagon] `llvm-options` attribute is an array of strings (apache#9011) disable cuda int8 schedule for non-cuda gpu target (apache#9014) [Torch] Add an option to make imported models compatible with the Relay text parser (apache#9015) ...

* [Runtime] Pipeline Executor Initial patch. This patch is one of serial patch for PR 7892 splitting.this is the initial part of the pipeline executor, this patch include the cmake change and python and C++ interface for pipeline executor. * add pipeline config * add config connect logic. * fix build issue. * set output index start from 0 * address review comments Co-authored-by: Cody Yu <comaniac0422@gmail.com> * address review comments. * address review comments. * Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> * address review comments. * address review comments * add topology sort * add binding check logic. * fix plint error. * Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> * address review comments. * fix plint issue. * address review comments. * trigger build. * Update python/tvm/contrib/pipeline_executor.py Co-authored-by: Cody Yu <comaniac0422@gmail.com> address review comments * address review comments. * polish doc and comments. * polish doc and address review comments. * address review comments. * doc change. * doc change. * Trigger build. * trigge build. * address review comments. * address review comments. * address review comments. * polish documents. * Polish the document. * address review comments. Co-authored-by: Cody Yu <comaniac0422@gmail.com>

huajsj requested review from a team, ZihengJiang, areusch, comaniac, jroesch, junrushao, kazum, liangfu, masahi, merrymercy, tmoreau89, tqchen, vinx13, yzhliu and zhiics as code owners August 10, 2021 05:56

huajsj force-pushed the small branch from 8d41893 to 5e1e1e7Compare August 10, 2021 05:57

huajsj force-pushed the small branch from 1421e24 to f972bb3Compare August 27, 2021 00:35

comaniac requested changes Aug 27, 2021
View reviewed changes

huajsj force-pushed the small branch 2 times, most recently from 2e24e76 to 6aa02a7Compare August 29, 2021 20:36

comaniac requested changes Aug 30, 2021
View reviewed changes

huajsj force-pushed the small branch 2 times, most recently from 95806b5 to 9cdf82bCompare September 1, 2021 04:23

masahi reviewed Sep 13, 2021
View reviewed changes

Comment threadpython/tvm/contrib/pipeline_executor.py Outdated

masahi reviewed Sep 13, 2021
View reviewed changes

Comment threadpython/tvm/contrib/pipeline_executor.py Outdated

masahi reviewed Sep 13, 2021
View reviewed changes

Comment threadpython/tvm/contrib/pipeline_executor.py Outdated

masahi reviewed Sep 13, 2021
View reviewed changes

Comment threadpython/tvm/contrib/pipeline_executor.py Outdated

masahi reviewed Sep 13, 2021
View reviewed changes

Comment threadpython/tvm/contrib/pipeline_executor.py Outdated

address review comments.
beac198

huajsj force-pushed the small branch from 27d42ab to beac198Compare September 14, 2021 00:47

huajsj added 3 commits September 13, 2021 21:08

address review comments.
8a088bf

polish documents.
a887705

Polish the document.
efd91e1

huajsj requested a review from masahi September 14, 2021 07:12

masahi reviewed Sep 15, 2021
View reviewed changes

Comment threadpython/tvm/contrib/pipeline_executor.py Outdated

masahi reviewed Sep 15, 2021
View reviewed changes

Comment threadpython/tvm/contrib/pipeline_executor.py Outdated

masahi reviewed Sep 15, 2021
View reviewed changes

Comment threadpython/tvm/contrib/pipeline_executor.py Outdated

masahi reviewed Sep 15, 2021
View reviewed changes

Comment threadpython/tvm/contrib/pipeline_executor.py Outdated

masahi reviewed Sep 15, 2021
View reviewed changes

Comment threadpython/tvm/contrib/pipeline_executor.py Outdated

masahi reviewed Sep 15, 2021
View reviewed changes

Comment threadpython/tvm/contrib/pipeline_executor.py Outdated

address review comments.
db8422d

masahi approved these changes Sep 15, 2021
View reviewed changes

masahi merged commit 9bc4dc0 into apache:mainSep 15, 2021

junrushao mentioned this pull request Nov 1, 2021
Apache TVM v0.8 Release Note Candidate #9416
Closed

huajsj mentioned this pull request Nov 11, 2021
[RFC][Tracking Issue] Pipeline Executor For Compute graph pipeline #8596
Closed
15 tasks

Uh oh!

Conversation

huajsj commented Aug 10, 2021

Uh oh!

jroesch commented Aug 10, 2021

Uh oh!

huajsj commented Aug 10, 2021

Uh oh!

huajsj commented Aug 12, 2021

Uh oh!

comaniac commented Aug 12, 2021

Uh oh!

huajsj commented Aug 12, 2021

Uh oh!

huajsj commented Aug 27, 2021

Uh oh!

comaniac left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

comaniac left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

huajsj commented Sep 2, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

masahi commented Sep 13, 2021

Uh oh!

huajsj commented Sep 14, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

masahi commented Sep 15, 2021

Uh oh!

huajsj commented Sep 15, 2021

Uh oh!

masahi commented Sep 15, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants