[2/6] Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op by manupak · Pull Request #8795 · apache/tvm

manupak · 2021-08-19T14:39:44Z

This commit adds mainly the relay passes and ethosu_conv2d
operator to relay. The relay passes include the legalizations
and preprocessing of the relay graph in the paritioning.

Co-authored-by: Matthew Barrett matthew.barrett@arm.com

mbaret · 2021-09-03T13:45:19Z

We should be able to expose it, can you clearly comment where you the exact API so Mark and I can look into replacing in parallel?

@jroesch You can take a look here: https://github.com/apache/tvm/pull/8806/files#diff-ba18206383e6627c682094ad5b1a211be9dd8315e82b9c5f970496ce57ebe48c (from the next PR). That's the custom Relay -> TE lowering function we're making use of which demonstrates the API.

manupak · 2021-09-04T04:09:04Z

@jroesch @mbs-octoml PTAL when you have some time.

mbs-octoml · 2021-09-07T15:33:34Z

LGTM thanks for the type annots, does it work if you enable checking in the mypy.ini? If so let's include that in this pr.

manupak · 2021-09-07T16:49:22Z

@mbs-octoml I enabled the check in task_mypy.sh; I dont think there is nothing to change in mypy.ini as the global setting is "ignore_errors = False"

This commit adds mainly the relay passes and ethosu_conv2d operator to relay. The relay passes include the legalizations and preprocessing of the relay graph in the paritioning. Co-authored-by: Matthew Barrett <matthew.barrett@arm.com>

* skipping the test if vela is not in the container. Change-Id: I68cc4259dc33e1473e460956978f364fbf6596d8

* addressing Jared's comments Change-Id: Ief669f788c6bd1a1be1004cbce5129ed06b63c3c

* addressing Elen's comments Change-Id: Iad6315bb63f12ba318deb9c5c9eff7459ff58c48

* cleanup passes Change-Id: I8e1cbedd2c4d3d0cdff481d775d9eb0577e44456

Change-Id: I7e65c2714d017c8a4b64986b111a6b51d128c963

Change-Id: I55cfbb3787c0aacdadf46c4859dff39287e65ddc

*addressing chris's comments *addressing Nicola's comments Change-Id: Id02788ddcdbc3679e0da37b2fa614cded0a4c1f5

*addressing missed 'hidden' comments of Chris *addressing one missed comment of Nicola *adding type annotations Change-Id: Iadf4907b311e195731dbbed571e95a266341db8f

*further type fixes and one missed comment Change-Id: I6da69fd95d17dfeaf5940da4f8d8c8ea142b39d2

*missed comment split_o Change-Id: I4a4b19ff2cd18e8f568a63ae827f44358ed85b8e

* adding mypy check Change-Id: Iaf58dbba2a9d8e1098a10c589d91b63c7efe646d

*removing premature insertion of get_accel_type utility Change-Id: I210512e00a5eb46adf23d1d72eb16432db526d25

* rebase fixes Change-Id: I06c9b536a7598646efce2b664fcc405aa6008203

manupak · 2021-09-08T06:29:54Z

@Mousius @ashutosh-arm , shall we prioritize to land this next as it is approved ? it is getting conflicts from CMSISNN PRs.

asparkhi · 2021-09-08T06:51:45Z

Yes, of course.

* Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op This commit adds mainly the relay passes and ethosu_conv2d operator to relay. The relay passes include the legalizations and preprocessing of the relay graph in the paritioning. Co-authored-by: Matthew Barrett <matthew.barrett@arm.com> * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op * skipping the test if vela is not in the container. Change-Id: I68cc4259dc33e1473e460956978f364fbf6596d8 * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op * addressing Jared's comments Change-Id: Ief669f788c6bd1a1be1004cbce5129ed06b63c3c * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op * addressing Elen's comments Change-Id: Iad6315bb63f12ba318deb9c5c9eff7459ff58c48 * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op * cleanup passes Change-Id: I8e1cbedd2c4d3d0cdff481d775d9eb0577e44456 * Update TE comments Change-Id: I7e65c2714d017c8a4b64986b111a6b51d128c963 * Address ekalda's comments in TE Change-Id: I55cfbb3787c0aacdadf46c4859dff39287e65ddc * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op *addressing chris's comments *addressing Nicola's comments Change-Id: Id02788ddcdbc3679e0da37b2fa614cded0a4c1f5 * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op *addressing missed 'hidden' comments of Chris *addressing one missed comment of Nicola *adding type annotations Change-Id: Iadf4907b311e195731dbbed571e95a266341db8f * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op *further type fixes and one missed comment Change-Id: I6da69fd95d17dfeaf5940da4f8d8c8ea142b39d2 * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op *missed comment split_o Change-Id: I4a4b19ff2cd18e8f568a63ae827f44358ed85b8e * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op * adding mypy check Change-Id: Iaf58dbba2a9d8e1098a10c589d91b63c7efe646d * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op *removing premature insertion of get_accel_type utility Change-Id: I210512e00a5eb46adf23d1d72eb16432db526d25 * Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op * rebase fixes Change-Id: I06c9b536a7598646efce2b664fcc405aa6008203 Co-authored-by: Matthew Barrett <matthew.barrett@arm.com>

manupak requested review from a team, MarisaKirisame, ZihengJiang, anijain2305, areusch, comaniac, jroesch, junrushao, jwfromm, mbaret, mbrookhart, merrymercy, slyubomirsky, tqchen, trevor-m, vinx13, wweic, yzhliu and zhiics as code owners August 19, 2021 14:39

manupak mentioned this pull request Aug 19, 2021
[RFC][Tracking Issue] Arm® Ethos™-U Integration #8482
Closed
8 tasks

manupak changed the title ~~Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op~~[2/6] Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D opAug 20, 2021

mbaret mentioned this pull request Aug 20, 2021
[3/6] Arm(R) Ethos(TM)-U NPU TIR compiler with conv2d support #8806
Merged

jroesch self-assigned this Aug 20, 2021

jroesch removed request for a team, MarisaKirisame, mbrookhart, tqchen, wweic, yzhliu and zhiics August 20, 2021 23:46

manupak force-pushed the ethosu_upstreaming_p2 branch from faa08d6 to f780b9eCompare September 3, 2021 10:03

grant-arm mentioned this pull request Sep 3, 2021
Arm(R) Cortex(R)-M55 CPU and Arm(R) Ethos(TM)-U55 NPU Demo App #8922
Merged

manupak force-pushed the ethosu_upstreaming_p2 branch from f780b9e to 3db968cCompare September 3, 2021 11:07

jroesch approved these changes Sep 7, 2021
View reviewed changes

manupakand others added 14 commits September 8, 2021 05:00

Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op
262aefc
This commit adds mainly the relay passes and ethosu_conv2d operator to relay. The relay passes include the legalizations and preprocessing of the relay graph in the paritioning. Co-authored-by: Matthew Barrett <matthew.barrett@arm.com>

Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op
9a4188b
* skipping the test if vela is not in the container. Change-Id: I68cc4259dc33e1473e460956978f364fbf6596d8

Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op
e059c89
* addressing Jared's comments Change-Id: Ief669f788c6bd1a1be1004cbce5129ed06b63c3c

Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op
9517161
* addressing Elen's comments Change-Id: Iad6315bb63f12ba318deb9c5c9eff7459ff58c48

Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op
6d52501
* cleanup passes Change-Id: I8e1cbedd2c4d3d0cdff481d775d9eb0577e44456

Update TE comments
148c43a
Change-Id: I7e65c2714d017c8a4b64986b111a6b51d128c963

Address ekalda's comments in TE
82ee99d
Change-Id: I55cfbb3787c0aacdadf46c4859dff39287e65ddc

Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op
982152c
*addressing chris's comments *addressing Nicola's comments Change-Id: Id02788ddcdbc3679e0da37b2fa614cded0a4c1f5

Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op
7af999c
*addressing missed 'hidden' comments of Chris *addressing one missed comment of Nicola *adding type annotations Change-Id: Iadf4907b311e195731dbbed571e95a266341db8f

Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op
76905af
*further type fixes and one missed comment Change-Id: I6da69fd95d17dfeaf5940da4f8d8c8ea142b39d2

Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op
23c9b10
*missed comment split_o Change-Id: I4a4b19ff2cd18e8f568a63ae827f44358ed85b8e

Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op
0de4415
* adding mypy check Change-Id: Iaf58dbba2a9d8e1098a10c589d91b63c7efe646d

Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op
538a132
*removing premature insertion of get_accel_type utility Change-Id: I210512e00a5eb46adf23d1d72eb16432db526d25

Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op
ed68938
* rebase fixes Change-Id: I06c9b536a7598646efce2b664fcc405aa6008203

manupak force-pushed the ethosu_upstreaming_p2 branch from 80a2c43 to ed68938Compare September 8, 2021 06:20

manupak mentioned this pull request Sep 8, 2021
[TIR][USMP] Added buffer info extraction pass #8468
Merged

jroesch merged commit 01aeeb1 into apache:mainSep 8, 2021

junrushao mentioned this pull request Nov 1, 2021
Apache TVM v0.8 Release Note Candidate #9416
Closed

Navigation Menu

Uh oh!

[2/6] Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op - #8795

[2/6] Arm(R) Ethos(TM)-U NPU Relay passes and Conv2D op#8795
jroesch merged 14 commits into
apache:mainfrom
manupak:ethosu_upstreaming_p2

manupak commented Aug 19, 2021

Uh oh!

mbaret commented Sep 3, 2021

Uh oh!

manupak commented Sep 4, 2021

Uh oh!

mbs-octoml commented Sep 7, 2021

Uh oh!

manupak commented Sep 7, 2021

Uh oh!

manupak commented Sep 8, 2021

Uh oh!

asparkhi commented Sep 8, 2021•
edited
Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

manupak commented Aug 19, 2021

Uh oh!

mbaret commented Sep 3, 2021

Uh oh!

manupak commented Sep 4, 2021

Uh oh!

mbs-octoml commented Sep 7, 2021

Uh oh!

manupak commented Sep 7, 2021

Uh oh!

manupak commented Sep 8, 2021

Uh oh!

asparkhi commented Sep 8, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

asparkhi commented Sep 8, 2021•
edited
Loading