Uh oh!
There was an error while loading. Please reload this page.
Fix incorrect AOT Memory Planning - #8926
Merged
Merged
Conversation
Mousius
requested review from
MarisaKirisame, ZihengJiang, anijain2305, areusch, comaniac, jroesch, junrushao, jwfromm, mbrookhart, merrymercy, slyubomirsky, tqchen, vinx13, wweic, yzhliu and zhiics
as code ownersSeptember 3, 2021 13:50
Mousius
commented
Sep 3, 2021
MemberAuthor
CC @manupa-arm |
Mousius
commented
Sep 3, 2021
MemberAuthor
Also CC @mbs-octoml@electriclilies for reviews 😸 |
Mousiusforce-pushed
the
aot-memory-planning
branch
3 times, most recently
from
September 3, 2021 18:51
4fbb9f5 to
cc0c43bCompareUh oh!
There was an error while loading. Please reload this page.
electriclilies
approved these changes
Sep 3, 2021
electriclilies
left a comment
Contributor
There was a problem hiding this comment.
Overall, LGTM! I'd like to see CalculateWorkspaceBytes in a pass in the future instead of being run directly in the exectutor, but this is fine for now
Uh oh!
There was an error while loading. Please reload this page.
Mousiusforce-pushed
the
aot-memory-planning
branch
3 times, most recently
from
September 6, 2021 08:51
aea2a68 to
97401c5CompareThis change introduces a second memory planning phase in the AOT code generator once the storage rewrite pass has been completed, fixing incorrectly sized workspaces for a variety of models. It comes with accompanying tests so we can safely refactor this later. Also corrected a typo in the TE compiler regards the memory alignment argument 😸 Co-authored-by: Manupa Karunaratne <Manupa.Karunaratne@arm.com>
Mousiusforce-pushed
the
aot-memory-planning
branch
from
September 6, 2021 12:30
97401c5 to
fdedfedComparejroesch
commented
Sep 7, 2021
Member
@Mousius is it possible for you guys to put this as a backlog item? will land this version but in general better to try and split these things into passes so we can make the executor code gens function more uniform instead of each one having different arguments/return values, etc. |
jroesch
approved these changes
Sep 7, 2021
ylc pushed a commit
to ylc/tvm
that referenced
this pull request
Sep 29, 2021
This change introduces a second memory planning phase in the AOT code generator once the storage rewrite pass has been completed, fixing incorrectly sized workspaces for a variety of models. It comes with accompanying tests so we can safely refactor this later. Also corrected a typo in the TE compiler regards the memory alignment argument 😸 Co-authored-by: Manupa Karunaratne <Manupa.Karunaratne@arm.com> Co-authored-by: Manupa Karunaratne <Manupa.Karunaratne@arm.com>
ylc pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
This change introduces a second memory planning phase in the AOT code generator once the storage rewrite pass has been completed, fixing incorrectly sized workspaces for a variety of models. It comes with accompanying tests so we can safely refactor this later. Also corrected a typo in the TE compiler regards the memory alignment argument 😸 Co-authored-by: Manupa Karunaratne <Manupa.Karunaratne@arm.com> Co-authored-by: Manupa Karunaratne <Manupa.Karunaratne@arm.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change introduces a second memory planning phase in the AOT code
generator once the storage rewrite pass has been completed, fixing
incorrectly sized workspaces for a variety of models.
It comes with accompanying tests so we can safely refactor this later.
Also corrected a typo in the TE compiler regards the memory alignment
argument 😸
Co-authored-by: Manupa Karunaratne Manupa.Karunaratne@arm.com