[microTVM] Update support for ARMv7m intrinsic by sergio-grovety · Pull Request #8990 · apache/tvm

sergio-grovety · 2021-09-12T19:16:39Z

Improved implementaion of gemm function for conv2d
Removed %4 restriction for channels
Added test case to verify SMLAD intrinsic speed acceleration

- Improved implementaion of gemm function for conv2d - Removed %4 restriction for channels - Added test case to verify SMLAD intrinsic speed acceleration Signed-off-by: Sergey Smirnov <Sergey@grovety.com>

mehrdadh

Thanks for this great contribution. I did an initial review. I will try to run this on hardware and get back with more details.

areusch

thanks @sergey-grovety for pushing this up! a couple questions

cc @manupa-arm @u99127 is anyone available to look at this from the ARM team?

- Improved implementaion of gemm function for conv2d - Removed %4 restriction for channels - Added test case to verify SMLAD intrinsic speed acceleration Signed-off-by: Sergey Smirnov <Sergey@grovety.com>

…-grovety/tvm into update-arm-simd-intrinsic

mehrdadh · 2021-09-14T16:58:46Z

for the test image maybe you could reuse this image: https://github.com/apache/tvm/blob/main/tests/micro/testdata/mnist/digit-2.jpg

sergio-grovety · 2021-09-15T20:01:28Z

for the test image maybe you could reuse this image: https://github.com/apache/tvm/blob/main/tests/micro/testdata/mnist/digit-2.jpg

Yes, sure.

Fixed micro model library test. Checking size reduced to 16 bytes from 2466816.

Removed changes.

mehrdadh

Thanks for this change. LGTM!
Just added a clarification question.

areusch

@sergey-grovety not sure if we should land #9092 first and refactor test logic there? otherwise aside from the two comments i think we can merge and move forwards.

areusch · 2021-09-27T19:37:59Z

 pytest tests/micro/zephyr/test_zephyr_aot.py --zephyr-board=${board}
 fi
+
+pytest tests/micro/zephyr/test_zephyr_armv7m.py --zephyr-board=${board}


could you move this to tests/scripts/task_python_microtvm.sh? This is just the base-box pre-release test, where we just want to do a smoke test to make sure that Zephyr is working with attached hardware.

It seems moving to tests/scripts/task_python_microtvm.sh make no sense. The only supported platform there is qemu_x86 for now. We don't run our test with it. And mps2_an521 disabled.
BTW, all tests in tests/micro/zephyr must be called, isn't it?

we discussed offline and have decided to proceed with local testing in this PR. in a follow-on, we will add support for Corstone 300 tests.

sergio-grovety · 2021-09-28T15:36:56Z

not sure if we should land #9092 first and refactor test logic there? otherwise aside from the two comments i think we can merge and move forwards.

Yes. Need to clean up from this.

mehrdadh · 2021-09-30T20:29:36Z

+
+ if board not in [
+ "mps2_an521",
+ "stm32f746xx_disco",


this board name has changed recently to stm32f746g_disco.
https://github.com/apache/tvm/pull/8998/files

@sergey-grovety given the CI is green and upcoming work on the test strategy feel free to address this in a follow-on.

areusch · 2021-09-30T23:30:11Z

thanks @sergey-grovety and team!

* [microTVM] Update support for ARMv7m intrinsic - Improved implementaion of gemm function for conv2d - Removed %4 restriction for channels - Added test case to verify SMLAD intrinsic speed acceleration Signed-off-by: Sergey Smirnov <Sergey@grovety.com> * [microTVM] Update support for ARMv7m intrinsic - Improved implementaion of gemm function for conv2d - Removed %4 restriction for channels - Added test case to verify SMLAD intrinsic speed acceleration Signed-off-by: Sergey Smirnov <Sergey@grovety.com> * Implemented discussed changes. * Removed unnecessary test files. * Formatting fixed. * Formatting fixed2. * Formatting fixed3. * Formatting fixed4. * Formatting fixed5. * Fixed test time result checking. * Check rebuild. * Formatting fixed. * Formatting fixed. * [microTVM] Update support for ARMv7m intrinsic - Improved implementaion of gemm function for conv2d - Removed %4 restriction for channels - Added test case to verify SMLAD intrinsic speed acceleration Signed-off-by: Sergey Smirnov <Sergey@grovety.com> * Implemented discussed changes. * Removed unnecessary test files. * Formatting fixed. * Formatting fixed2. * Formatting fixed3. * Formatting fixed4. * Formatting fixed5. * Fixed test time result checking. * Check rebuild. * Formatting fixed. * Issue 8717 Add schedule for depthwise_conv2d_nhwc * Resolve merge conflict. * Resolve merge conflicts. * Fixed formatting. * From Issue 8717// Fixed micro model library test. Checking size reduced to 16 bytes from 2466816. * From Issue 8717. Removed changes. * From Issue 8717. Fixed typo. * Fixed import. * Fixed import and method call. * Added QEMU testing comment. * Fixed ZEPHYR_BOARD usage. * Fixed tests. Removed issue 8717 changes. * Formatting fixed. * Removed test call from base_box_test.sh

[microTVM] Update support for ARMv7m intrinsic
a362004
- Improved implementaion of gemm function for conv2d - Removed %4 restriction for channels - Added test case to verify SMLAD intrinsic speed acceleration Signed-off-by: Sergey Smirnov <Sergey@grovety.com>

sergio-grovety requested review from Huyuwei, Laurawly, MarisaKirisame, ZihengJiang, anijain2305, areusch, comaniac, jcf94, jroesch, junrushao, jwfromm, kevinthesun, masahi, mbrookhart, merrymercy, slyubomirsky, tqchen, vinx13, wweic, yzhliu and zhiics as code owners September 12, 2021 19:16

mehrdadh requested changes Sep 13, 2021
View reviewed changes

areusch reviewed Sep 13, 2021
View reviewed changes

Comment threadtests/micro/zephyr/test_zephyr_armv7m.py Outdated
Comment threadapps/microtvm/reference-vm/zephyr/base-box/base_box_test.sh Outdated

sergio-grovetyand others added 3 commits September 14, 2021 02:40

Merge branch 'apache:main' into update-arm-simd-intrinsic
13dee66

[microTVM] Update support for ARMv7m intrinsic
0ea201e
- Improved implementaion of gemm function for conv2d - Removed %4 restriction for channels - Added test case to verify SMLAD intrinsic speed acceleration Signed-off-by: Sergey Smirnov <Sergey@grovety.com>

Merge branch 'update-arm-simd-intrinsic' ofhttps://github.com/sergey…
1d4288a
…-grovety/tvm into update-arm-simd-intrinsic

Implemented discussed changes.
36aa10d

sergio-grovety requested review from a team, manupak, mbaret, siju-samuel, srkreddy1238, tmoreau89 and trevor-m as code owners September 24, 2021 12:19

sergio-grovetyand others added 5 commits September 27, 2021 04:22

Merge branch 'main' into update-arm-simd-intrinsic
9f5fccb

Fixed formatting.
9ff8dc1

From Issue 8717//
934df18
Fixed micro model library test. Checking size reduced to 16 bytes from 2466816.

From Issue 8717.
d12812b
Removed changes.

From Issue 8717. Fixed typo.
8935725

mehrdadh approved these changes Sep 27, 2021
View reviewed changes

Comment threadtests/micro/zephyr/test_zephyr_armv7m.py

sergio-grovety added 2 commits September 27, 2021 09:56

Fixed import.
f59c498

Fixed import and method call.
6c28a28

areusch reviewed Sep 27, 2021
View reviewed changes

sergio-grovety added 2 commits September 27, 2021 23:56

Added QEMU testing comment.
2b1267b

Fixed ZEPHYR_BOARD usage.
8deb2d5

sergio-grovety added 2 commits September 28, 2021 09:04

Fixed tests. Removed issue 8717 changes.
50ce0ff

Formatting fixed.
6ddee6d

sergio-grovety mentioned this pull request Sep 28, 2021
Issue8717 x86 dws conv2d schedule #9092
Merged

Removed test call from base_box_test.sh
dc4c6d1

areusch approved these changes Sep 30, 2021
View reviewed changes

mehrdadh reviewed Sep 30, 2021
View reviewed changes

areusch merged commit c51f429 into apache:mainSep 30, 2021

sergio-grovety deleted the update-arm-simd-intrinsic branch October 26, 2022 09:20

Uh oh!

Conversation

sergio-grovety commented Sep 12, 2021

Uh oh!

mehrdadh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

areusch left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mehrdadh commented Sep 14, 2021

Uh oh!

sergio-grovety commented Sep 15, 2021

Uh oh!

mehrdadh left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

areusch left a comment

Choose a reason for hiding this comment

Uh oh!

areuschSep 27, 2021

Choose a reason for hiding this comment

Uh oh!

sergio-grovetySep 28, 2021

Choose a reason for hiding this comment

Uh oh!

areuschSep 30, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sergio-grovety commented Sep 28, 2021

Uh oh!

mehrdadhSep 30, 2021

Choose a reason for hiding this comment

Uh oh!

areuschSep 30, 2021

Choose a reason for hiding this comment

Uh oh!

areusch commented Sep 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

areusch left a comment •
edited
Loading