Uh oh!
There was an error while loading. Please reload this page.
[Code Style] Changed code to match the tvm code style conventions. - #9040
Conversation
[Issue] While reviewing the tvm code, I noticed some naming convention issues in the diag_ctx_ and current_func variables. Variable current_func should be current_func_ because it is a class variable Variable diag_ctx_ should be diag_ctx , because it is a public variable [Solution] Changed the variables to match the tvm code style conventions
aaee667 to
f129485Compare
mbrookhart
left a comment
There was a problem hiding this comment.
LGTM.
You have a lint issue, could you run make format and repush?
Mousius
commented
Sep 21, 2021
Hi @mbrookhart / @Raghav-Chakravarthy, I actually made this mistake in another PR (#8951 (comment)), the actual rule is that all data members of a class should have the trailing @Raghav-Chakravarthy would it be possible for you to update this PR accordingly? |
Raghav-Chakravarthy
commented
Oct 8, 2021
Sorry for the late response. I was busy with many school exams, and got a chance to look at the code this week. All review comments have been addressed. Please let me know if anything else needs to be modified. |
areusch
commented
Oct 12, 2021
@mbrookhart@Mousius could you take a look at this one? @Raghav-Chakravarthy could you fix the lint error? |
Mousius
left a comment
There was a problem hiding this comment.
Once the minor lint grievance is resolved, this is a great example of where following the conventions has lead to the code being cleaner and generally easier to read - thanks for this @Raghav-Chakravarthy!
areusch
commented
Oct 14, 2021
@Raghav-Chakravarthy please fix the lint error when you get a minute! |
Raghav-Chakravarthy
commented
Oct 15, 2021
627144f to
facf055CompareRaghav-Chakravarthy
commented
Oct 16, 2021
Raghav-Chakravarthy
commented
Oct 22, 2021
@areusch@mbrookhart - Please take a look at my PR. |
…pache#9040) * [Code Style] Changed code to match the tvm code style conventions. [Issue] While reviewing the tvm code, I noticed some naming convention issues in the diag_ctx_ and current_func variables. Variable current_func should be current_func_ because it is a class variable Variable diag_ctx_ should be diag_ctx , because it is a public variable [Solution] Changed the variables to match the tvm code style conventions * addressed comments * removed debug logic * fixed plint issue * fixed building issue * fixed whitespace issue * fixed linting error in type_solver.cc
…pache#9040) * [Code Style] Changed code to match the tvm code style conventions. [Issue] While reviewing the tvm code, I noticed some naming convention issues in the diag_ctx_ and current_func variables. Variable current_func should be current_func_ because it is a class variable Variable diag_ctx_ should be diag_ctx , because it is a public variable [Solution] Changed the variables to match the tvm code style conventions * addressed comments * removed debug logic * fixed plint issue * fixed building issue * fixed whitespace issue * fixed linting error in type_solver.cc
[Issue]
While reviewing the tvm code, I noticed some naming convention issues
in the diag_ctx_ and current_func variables.
Variable current_func should be current_func_ because it is a class
variable
Variable diag_ctx_ should be diag_ctx , because it is a public variable
[Solution]
Changed the variables to match the tvm code style conventions