Skip to content

[MetaSchedule][M3a] SearchStrategy - #9132

Merged
junrushao merged 8 commits into
apache:mainfrom
zxybazh:tensorir-infra/upstream/2021-09-23/search-strategy
Sep 29, 2021
Merged

[MetaSchedule][M3a] SearchStrategy#9132
junrushao merged 8 commits into
apache:mainfrom
zxybazh:tensorir-infra/upstream/2021-09-23/search-strategy

Conversation

@zxybazh

@zxybazhzxybazh commented Sep 26, 2021•
edited
Loading

Copy link
Copy Markdown
Member

This PR is part of the stage M3a of the meta schedule project (#8473).

The architecture is re-designed by Junru and Xiyou. SearchStrategy is designed to generate measure candidates, i.e., schedules and corresponding argument information for later profiling. Apart from the c++ side implementation, we also include python-side customizable search strategy class PySearchStrategy and trace replaying based search strategy class, i.e., generating schedule from a trace and random arguments, ReplayTrace. Unit tests are also included.

For usage of related class, we introduced MeasureCandidate class to store search strategy's result and RunnerResult class to store results from runner. We also adjusted some sampling primitives for usage in meta schedule.

Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>

@junrushaojunrushao mentioned this pull request Sep 27, 2021
Closed
62 tasks
@junrushao

junrushao commented Sep 27, 2021

Copy link
Copy Markdown
Member

@zxybazh please fix the lint :-)

junrushao
junrushao reviewed Sep 27, 2021
View reviewed changes
Comment threadinclude/tvm/meta_schedule/search_strategy.h
tkonolige
tkonolige reviewed Sep 27, 2021
View reviewed changes

@tkonoligetkonolige left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall structure of this looks good to me. I would like to a see a little more documentation around SearchStrategy as it is a core interface in tuning.

Comment threadsrc/meta_schedule/search_strategy/replay_trace.cc Outdated
Comment threadsrc/meta_schedule/search_strategy/replay_trace.cc Outdated
Comment threadsrc/meta_schedule/utils.h Outdated
Comment threadinclude/tvm/meta_schedule/search_strategy.h Outdated
Comment threadinclude/tvm/meta_schedule/search_strategy.h Outdated
Comment threadinclude/tvm/meta_schedule/search_strategy.h Outdated
Comment threadinclude/tvm/meta_schedule/runner.h Outdated
Comment threadinclude/tvm/meta_schedule/runner.h Outdated
Comment threadinclude/tvm/meta_schedule/search_strategy.h Outdated
Comment threadinclude/tvm/meta_schedule/search_strategy.h
@junrushao

junrushao commented Sep 28, 2021

Copy link
Copy Markdown
Member

Yeah I agree with @tkonolige that we need a high-level description of how the SearchStrategy object is expected to work, like, when each method is called and what are the expected inputs/outputs, etc

@zxybazh

zxybazh commented Sep 28, 2021

Copy link
Copy Markdown
MemberAuthor

Fixed docs and added some interesting figure. Ready for another round of review.

junrushao
junrushao reviewed Sep 28, 2021
View reviewed changes
Comment threadinclude/tvm/meta_schedule/search_strategy.h Outdated
junrushao
junrushao reviewed Sep 28, 2021
View reviewed changes
Comment threadinclude/tvm/meta_schedule/search_strategy.h
junrushao
junrushao reviewed Sep 28, 2021
View reviewed changes
Comment threadinclude/tvm/meta_schedule/search_strategy.h
junrushao
junrushao reviewed Sep 28, 2021
View reviewed changes
Comment threadinclude/tvm/meta_schedule/space_generator.h
junrushao
junrushao reviewed Sep 28, 2021
View reviewed changes

@junrushaojunrushao left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I believe this PR is in pretty good state. Will merge it in after some minor nitpicks are addressed. Thanks @zxybazh!

zxybazhand others added 6 commits September 28, 2021 10:45
@zxybazh@junrushao
@spectrometerHBH@MasterJH5574@jinhongyii@vinx13Siyuan Feng
Add c++ side SearchStrategy.
c3bdf42
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
@zxybazh@junrushao
@spectrometerHBH@MasterJH5574@jinhongyii@vinx13Siyuan Feng
Add python-side code & test.
580545c
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
@zxybazh
Add docs.
11570e5
@zxybazh
Minor fix.
9affcfb
@zxybazh
Add workflow.
62b9545
@zxybazh
Add docs.
aadb218
@zxybazh
zxybazhforce-pushed the tensorir-infra/upstream/2021-09-23/search-strategy branch from d16d672 to 4d95b27CompareSeptember 28, 2021 17:50
tkonolige
tkonolige reviewed Sep 28, 2021
View reviewed changes
Comment threadinclude/tvm/meta_schedule/search_strategy.h
Comment threadinclude/tvm/meta_schedule/search_strategy.h
@zxybazh

zxybazh commented Sep 29, 2021

Copy link
Copy Markdown
MemberAuthor

Let's get it merged if there are no further issues.

@junrushao
junrushao merged commit a16ccf4 into apache:mainSep 29, 2021
AndrewZhaoLuo added a commit to AndrewZhaoLuo/tvm that referenced this pull request Sep 29, 2021
@AndrewZhaoLuo
Merge branch 'main' into aluo/onnx/support-nllloss-tests
6f5aeb1
* main:
Fix flaky NMS test by making sure scores are unique (apache#9140)
[Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc (apache#9038)
[LLVM] Make changes needed for opaque pointers (apache#9138)
Arm(R) Ethos(TM)-U NPU codegen integration (apache#8849)
[CI] Split Integration tests out of first phase of pipeline (apache#9128)
[Meta Schedule][M3b] Runner (apache#9111)
Fix Google Mock differences between Ubuntu 18.04 and 16.04 (apache#9141)
[TIR] add loop partition hint pragma (apache#9121)
fix things (apache#9146)
[Meta Schedule][M3a] SearchStrategy (apache#9132)
[Frontend][PyTorch] support for quantized conv_transpose2d op (apache#9133)
[UnitTest] Parametrized test_conv2d_int8_intrinsics (apache#9143)
[OpenCL] Remove redundant visit statement in CodeGen. (apache#9144)
[BYOC] support arbitrary input dims for add/mul/relu of dnnl c_src codegen (apache#9127)
[Relay][ConvertLayout] Support for qnn.conv2d_transpose (apache#9139)
add nn.global_avgpool to fq2i (apache#9137)
[UnitTests] Enable minimum testing on Vulkan target in CI (apache#9093)
[Torch] Support returning quantized weights and bias for BYOC use cases (apache#9135)
[Relay] Prepare for new plan_devices.cc (part II) (apache#9130)
[microTVM][Zephyr] Add MIMXRT1050 board support (apache#9068)
AndrewZhaoLuo added a commit to AndrewZhaoLuo/tvm that referenced this pull request Sep 30, 2021
@AndrewZhaoLuo
Merge branch 'main' into aluo/support-negative-indices
c9b4589
* main: (80 commits)
Introduce centralised name transformation functions (apache#9088)
[OpenCL] Add vectorization to cuda conv2d_nhwc schedule (apache#8636)
[6/6] Arm(R) Ethos(TM)-U NPU codegen integration with `tvmc` (apache#8854)
[microTVM] Add wrapper for creating project using a MLF (apache#9090)
Fix typo (apache#9156)
[Hotfix][Testing] Wait for RPCServer to be established (apache#9150)
Update find cublas so it search default path if needed. (apache#9149)
[TIR][LowerMatchBuffer] Fix lowering strides when source region has higher dimension than the buffer (apache#9145)
Fix flaky NMS test by making sure scores are unique (apache#9140)
[Relay] Merge analysis/context_analysis.cc and transforms/device_annotation.cc (apache#9038)
[LLVM] Make changes needed for opaque pointers (apache#9138)
Arm(R) Ethos(TM)-U NPU codegen integration (apache#8849)
[CI] Split Integration tests out of first phase of pipeline (apache#9128)
[Meta Schedule][M3b] Runner (apache#9111)
Fix Google Mock differences between Ubuntu 18.04 and 16.04 (apache#9141)
[TIR] add loop partition hint pragma (apache#9121)
fix things (apache#9146)
[Meta Schedule][M3a] SearchStrategy (apache#9132)
[Frontend][PyTorch] support for quantized conv_transpose2d op (apache#9133)
[UnitTest] Parametrized test_conv2d_int8_intrinsics (apache#9143)
...
@junrushaojunrushao mentioned this pull request Nov 1, 2021
Closed
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
@zxybazh@junrushao
@spectrometerHBH@MasterJH5574@jinhongyii@vinx13Siyuan Feng@ylc
[Meta Schedule][M3a] SearchStrategy (apache#9132)
e4fba79
* Add c++ side SearchStrategy.
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
* Add python-side code & test.
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
* Add docs.
* Minor fix.
* Add workflow.
* Add docs.
* Fix docs.
* Add notes.
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@zxybazh@junrushao
@spectrometerHBH@MasterJH5574@jinhongyii@vinx13Siyuan Feng@ylc
[Meta Schedule][M3a] SearchStrategy (apache#9132)
c62c379
* Add c++ side SearchStrategy.
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
* Add python-side code & test.
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
* Add docs.
* Minor fix.
* Add workflow.
* Add docs.
* Fix docs.
* Add notes.
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Co-authored-by: Bohan Hou <32121147+spectrometerHBH@users.noreply.github.com>
Co-authored-by: Ruihang Lai <lairuihangdongdong@qq.com>
Co-authored-by: Hongyi Jin <3231950289@qq.com>
Co-authored-by: Wuwei Lin <wuwei@apache.org>
Co-authored-by: Siyuan Feng <Hzfengsy@sjtu.edu.cn>
@junrushaojunrushao changed the title [Meta Schedule][M3a] SearchStrategy[MetaSchedule][M3a] SearchStrategyJan 26, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tkonoligetkonoligetkonolige left review comments
@jcf94jcf94jcf94 approved these changes
@junrushaojunrushaojunrushao approved these changes
@areuschareuschAwaiting requested review from areusch
@comaniaccomaniacAwaiting requested review from comaniac
@HzfengsyHzfengsyAwaiting requested review from Hzfengsy
@jroeschjroeschAwaiting requested review from jroesch
@kparzysz-quickparzysz-quicAwaiting requested review from kparzysz-quic
@masahimasahiAwaiting requested review from masahi
@merrymercymerrymercyAwaiting requested review from merrymercy
@tqchentqchenAwaiting requested review from tqchen
@vinx13vinx13Awaiting requested review from vinx13
@yzhliuyzhliuAwaiting requested review from yzhliu
@zhiicszhiicsAwaiting requested review from zhiics
@ZihengJiangZihengJiangAwaiting requested review from ZihengJiang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@zxybazh@junrushao@tkonolige@jcf94