Skip to content

[MetaSchedule][M4a] Local runner - #9153

Merged
vinx13 merged 8 commits into
apache:mainfrom
shingjan:feature/20210929/local_runner
Oct 1, 2021
Merged

[MetaSchedule][M4a] Local runner#9153
vinx13 merged 8 commits into
apache:mainfrom
shingjan:feature/20210929/local_runner

Conversation

@shingjan

@shingjanshingjan commented Sep 29, 2021•
edited
Loading

Copy link
Copy Markdown

This PR is part of the meta schedule project (#8473) that adds the reference
implementation of LocalRunner with PopenPool executor and a follow-up PR of #9111 .

@vinx13@junrushao1994@zxybazh

@shingjan

shingjan commented Sep 29, 2021

Copy link
Copy Markdown
Author

One RPCRunner test is failing and I will rebase after the fix (#9150) gets in.

@junrushaojunrushao changed the title [Meta Schedule][M3a]Local runner[Meta Schedule][M4a] Local runnerSep 29, 2021
@junrushaojunrushao mentioned this pull request Sep 29, 2021
Closed
62 tasks
junrushao
junrushao reviewed Sep 29, 2021
View reviewed changes
Comment threadpython/tvm/meta_schedule/runner/local_runner.py
@junrushao

junrushao commented Sep 29, 2021

Copy link
Copy Markdown
Member

Thanks @shingjan for the PR. It's overall in good shape, and I left only one comment on potential duplication

comaniac
comaniac approved these changes Sep 30, 2021
View reviewed changes

@comaniaccomaniac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Mostly nits.

Comment threadpython/tvm/meta_schedule/runner/local_runner.py
Comment threadpython/tvm/meta_schedule/runner/local_runner.py Outdated
Comment threadpython/tvm/meta_schedule/runner/local_runner.py
junrushao
junrushao reviewed Sep 30, 2021
View reviewed changes
Comment threadpython/tvm/meta_schedule/runner/local_runner.py Outdated
junrushao
junrushao reviewed Sep 30, 2021
View reviewed changes
Comment threadpython/tvm/meta_schedule/runner/local_runner.py Outdated
@junrushao

junrushao commented Sep 30, 2021

Copy link
Copy Markdown
Member

@shingjan would you like to act accordingly to the final nitpicks so that we could get it merged soon? Thanks!

@shingjan
shingjanforce-pushed the feature/20210929/local_runner branch from 59e5a19 to a504955CompareSeptember 30, 2021 17:59
junrushao
junrushao reviewed Sep 30, 2021
View reviewed changes
Comment threadpython/tvm/meta_schedule/runner/local_runner.py Outdated
junrushao
junrushao reviewed Sep 30, 2021
View reviewed changes
Comment threadpython/tvm/meta_schedule/runner/local_runner.py Outdated
@junrushao

junrushao commented Sep 30, 2021

Copy link
Copy Markdown
Member

Thanks @shingjan! I believe the PR is in good shape

@junrushao

junrushao commented Oct 1, 2021

Copy link
Copy Markdown
Member

Thanks @shingjan! I'm rerunning the GitHub Action jobs due to flakiness

@junrushao

junrushao commented Oct 1, 2021•
edited
Loading

Copy link
Copy Markdown
Member

@shingjan would you mind rebasing to the latest main given the flakiness has been fixed by commit df24393

Yuanjing Shiand others added 6 commits October 1, 2021 11:10
Yuanjing Shishingjan
[Meta Schedule][M3a]Local runner (apache#479)
be8cd97
* localrunner
* localrunner init
* linting
* address comments
* exception handling
* single run testcase
* two more cases added
* add exception case
* one case with AddModule added
* address comments
* address comments
* remove unused dependency
* optional arguments
shingjan
linting
2f91422
shingjan
add utils
cb3c7d7
shingjan
linting
04ac292
shingjan
address comments
a0cb3da
shingjan
remove non-ascii commennt
f91c66e
@shingjan
shingjanforce-pushed the feature/20210929/local_runner branch from 9c2b8a4 to 9f293d5CompareOctober 1, 2021 18:10
@vinx13
vinx13 merged commit 574a47c into apache:mainOct 1, 2021
@vinx13

vinx13 commented Oct 1, 2021

Copy link
Copy Markdown
Member

Thanks @shingjan@junrushao1994@comaniac this is merged

@junrushaojunrushao mentioned this pull request Oct 2, 2021
Merged
@junrushaojunrushao mentioned this pull request Nov 1, 2021
Closed
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
Yuanjing Shi@ylc
[Meta Schedule][M4a] Local runner (apache#9153)
e2bbb2b
* [Meta Schedule][M3a]Local runner (apache#479)
* localrunner
* localrunner init
* linting
* address comments
* exception handling
* single run testcase
* two more cases added
* add exception case
* one case with AddModule added
* address comments
* address comments
* remove unused dependency
* optional arguments
* linting
* add utils
* linting
* address comments
* remove non-ascii commennt
* add sanity check
* address comments
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
Yuanjing Shi@ylc
[Meta Schedule][M4a] Local runner (apache#9153)
eac5062
* [Meta Schedule][M3a]Local runner (apache#479)
* localrunner
* localrunner init
* linting
* address comments
* exception handling
* single run testcase
* two more cases added
* add exception case
* one case with AddModule added
* address comments
* address comments
* remove unused dependency
* optional arguments
* linting
* add utils
* linting
* address comments
* remove non-ascii commennt
* add sanity check
* address comments
@junrushaojunrushao changed the title [Meta Schedule][M4a] Local runner[MetaSchedule][M4a] Local runnerJan 26, 2022
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@comaniaccomaniaccomaniac approved these changes
@junrushaojunrushaojunrushao approved these changes
@areuschareuschAwaiting requested review from areusch
@jroeschjroeschAwaiting requested review from jroesch
@merrymercymerrymercyAwaiting requested review from merrymercy
@tqchentqchenAwaiting requested review from tqchen
@yzhliuyzhliuAwaiting requested review from yzhliu
@zhiicszhiicsAwaiting requested review from zhiics

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@shingjan@junrushao@vinx13@comaniac