Uh oh!
There was an error while loading. Please reload this page.
Adding annotations for tir.allocate - #9168
Conversation
Uh oh!
There was an error while loading. Please reload this page.
9081089 to
506c2f2Compare8e4a870 to
f4f916dCompareareusch
commented
Oct 4, 2021
please tag the tracking issue @manupa-arm |
vinx13
left a comment
There was a problem hiding this comment.
Some minor comments, otherwise LGTM
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This commit is adding annotations for tir.allocate node to be used as hints for future transformations. Change-Id: I02a3a875c38c3edd449385da5b741ef4958bb47f
f4f916d to
4971d09Comparemanupak
commented
Oct 5, 2021
Thanks @vinx13 . |
Hzfengsy
left a comment
There was a problem hiding this comment.
Please also update the Script syntax and add a testcase.
The related codes are here:
tvm/python/tvm/script/tir/scope_handler.py
Lines 106 to 115 in d9a5ff5
Hzfengsy
commented
Oct 5, 2021
Please also update the three printers: Line 385 in d9a5ff5 tvm/src/printer/tvmscript_printer.cc Line 762 in d9a5ff5 tvm/src/printer/tir_text_printer.cc Line 449 in d9a5ff5 |
manupak
commented
Oct 6, 2021
@Hzfengsy thanks for the review! I think I've done the necessary changes now. PTAL. |
00d2218 to
31d8db9Compare31d8db9 to
5ff4f7fCompare* adding tvmscript support * adding tir text printing support Change-Id: Id0b6725b2e79c23f6b8ff192772f1ea4125a27c2
5ff4f7f to
94b7435Comparemanupak
commented
Oct 7, 2021
Hzfengsy
commented
Oct 7, 2021
Sorry for the late response. Thanks @manupa-arm. |
* Adding annotation for tir.allocate This commit is adding annotations for tir.allocate node to be used as hints for future transformations. Change-Id: I02a3a875c38c3edd449385da5b741ef4958bb47f * Adding annotation for tir.allocate * adding tvmscript support * adding tir text printing support Change-Id: Id0b6725b2e79c23f6b8ff192772f1ea4125a27c2
* Adding annotation for tir.allocate This commit is adding annotations for tir.allocate node to be used as hints for future transformations. Change-Id: I02a3a875c38c3edd449385da5b741ef4958bb47f * Adding annotation for tir.allocate * adding tvmscript support * adding tir text printing support Change-Id: Id0b6725b2e79c23f6b8ff192772f1ea4125a27c2
This commit is adding annotations for tir.allocate node to be used as hints for future transformations.
Please refer to the discussion : apache/tvm-rfcs#23
cc: @tqchen@junrushao1994@areusch