Uh oh!
There was an error while loading. Please reload this page.
[Relay] Remove unnecessary Optional<IRModule> argument to ToANormalForm and friends - #9197
Merged
Merged
Conversation
We don't need the Optional<IRModule> on ToANormalForm and friends.
mbs-octoml
requested review from
MarisaKirisame, ZihengJiang, anijain2305, jroesch, junrushao, jwfromm, mbrookhart, slyubomirsky, vinx13, wweic, yzhliu and zhiics
as code ownersOctober 4, 2021 22:20
junrushao
approved these changes
Oct 5, 2021
u99127
commented
Oct 5, 2021
Could we fix the commit message to reflect what exactly is being fixed ? |
mbs-octoml
commented
Oct 5, 2021
ContributorAuthor
Updated, ready to merge. |
mbs-octoml
commented
Oct 5, 2021
ContributorAuthor
Arrrg! Updating description triggers a CI re-run :-((( |
ylc pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 7, 2022
We don't need the Optional<IRModule> on ToANormalForm and friends.
ylc pushed a commit
to ylc/tvm
that referenced
this pull request
Jan 13, 2022
We don't need the Optional<IRModule> on ToANormalForm and friends.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to address Christopher's comment in #8788. The nature of ToANF means we don't need to worry about passing in an IRModule context to recover the result device for a global function.