') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [AlterLayout] Strided slice layout transform fix (disallow NCHW4c -> NCHW etc properly) by masahi · Pull Request #9245 · apache/tvm · GitHub
Skip to content

[AlterLayout] Strided slice layout transform fix (disallow NCHW4c -> NCHW etc properly) - #9245

Merged
vinx13 merged 2 commits into
apache:mainfrom
masahi:strided-slice-layout-transform-fix
Oct 11, 2021
Merged

[AlterLayout] Strided slice layout transform fix (disallow NCHW4c -> NCHW etc properly)#9245
vinx13 merged 2 commits into
apache:mainfrom
masahi:strided-slice-layout-transform-fix

Conversation

@masahi

@masahimasahi commented Oct 11, 2021•
edited
Loading

Copy link
Copy Markdown
Member

Fix#8759

Looking at StridedSliceInferCorrectLayout, I believe we do not allow propagating a new layout through strided_slice if the original layout is a packed one such as NCHW4c and the new layout is unpacked one, see

tvm/src/relay/op/tensor/transform.cc

Lines 2639 to 2641 in 7deebc6

if (!axis.IsPrimal()) {
// original layout that contains splitted axes is not supported
return out_default;
. But #8759 exhibits a case where this check fails to detect NCHW4c -> NCHW case.

cc @vinx13 who wrote this code.

@vinx13
vinx13 merged commit 95cde0c into apache:mainOct 11, 2021
masahi added a commit to Laurawly/tvm-1 that referenced this pull request Oct 14, 2021
@masahi
[AlterLayout] Strided slice layout transform fix (disallow NCHW4c -> …
586fa42
…NCHW etc properly) (apache#9245)
* prohibit propagating through packed to unpacked layout
* add test
@junrushaojunrushao mentioned this pull request Nov 2, 2021
Closed
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
@masahi@ylc
[AlterLayout] Strided slice layout transform fix (disallow NCHW4c -> …
983caa9
…NCHW etc properly) (apache#9245)
* prohibit propagating through packed to unpacked layout
* add test
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@masahi@ylc
[AlterLayout] Strided slice layout transform fix (disallow NCHW4c -> …
4220cbe
…NCHW etc properly) (apache#9245)
* prohibit propagating through packed to unpacked layout
* add test
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinx13vinx13vinx13 approved these changes
@anijain2305anijain2305Awaiting requested review from anijain2305
@areuschareuschAwaiting requested review from areusch
@comaniaccomaniacAwaiting requested review from comaniac
@jroeschjroeschAwaiting requested review from jroesch
@junrushaojunrushaoAwaiting requested review from junrushao
@jwfrommjwfrommAwaiting requested review from jwfromm
@MarisaKirisameMarisaKirisameAwaiting requested review from MarisaKirisame
@mbrookhartmbrookhartAwaiting requested review from mbrookhart
@merrymercymerrymercyAwaiting requested review from merrymercy
@slyubomirskyslyubomirskyAwaiting requested review from slyubomirsky
@tqchentqchenAwaiting requested review from tqchen
@wweicwweicAwaiting requested review from wweic
@yzhliuyzhliuAwaiting requested review from yzhliu
@zhiicszhiicsAwaiting requested review from zhiics
@ZihengJiangZihengJiangAwaiting requested review from ZihengJiang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug] AlterLayout doesn't correctly wrap strided_slice with layout_transforms

2 participants

@masahi@vinx13