') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); [codegen][LLVM][bugfix] Specify argument to FastMathFlags setAllowContract by slyubomirsky · Pull Request #9337 · apache/tvm · GitHub
Skip to content

[codegen][LLVM][bugfix] Specify argument to FastMathFlags setAllowContract - #9337

Merged
masahi merged 1 commit into
apache:mainfrom
slyubomirsky:CheckAllowContract-fix
Oct 21, 2021
Merged

[codegen][LLVM][bugfix] Specify argument to FastMathFlags setAllowContract#9337
masahi merged 1 commit into
apache:mainfrom
slyubomirsky:CheckAllowContract-fix

Conversation

@slyubomirsky

@slyubomirskyslyubomirsky commented Oct 21, 2021

Copy link
Copy Markdown
Contributor

PR #9223 added a fast math flags setting to the LLVM codegen. The setting checks if the LLVM version is >= 6.0 and calls the below lines

 if (fast_math_contract) {
fmf.setAllowContract();
}

Recent LLVM versions have a default argument of true to llvm::FastMathFlags::setAllowContract(). However, LLVM 6.0 does not have a default argument for that method, so this fails to compile because it expects an explicit argument. This PR makes the argument explicit to be compatible with LLVM 6.0 (the version my system happened to have).

@slyubomirsky

slyubomirsky commented Oct 21, 2021

Copy link
Copy Markdown
ContributorAuthor

Please review @masahi (reviewer on PR #9223)

@AndrewZhaoLuo

AndrewZhaoLuo commented Oct 21, 2021•
edited
Loading

Copy link
Copy Markdown
Contributor

Can you set the other flags to true explicitly. It appears I missed this in 6.x (I swear they had default args): https://github.com/llvm/llvm-project/blob/release/6.x/llvm/include/llvm/IR/Operator.h

Edit: Actually nvrmind, I cant read, this LGTM

@slyubomirsky

slyubomirsky commented Oct 21, 2021•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I can fix others too. I only fixed the one that was breaking my own build locally ;) Wow, how weird, that is literally the only one with an arg

@masahi
masahi merged commit 88bf112 into apache:mainOct 21, 2021
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
@slyubomirsky@ylc
Specify argument to FastMathFlags setAllowContract (apache#9337)
63bc41d
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
@slyubomirsky@ylc
Specify argument to FastMathFlags setAllowContract (apache#9337)
3c0e274
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@masahimasahimasahi approved these changes
@junrushaojunrushaoAwaiting requested review from junrushao
@kparzysz-quickparzysz-quicAwaiting requested review from kparzysz-quic
@tqchentqchenAwaiting requested review from tqchen
@vinx13vinx13Awaiting requested review from vinx13
@ZihengJiangZihengJiangAwaiting requested review from ZihengJiang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@slyubomirsky@AndrewZhaoLuo@masahi