Uh oh!
There was an error while loading. Please reload this page.
Add pass to fold type transformations into function signature - #9357
Add pass to fold type transformations into function signature#9357anwang2009 wants to merge 13 commits into
Conversation
jroesch
commented
Oct 26, 2021
cc @electriclilies can you review this one? |
electriclilies
left a comment
There was a problem hiding this comment.
Some general comments -- overall looks like you are on the right track!
(Also I realized after reviewing that this is still marked as draft, oops. let me know when it is ready for another review and I'll take a look again)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
electriclilies
commented
Oct 27, 2021
After taking another look, I'm a bit confused how you're doing the rewrite of the function parameters, added some questions related to that |
Uh oh!
There was an error while loading. Please reload this page.
masahi
commented
Jan 9, 2022
@anwang2009 Please take a look at the CI problem. |
AndrewZhaoLuo
commented
Feb 1, 2022
@anwang2009 do you still have interest in merging this PR? |
areusch
commented
Apr 8, 2022
@AndrewZhaoLuo@anwang2009 are you guys doing this as part of #8296 or is that just related? |
@anwang2009 any plans to continue working on this PR? I think people do request things like this. |
anwang2009
commented
Apr 11, 2022
Unrelated to that issue linked. I plan to continue working on this, I just need to find the time 🙃 |
As title.
This transformer gives users more control over where preprocessing steps may be located, and what input types their relay program can accept