Skip to content

[TIR] Add type hint for TIR - #9432

Merged
junrushao merged 32 commits into
apache:mainfrom
shingjan:tir-type-hint
Nov 9, 2021
Merged

[TIR] Add type hint for TIR #9432
junrushao merged 32 commits into
apache:mainfrom
shingjan:tir-type-hint

Conversation

@shingjan

@shingjanshingjan commented Nov 2, 2021•
edited
Loading

Copy link
Copy Markdown

This PR intends to add type hinting and enable auto-completion for TIR and namespace tvm.script.tir as T as a follow-up PR for this.

Co-authored-by: Zihao Ye <zihaoye.cs@gmail.com>

cc: @vinx13@junrushao1994

junrushao
junrushao reviewed Nov 2, 2021
View reviewed changes
Comment threadpython/tvm/tir/__init__.pyi Outdated
@shingjanshingjan changed the title [TIR][WIP] Add type hint for TIR [WIP][TIR] Add type hint for TIR Nov 2, 2021
@shingjanshingjan changed the title [WIP][TIR] Add type hint for TIR [TIR] Add type hint for TIR Nov 2, 2021
@shingjan
shingjan requested a review from vinx13November 2, 2021 23:25
@vinx13

vinx13 commented Nov 2, 2021

Copy link
Copy Markdown
Member

We will need a few test cases that cover various TIR elements (block related: T.block, T.match_buffer, T.alloc_buffer, T.block_attr, loop related: T.grid, T.serial, T.thread_binding, etc). You can find good examples of TIR scripts written for previous test cases. Please also add script to run the tests to https://github.com/apache/tvm/blob/main/tests/scripts/task_mypy.sh and make sure it can pass the tests

vinx13
vinx13 requested changes Nov 3, 2021
View reviewed changes
Comment threadpython/tvm/script/tir/__init__.pyi Outdated
Comment threadpython/tvm/script/tir/__init__.pyi Outdated
Comment threadpython/tvm/script/tir/__init__.pyi Outdated
Comment threadmypy.ini Outdated
Comment threadtests/python/unittest/test_tvmscript_type.py Outdated
vinx13
vinx13 reviewed Nov 3, 2021
View reviewed changes
Comment threadpython/tvm/script/tir/__init__.pyi Outdated
Comment threadpython/tvm/script/tir/__init__.pyi Outdated
@shingjan
shingjan requested a review from vinx13November 3, 2021 22:55
vinx13
vinx13 reviewed Nov 3, 2021
View reviewed changes

@vinx13vinx13 left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be great to also run pylint over the test file to see the TIR script can pass pylint after adding these stubs. There are also some issues on CI

Comment threadpython/tvm/script/tir/__init__.pyi Outdated
Comment threadpython/tvm/script/tir/__init__.pyi Outdated
@shingjan
shingjan marked this pull request as ready for review November 4, 2021 08:17
@shingjan
shingjan requested a review from vinx13November 4, 2021 08:17
vinx13
vinx13 reviewed Nov 4, 2021
View reviewed changes
Comment threadpython/tvm/script/tir/__init__.pyi Outdated
Comment threadpython/tvm/script/tir/__init__.pyi Outdated
Comment threadpython/tvm/script/tir/__init__.pyi Outdated
Comment threadpython/tvm/script/tir/__init__.pyi Outdated
Comment threadtests/python/unittest/test_tvmscript_type.py Outdated
@shingjan
shingjan requested a review from vinx13November 4, 2021 21:15
vinx13
vinx13 reviewed Nov 4, 2021
View reviewed changes

@vinx13vinx13 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be great to also add test commands to pylint.sh

Comment threadpython/tvm/script/tir/__init__.pyi Outdated
Comment threadpython/tvm/script/tir/__init__.pyi Outdated
vinx13
vinx13 reviewed Nov 4, 2021
View reviewed changes
Comment threadtests/python/unittest/test_tvmscript_type.py Outdated
vinx13
vinx13 reviewed Nov 8, 2021
View reviewed changes
Comment threadpython/tvm/script/tir/__init__.pyi Outdated
Comment threadpython/tvm/script/tir/__init__.pyi Outdated
@shingjan
shingjan requested a review from vinx13November 8, 2021 20:54
vinx13
vinx13 reviewed Nov 8, 2021
View reviewed changes
Comment threadpython/tvm/script/tir/__init__.pyi Outdated
@shingjan
shingjan requested a review from vinx13November 8, 2021 22:54
@junrushao

junrushao commented Nov 9, 2021

Copy link
Copy Markdown
Member

Quick question: do we plan to add docstring in this PR?

@junrushao
junrushao merged commit 00b0a81 into apache:mainNov 9, 2021
AndrewZhaoLuo added a commit to AndrewZhaoLuo/tvm that referenced this pull request Nov 12, 2021
@AndrewZhaoLuo
Merge branch 'main' into aluo/qnn/conv2d-transpose-fq2i
da7a16b
* main: (119 commits)
[Topi][Op][PyTorch][Vitas] Fix inconsistent kernel layout conventions for conv2d_transpose (apache#9336)
Fix repository URL in ubuntu_install_rocm.sh (apache#9425)
Add LLVM-13 installation to Docker setup (apache#9498)
[Relay] Use target_host determined at Relay level instead of recalculating it (apache#9499)
Arm(R) Ethos(TM)-U NPU BinaryElementwise operators support (apache#9442)
[COMMUNITY] Junru's and Wuwei's PGP key for ASF release (apache#9488)
Add default for split op (apache#9489)
[HOTFIX][TARGET] Change LOG in compilation config to DLOG (apache#9486)
Fixed some warnings about lambda's closures that are bigger than necessary (apache#9481)
[Support] Add libinfo into the runtime build (apache#9310)
Change Call with TIRCallAttrs to call_lowered op (apache#9312)
[ETHOSN] Streamline Ethos(TM)-N cross-compile rpc usage (apache#9477)
[CMSIS-NN] Assert correct amount of CMSIS-NN artifacts in MLF (apache#9480)
[MicroTVM][PyTest] Explicitly skip MicroTVM unittests. (apache#9335)
[microNPU] Replace ICHECK with diagnostic context in type inference (apache#9470)
Better host handling in CompilationConfig & debug printing (apache#9460)
[AOT][Tests] Use pre-built libraries in Reference System tests (apache#9271)
[TIR] Add type hint for TIR (apache#9432)
[TVMC] Add test for quantized pytorch model (apache#9467)
[CMSIS-NN] Convert CMSIS-NN to use Target Hooks (apache#9397)
...
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Dec 1, 2021
Yuanjing Shi@mehrdadh
[TIR] Add type hint for TIR (apache#9432)
76d1604
* add init
* get rid of span
* afs header
* update scope_handler
* rm tir/__init__.pyi
* fix linting
* fix lint
* new test case
* add axis module
* address comments
* redefine ty types
* lint
* address comments
* address comments
* fix ci
* add test cases
* fix CI
* address comments
* add types
* mypy --strict
* comments
* update test comments
* linting fix
* address comments
* add pylint for tir type check
* address comments
* move doc string
* comments
* getter setter
* add PrimExpr, IterVar and Var
* add sequence
* change for handle
mehrdadh pushed a commit to mehrdadh/tvm that referenced this pull request Dec 1, 2021
Yuanjing Shi@mehrdadh
[TIR] Add type hint for TIR (apache#9432)
91cafc1
* add init
* get rid of span
* afs header
* update scope_handler
* rm tir/__init__.pyi
* fix linting
* fix lint
* new test case
* add axis module
* address comments
* redefine ty types
* lint
* address comments
* address comments
* fix ci
* add test cases
* fix CI
* address comments
* add types
* mypy --strict
* comments
* update test comments
* linting fix
* address comments
* add pylint for tir type check
* address comments
* move doc string
* comments
* getter setter
* add PrimExpr, IterVar and Var
* add sequence
* change for handle
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 7, 2022
Yuanjing Shi@ylc
[TIR] Add type hint for TIR (apache#9432)
000481d
* add init
* get rid of span
* afs header
* update scope_handler
* rm tir/__init__.pyi
* fix linting
* fix lint
* new test case
* add axis module
* address comments
* redefine ty types
* lint
* address comments
* address comments
* fix ci
* add test cases
* fix CI
* address comments
* add types
* mypy --strict
* comments
* update test comments
* linting fix
* address comments
* add pylint for tir type check
* address comments
* move doc string
* comments
* getter setter
* add PrimExpr, IterVar and Var
* add sequence
* change for handle
yangulei pushed a commit to yangulei/tvm that referenced this pull request Jan 11, 2022
Yuanjing Shi@yangulei
[TIR] Add type hint for TIR (apache#9432)
60ec891
* add init
* get rid of span
* afs header
* update scope_handler
* rm tir/__init__.pyi
* fix linting
* fix lint
* new test case
* add axis module
* address comments
* redefine ty types
* lint
* address comments
* address comments
* fix ci
* add test cases
* fix CI
* address comments
* add types
* mypy --strict
* comments
* update test comments
* linting fix
* address comments
* add pylint for tir type check
* address comments
* move doc string
* comments
* getter setter
* add PrimExpr, IterVar and Var
* add sequence
* change for handle
ylc pushed a commit to ylc/tvm that referenced this pull request Jan 13, 2022
Yuanjing Shi@ylc
[TIR] Add type hint for TIR (apache#9432)
89ef251
* add init
* get rid of span
* afs header
* update scope_handler
* rm tir/__init__.pyi
* fix linting
* fix lint
* new test case
* add axis module
* address comments
* redefine ty types
* lint
* address comments
* address comments
* fix ci
* add test cases
* fix CI
* address comments
* add types
* mypy --strict
* comments
* update test comments
* linting fix
* address comments
* add pylint for tir type check
* address comments
* move doc string
* comments
* getter setter
* add PrimExpr, IterVar and Var
* add sequence
* change for handle
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinx13vinx13vinx13 approved these changes
@junrushaojunrushaoAwaiting requested review from junrushao
@areuschareuschAwaiting requested review from areusch
@comaniaccomaniacAwaiting requested review from comaniac
@HzfengsyHzfengsyAwaiting requested review from Hzfengsy
@icemelonicemelonAwaiting requested review from icemelon
@jroeschjroeschAwaiting requested review from jroesch
@kparzysz-quickparzysz-quicAwaiting requested review from kparzysz-quic
@masahimasahiAwaiting requested review from masahi
@merrymercymerrymercyAwaiting requested review from merrymercy
@tqchentqchenAwaiting requested review from tqchen
@yzhliuyzhliuAwaiting requested review from yzhliu
@zhiicszhiicsAwaiting requested review from zhiics
@ZihengJiangZihengJiangAwaiting requested review from ZihengJiang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@shingjan@vinx13@junrushao