Uh oh!
There was an error while loading. Please reload this page.
[TIR][USMP] Integrating USMP to AoT Executor - #9565
Merged
Merged
Conversation
manupak
requested review from
Hzfengsy, MarisaKirisame, ZihengJiang, anijain2305, areusch, comaniac, icemelon, jroesch, junrushao, jwfromm, kazum, kparzysz-quic, liangfu, masahi, mbrookhart, merrymercy, slyubomirsky, tmoreau89, tqchen, vinx13, wweic, yzhliu and zhiics
as code ownersNovember 23, 2021 17:35
21 tasks
manupakforce-pushed
the
usmp_integration
branch
from
November 23, 2021 17:55
6c1eb12 to
3b04e8eComparemanupak
marked this pull request as draft
November 23, 2021 17:56
ContributorAuthor
Putting this to draft as it contains the contents of the dependent PRs (See above) |
manupakforce-pushed
the
usmp_integration
branch
from
December 9, 2021 20:19
3b04e8e to
b029fbeComparemanupak
marked this pull request as ready for review
December 9, 2021 20:19
manupakforce-pushed
the
usmp_integration
branch
from
December 13, 2021 13:53
b029fbe to
581f50bComparemanupakforce-pushed
the
usmp_integration
branch
2 times, most recently
from
January 14, 2022 17:25
dfa7c93 to
51c0816CompareThis commit intergrates USMP with the AoT executor codegen. Additionally, this commit introduces two PassContext options to disable_usmp and disable_storage_rewrite. Change-Id: I98d905fab7f49c2de52e126115953a40b0821e21
* This commit breaks out the USMP related tests to test_crt_aot_usmp.py. * Switched the polarity of the pass config option to explicitly enable USMP rather than disable. Change-Id: Id4bf35b18479b70924ec24e6bb7ba2682b05326e
* Swap pool var and output var ordering in the main function Change-Id: Id03748e6f3528399a0ddd9cc2d011adfcee8d554
* Improving comments * Changing the usage of tir Bool to just plain bool Change-Id: I907cf9a0befa172183ae488bb3b94660aad39807
* fixing unit tests to scope With<Target> * removing global sanitization of var names Change-Id: Ifa8934f94744eeaac13e4b4ddcd671842c3dcb21
* changing unpacked_api to accept PrimFunc without buffer_maps. Change-Id: I97e8df5272df7f1f8313f184aa660924989940e3
* Restoring the conditional behaviour as we are getting PrimFuncs without buffer maps. Change-Id: Icd374353e0947515c523d506c1e7c02cf5d930b4
* Adds tir includes to source_module.cc Change-Id: I8ad5654ea32abb3aabc0fcc9ef8157a609e9d2dc
* fixing c device api tests Change-Id: I47ac38b5664a00f36b293a0d9d96330d4206173d
* moving algo/algo.h to algorithms.h * creating two functions for USMP and StorageRewrite * expanding codegen variable names to more descriptive * removing unncessary print functions and print statements * re-using relay::backend::SanitizeName Change-Id: I890caa0104c07a4883eb0c34d3bfcfb8bb56653f
Moving PrintType from codegen_c.cc to codegen_source_base.cc to be accessible by source_module.cc Change-Id: Icb6a85de4c26110d2fea370fbd75e02a3639de59
Moving runtime::metadata to be ExecutorCodegeMetadata as it contains metadata produced by ExecutorCodegen for actual codegeneration (not a runtime component). Change-Id: I13e95573ef331fb995281dbe220db01a7aa91add
Remove unused function declaration Change-Id: Ib274553938eb5c82fe2b30cecc982481cff3937d
* Remove unncessary header file inclusion Change-Id: I5575d6226baa74fe09dce1c71176e557d84f669a
manupakforce-pushed
the
usmp_integration
branch
from
January 14, 2022 19:12
51c0816 to
526f307Comparemanupak
commented
Jan 17, 2022
ContributorAuthor
This is now green! and I think I've addresses your comments. Could you take another look when you have some time ? |
manupak
commented
Jan 18, 2022
ContributorAuthor
Mousius
requested changes
Jan 18, 2022
Mousius
left a comment
Member
There was a problem hiding this comment.
Just minor comments from me, I think the rest of my comments were dealt with 😸
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
* fixed a typo * Improved consistenty with arg names for type printers Change-Id: I25263831c8bbfa11e6e0d6f8f8dd998d254294ff
areusch
approved these changes
Jan 18, 2022
| os << "float"; | ||
| return; | ||
| } | ||
| if (type.bits() == 64) { |
Contributor
There was a problem hiding this comment.
should this have an else CHECK(false)? same question elsewhere
ContributorAuthor
There was a problem hiding this comment.
I was just moving the already existing implementation to the base class :).
Moreover, there was a LOG(FATAL) at the bottom that should cover this case anyway.
manupak
commented
Jan 19, 2022
ContributorAuthor
@Mousius do you think we could merge this one ? |
Mousius
approved these changes
Jan 19, 2022
Mousius
left a comment
Member
There was a problem hiding this comment.
@Mousius do you think we could merge this one ?
Definitely @manupa-arm! Thanks for the reviews from @mbs-octoml and @areusch!
yuanfz98 pushed a commit
to yuanfz98/tvm
that referenced
this pull request
Jan 24, 2022
This commit integrates USMP with the AoT executor codegen. Additionally, this commit introduces two PassContext options to disable_usmp and disable_storage_rewrite. Moved PrintType from codegen_c.cc to codegen_source_base.cc to be accessible by source_module.cc Moved runtime::metadata to be ExecutorCodegeMetadata as it contains metadata produced by ExecutorCodegen for actual code generation (not a runtime component).
crazydemo pushed a commit
to crazydemo/tvm
that referenced
this pull request
Jan 27, 2022
This commit integrates USMP with the AoT executor codegen. Additionally, this commit introduces two PassContext options to disable_usmp and disable_storage_rewrite. Moved PrintType from codegen_c.cc to codegen_source_base.cc to be accessible by source_module.cc Moved runtime::metadata to be ExecutorCodegeMetadata as it contains metadata produced by ExecutorCodegen for actual code generation (not a runtime component).
ylc pushed a commit
to ylc/tvm
that referenced
this pull request
Feb 16, 2022
This commit integrates USMP with the AoT executor codegen. Additionally, this commit introduces two PassContext options to disable_usmp and disable_storage_rewrite. Moved PrintType from codegen_c.cc to codegen_source_base.cc to be accessible by source_module.cc Moved runtime::metadata to be ExecutorCodegeMetadata as it contains metadata produced by ExecutorCodegen for actual code generation (not a runtime component).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC : https://github.com/apache/tvm-rfcs/blob/main/rfcs/0009_Unified_Static_Memory_Planning.md
This commit integrates the USMP to AoT executor codegen as a Pass.
It also introduces two PassContext options to disable USMP as well as
StorageRewrite passes. Currently it will only support U1 usecase where
TVM internally generates a workspace buffer. The creation of constant
buffers will be added when we have tir.allocate_const support.